| commit | d15e7e48c72b1fde81b1c8d29ab29a19086887e0 | [log] [tgz] |
|---|---|---|
| author | Martin Kreichgauer <[email protected]> | Fri Feb 26 06:54:22 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Feb 26 06:54:22 2021 |
| tree | 21841446d9368941eeae83c466feb636cae01f7f | |
| parent | 6b36a2a88ab082230261201520142f746691895c [diff] |
fido: make U2FClient::HasCredential non-blocking Calls to dbus::ObjectProxy::CallMethodAndBlock() must be made on the DBus thread, while //device/fido code generally runs on the UI thread. Hence, invocations of U2F::HasCredentialBlocking() were DCHECK-ing. Instead, reshuffle FidoRequestHandler to support checking for an existing credential asynchronously. The check must complete before the OnTransportAvailabilityEnumerated() on |observer_| is invoked, so it must gate the |notify_observer_callback_| barrier. Bug: 1181990 Change-Id: I9c3ded2d65b575710b7a2cafb23eabb95da03b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719488 Commit-Queue: Martin Kreichgauer <[email protected]> Reviewed-by: Adam Langley <[email protected]> Cr-Commit-Position: refs/heads/master@{#858048}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.