Fixed numbering and added missing .py suffixes in updating_clang.md
gsutil.py is in depot_tools, which should be in the PATH. gsutil without .py isn't in the PATH at least on my system.
Change-Id: I315357e9b58fb9decdc273fab64e8d8d04174011
Reviewed-on: https://chromium-review.googlesource.com/669821
Commit-Queue: Bob Haarman <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/master@{#502427}
diff --git a/docs/updating_clang.md b/docs/updating_clang.md
index f8020e4..52ad098 100644
--- a/docs/updating_clang.md
+++ b/docs/updating_clang.md
@@ -9,33 +9,35 @@
1. If the clang upload try bots succeed, copy the binaries from the staging
bucket to the production one. For example:
-```
-$ export rev=123456-1
-$ for x in Linux_x64 Mac Win ; do \
- gsutil cp -n -a public-read gs://chromium-browser-clang-staging/$x/clang-$rev.tgz \
- gs://chromium-browser-clang/$x/clang-$rev.tgz ; \
- gsutil cp -n -a public-read gs://chromium-browser-clang-staging/$x/llvmobjdump-$rev.tgz \
- gs://chromium-browser-clang/$x/llvmobjdump-$rev.tgz ; \
- gsutil cp -n -a public-read gs://chromium-browser-clang-staging/$x/translation_unit-$rev.tgz \
- gs://chromium-browser-clang/$x/translation_unit-$rev.tgz ; \
- gsutil cp -n -a public-read gs://chromium-browser-clang-staging/$x/llvm-code-coverage-$rev.tgz \
- gs://chromium-browser-clang/$x/llvm-code-coverage-$rev.tgz ; \
- done
-```
-
+ ```shell
+ $ export rev=123456-1
+ $ for x in Linux_x64 Mac Win ; do \
+ gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/clang-$rev.tgz \
+ gs://chromium-browser-clang/$x/clang-$rev.tgz ; \
+ gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/llvmobjdump-$rev.tgz \
+ gs://chromium-browser-clang/$x/llvmobjdump-$rev.tgz ; \
+ gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/translation_unit-$rev.tgz \
+ gs://chromium-browser-clang/$x/translation_unit-$rev.tgz ; \
+ gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/llvm-code-coverage-$rev.tgz \
+ gs://chromium-browser-clang/$x/llvm-code-coverage-$rev.tgz ; \
+ done
+ ```
+
1. Run the goma package update script to push these packages to goma. If you do
not have the necessary credentials to do the upload, ask [email protected]
to find someone who does
1. Run an exhaustive set of try jobs to test the new compiler:
-```
- git cl try &&
+
+ ```shell
+ git cl try && \
git cl try -m tryserver.chromium.mac -b mac_chromium_asan_rel_ng \
-b ios-device && \
git cl try -m tryserver.chromium.linux -b linux_chromium_chromeos_dbg_ng \
-b linux_chromium_chromeos_asan_rel_ng -b linux_chromium_msan_rel_ng \
-b fuchsia -b linux_chromium_cfi_rel_ng &&
- git cl try -m tryserver.blink -b linux_trusty_blink_rel
-```
+ git cl try -m tryserver.blink -b linux_trusty_blink_rel
+ ```
+
1. Commit roll CL from the first step
1. The bots will now pull the prebuilt binary, and goma will have a matching
binary, too.