Adding isolate script targets for all remaining C++ perf tests.
BUG=chromium:663372
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2487283002
Cr-Commit-Position: refs/heads/master@{#431924}
diff --git a/BUILD.gn b/BUILD.gn
index f589a3a..f2c86359 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -988,7 +988,7 @@
if (is_win) {
data_deps += [
"//chrome/installer/mini_installer:mini_installer",
- "//third_party/angle/src/tests:angle_perftests",
+ "//chrome/test:angle_perftests",
]
} else {
data_deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index abb52421..073835d 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -2924,6 +2924,14 @@
]
}
+ data = [
+ # Needed for isolate script to execute.
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//testing/scripts/run_gtest_perf_test.py",
+ "//tools/perf/generate_legacy_perf_dashboard_json.py",
+ ]
+
# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}
@@ -2966,6 +2974,23 @@
]
}
+group("angle_perftests") {
+ testonly = true
+ if (is_win) {
+ data_deps = [
+ "//third_party/angle/src/tests:angle_perftests",
+ ]
+ }
+
+ data = [
+ # Needed for isolate script to execute.
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//testing/scripts/run_gtest_perf_test.py",
+ "//tools/perf/generate_legacy_perf_dashboard_json.py",
+ ]
+}
+
js2gtest("unit_tests_js") {
test_type = "unit"
sources = [
@@ -4977,6 +5002,14 @@
"//testing/perf",
]
+ data = [
+ # Needed for isolate script to execute.
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//testing/scripts/run_gtest_perf_test.py",
+ "//tools/perf/generate_legacy_perf_dashboard_json.py",
+ ]
+
if (is_win) {
configs -= [ "//build/config/win:default_incremental_linking" ]
configs +=
diff --git a/components/tracing/BUILD.gn b/components/tracing/BUILD.gn
index 1dabb29..b73c3d6 100644
--- a/components/tracing/BUILD.gn
+++ b/components/tracing/BUILD.gn
@@ -132,6 +132,14 @@
"//testing/perf",
]
+ data = [
+ # Needed for isolate script to execute.
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//testing/scripts/run_gtest_perf_test.py",
+ "//tools/perf/generate_legacy_perf_dashboard_json.py",
+ ]
+
if (is_android) {
deps += [ "//testing/android/native_test:native_test_native_code" ]
}
diff --git a/gpu/BUILD.gn b/gpu/BUILD.gn
index 04db1806..4fc3219 100644
--- a/gpu/BUILD.gn
+++ b/gpu/BUILD.gn
@@ -371,6 +371,14 @@
"//ui/gl/init",
]
+ data = [
+ # Needed for isolate script to execute.
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//testing/scripts/run_gtest_perf_test.py",
+ "//tools/perf/generate_legacy_perf_dashboard_json.py",
+ ]
+
# This target should not require the Chrome executable to run.
assert_no_deps = [ "//chrome" ]
}
diff --git a/testing/buildbot/chromium.perf.fyi.json b/testing/buildbot/chromium.perf.fyi.json
index 80a911f..77162dd 100644
--- a/testing/buildbot/chromium.perf.fyi.json
+++ b/testing/buildbot/chromium.perf.fyi.json
@@ -54,14 +54,99 @@
},
{
"args": [],
+ "isolate_name": "gpu_perftests",
+ "name": "gpu_perftests",
+ "swarming": {
+ "can_use_on_swarming_builders": true,
+ "dimension_sets": [
+ {
+ "gpu": "8086:22b1",
+ "id": "build47b4",
+ "os": "Windows-10-10586",
+ "pool": "Chrome-perf"
+ }
+ ],
+ "expiration": 14400
+ }
+ },
+ {
+ "args": [],
+ "isolate_name": "load_library_perf_tests",
+ "name": "load_library_perf_tests",
+ "swarming": {
+ "can_use_on_swarming_builders": true,
+ "dimension_sets": [
+ {
+ "gpu": "8086:22b1",
+ "id": "build47-b4",
+ "os": "Windows-10-10586",
+ "pool": "Chrome-perf"
+ }
+ ],
+ "expiration": 14400
+ }
+ },
+ {
+ "args": [],
+ "isolate_name": "performance_browser_tests",
+ "name": "performance_browser_tests",
+ "swarming": {
+ "can_use_on_swarming_builders": true,
+ "dimension_sets": [
+ {
+ "gpu": "8086:22b1",
+ "id": "build48-b4",
+ "os": "Windows-10-10586",
+ "pool": "Chrome-perf"
+ }
+ ],
+ "expiration": 14400
+ }
+ },
+ {
+ "args": [],
"isolate_name": "cc_perftests",
"name": "cc_perftests",
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
- "gpu": "1002:9874",
- "id": "build171-b4",
+ "gpu": "8086:22b1",
+ "id": "build48-b4",
+ "os": "Windows-10-10586",
+ "pool": "Chrome-perf"
+ }
+ ],
+ "expiration": 14400
+ }
+ },
+ {
+ "args": [],
+ "isolate_name": "angle_perftests",
+ "name": "angle_perftests",
+ "swarming": {
+ "can_use_on_swarming_builders": true,
+ "dimension_sets": [
+ {
+ "gpu": "8086:22b1",
+ "id": "build48-b4",
+ "os": "Windows-10-10586",
+ "pool": "Chrome-perf"
+ }
+ ],
+ "expiration": 14400
+ }
+ },
+ {
+ "args": [],
+ "isolate_name": "tracing_perftests",
+ "name": "tracing_perftests",
+ "swarming": {
+ "can_use_on_swarming_builders": true,
+ "dimension_sets": [
+ {
+ "gpu": "8086:22b1",
+ "id": "build48-b4",
"os": "Windows-10-10586",
"pool": "Chrome-perf"
}
diff --git a/testing/buildbot/gn_isolate_map.pyl b/testing/buildbot/gn_isolate_map.pyl
index d99345d..c1e9add 100644
--- a/testing/buildbot/gn_isolate_map.pyl
+++ b/testing/buildbot/gn_isolate_map.pyl
@@ -804,6 +804,56 @@
"cc_perftests",
],
},
+ "load_library_perf_tests": {
+ "label": "//chrome/test:load_library_perf_tests",
+ "type": "script",
+ "script": "//testing/scripts/run_gtest_perf_test.py",
+ "args": [
+ "load_library_perf_tests",
+ "--test-launcher-print-test-stdio=always"
+ ],
+ },
+ "tracing_perftests": {
+ "label": "//components/tracing:tracing_perftests",
+ "type": "script",
+ "script": "//testing/scripts/run_gtest_perf_test.py",
+ "args": [
+ "tracing_perftests",
+ "--test-launcher-print-test-stdio=always"
+ ],
+ },
+ "gpu_perftests": {
+ "label": "//gpu:gpu_perftests",
+ "type": "script",
+ "script": "//testing/scripts/run_gtest_perf_test.py",
+ "args": [
+ "gpu_perftests",
+ "--adb-path",
+ "src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb"
+ ],
+ },
+ "angle_perftests": {
+ "label": "//chrom/test:angle_perftests",
+ "type": "script",
+ "script": "//testing/scripts/run_gtest_perf_test.py",
+ "args": [
+ "angle_perftests",
+ "--test-launcher-print-test-stdio=always",
+ "--test-launcher-jobs=1"
+ ],
+ },
+ "performance_browser_tests": {
+ "label": "//chrom/test:performance_browser_tests",
+ "type": "script",
+ "script": "//testing/scripts/run_gtest_perf_test.py",
+ "args": [
+ "performance_browser_tests",
+ "--test-launcher-print-test-stdio=always",
+ "--gtest_filter=TabCapturePerformanceTest.*:CastV2PerformanceTest.*",
+ "--test-launcher-jobs=1",
+ "--enable-gpu"
+ ],
+ },
"mus_ime_unittests": {
"label": "//services/ui/ime:mus_ime_unittests",
"type": "windowed_test_launcher",