Refactored IPH demo mode to be run cross-platform.
Current code only enables IPH demo mode on Android, restricting testing
on other platforms.
This feature needs to be cross-platform to be used with deferred onboarding
(new tab) on Desktop Chrome.
Things that were changed in this CL:
* Makes the whole feature engagement tracker available to all platforms
* Updated documentation to reflect this change
* Enables demo mode in chrome://flags to be cross-platform
* Change in feature_engagement_tracker_impl.cc was necessary to make it
work for Windows' pathnames.
* Moved some code from feature_list.cc to feature_list.h to resolve
the static initializers bug
* Fixed an issue with the SystemTimeProviderTest
* Changed flag names from kIPH... to kInProductHelp...
Original CL: https://chromium-review.googlesource.com/c/518933/
Revert CL: https://chromium-review.googlesource.com/c/524289/
This CL re-lands the original CL.
NOTE: There were no changes made during this revert, since the bug
was fixed in https://chromium-review.googlesource.com/c/525053/.
Bug: 729138, 729791
Change-Id: I395287ff1b433708e97762a536910a4750827b54
Reviewed-on: https://chromium-review.googlesource.com/526360
Commit-Queue: Catherine Chung <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#478499}diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index ee3fae0..fcaac59 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -413,6 +413,8 @@
"favicon/favicon_utils.h",
"favicon/large_icon_service_factory.cc",
"favicon/large_icon_service_factory.h",
+ "feature_engagement_tracker/feature_engagement_tracker_factory.cc",
+ "feature_engagement_tracker/feature_engagement_tracker_factory.h",
"file_select_helper.cc",
"file_select_helper.h",
"file_select_helper_mac.mm",
@@ -1529,6 +1531,7 @@
"//components/favicon/content",
"//components/favicon/core",
"//components/favicon_base",
+ "//components/feature_engagement_tracker",
"//components/flags_ui",
"//components/gcm_driver",
"//components/google/core/browser",
@@ -3147,8 +3150,6 @@
"download/download_request_infobar_delegate_android.h",
"engagement/site_engagement_service_android.cc",
"engagement/site_engagement_service_android.h",
- "feature_engagement_tracker/feature_engagement_tracker_factory.cc",
- "feature_engagement_tracker/feature_engagement_tracker_factory.h",
"geolocation/geolocation_infobar_delegate_android.cc",
"geolocation/geolocation_infobar_delegate_android.h",
"history/android/android_history_provider_service.cc",
@@ -3272,7 +3273,6 @@
"//chrome/browser/android/webapk:proto",
"//components/cdm/browser",
"//components/data_usage/android",
- "//components/feature_engagement_tracker",
"//components/payments/content/android",
"//components/precache/content",
"//components/resources:components_resources",
