Change Page Info string for local files
This cl changes the button text displayed in the omnibox
for local files. "File" text is added to the chip and
clicking on the button will display the text "You're
viewing a file".
A follow-up cl will elide file:// from the omnibox display.
Screenshot:
https://drive.google.com/file/d/1eiFK6FfonGqihqYCheFZmDtI-Qv8UPPZ/view?usp=sharing
Bug: 818528
Change-Id: Ideb4c8aaefbe50afd2cdfd3236d1c72809d04fe3
Reviewed-on: https://chromium-review.googlesource.com/1187132
Commit-Queue: Livvie Lin <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#587277}diff --git a/components/omnibox_strings.grdp b/components/omnibox_strings.grdp
index 4779242..8a052c8 100644
--- a/components/omnibox_strings.grdp
+++ b/components/omnibox_strings.grdp
@@ -55,6 +55,9 @@
<message name="IDS_PHYSICAL_WEB_OVERFLOW_EMPTY_TITLE" desc="A label in the omnibox dropdown indicating the number of additional nearby devices broadcasting URLs. This version is used when the title of the top result is empty.">
{URL_count, plural, =1 {1 web page nearby} other {# web pages nearby}}
</message>
+ <message name="IDS_OMNIBOX_FILE" desc="Text shown in the omnibox to indicate a user is viewing a file.">
+ File
+ </message>
<!-- Accessibility labels for autocomplete match types.
These are parameterized on the text being completed into the omnibox.
diff --git a/components/omnibox_strings_grdp/IDS_OMNIBOX_FILE.png.sha1 b/components/omnibox_strings_grdp/IDS_OMNIBOX_FILE.png.sha1
new file mode 100644
index 0000000..23bfafb9
--- /dev/null
+++ b/components/omnibox_strings_grdp/IDS_OMNIBOX_FILE.png.sha1
@@ -0,0 +1 @@
+4254556e6999442992434411d973fe6b0e575bc9
\ No newline at end of file
diff --git a/components/page_info_strings.grdp b/components/page_info_strings.grdp
index 1233f580..6488ce5 100644
--- a/components/page_info_strings.grdp
+++ b/components/page_info_strings.grdp
@@ -29,6 +29,11 @@
You're viewing the source of a web page
</message>
+ <!-- Viewing file strings -->
+ <message name="IDS_PAGE_INFO_FILE_PAGE" desc="Message to display in the page info bubble when the page the user has navigated to is a file:// page">
+ You're viewing a local or shared file
+ </message>
+
<!-- Detail strings -->
<message name="IDS_PAGE_INFO_SECURE_DETAILS" desc="A short paragraph explaining a secure site to the user.">
Your information (for example, passwords or credit card numbers) is private when it is sent to this site.
diff --git a/components/page_info_strings_grdp/IDS_PAGE_INFO_FILE_PAGE.png.sha1 b/components/page_info_strings_grdp/IDS_PAGE_INFO_FILE_PAGE.png.sha1
new file mode 100644
index 0000000..23bfafb9
--- /dev/null
+++ b/components/page_info_strings_grdp/IDS_PAGE_INFO_FILE_PAGE.png.sha1
@@ -0,0 +1 @@
+4254556e6999442992434411d973fe6b0e575bc9
\ No newline at end of file
