Google Git
Sign in
chromium / chromium / src / d8ca3222afad98ab3b18f354fa89c1d16c4852dd
commitd8ca3222afad98ab3b18f354fa89c1d16c4852dd[log] [tgz]
authorBen Pastene <[email protected]>Thu Jan 05 18:28:03 2023
committerChromium LUCI CQ <[email protected]>Thu Jan 05 18:28:03 2023
tree619f39a1a397e55fd63de717e31b3b9e8795681c
parent7ed9e0e11a8d239af6828751da91b574f2e74ada [diff]
Invoke 'cros chrome-sdk' in gclient hooks via vpython3

This gets invoked outside of a cros chroot. And since it doesn't
specify which python to use today, it uses the system one. (ie: /usr/bin/python3)

It appears that recently the system python3 on some workstations
got upgraded. And the upgrade led to some mysterious errors in
simple chrome (see b/172226630#comment41 for details).

By invoking `cros chrome-sdk` via vpython, we use a version of python
that we more closely control, and so won't be affected by rollouts
we're not involved with. Additionally, using vpython's venv helps avoid
the original error that the rollout caused by using our own crcmod lib.

Bug: b/172226630
Change-Id: I0721843ab1294ad30750ae1122cb54b7a699a5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4123032
Reviewed-by: Sven Zheng <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1089345}
2 files changed
tree: 619f39a1a397e55fd63de717e31b3b9e8795681c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.