Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2030013003
Cr-Commit-Position: refs/heads/master@{#397580}
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 76212643..cf0d1b9 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -747,7 +747,7 @@
base::ListValue* list_value = new base::ListValue();
for (std::set<std::string>::const_iterator iter = value.begin();
iter != value.end(); ++iter)
- list_value->Append(new base::StringValue(*iter));
+ list_value->AppendString(*iter);
SetPref(extension_id, pref_path, list_value, msg);
}
@@ -1644,8 +1644,7 @@
host_permissions.insert("http://*.google.com.hk/*");
base::ListValue* api_permissions = new base::ListValue();
- api_permissions->Append(
- new base::StringValue("tabs"));
+ api_permissions->AppendString("tabs");
SetPref(extension_id, "granted_permissions.api",
api_permissions, "granted_permissions.api");
SetPrefStringSet(
