Update documentation to allow owners of public APIs that are used throughout the codebase to Owners-Override changes across the source tree.
Unlike LSC which is meant for work that spans dozens of CLs, this new change is meant for one-off CLs. It's similar to google3's global approvals mechanism.
base, build, blink, content and url were chosen as an initial set because they are used in many top level directories and are frequently changing.
Also add "set noparent" to top level directories to avoid inadvertent +1s from src/OWNERS bypass owners reviews sometimes.
Change-Id: Iaa397a5e09174139af21fee34dca390de132e216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688805
Auto-Submit: John Abd-El-Malek <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#857391}
diff --git a/docs/code_reviews.md b/docs/code_reviews.md
index 3f18122..de612276 100644
--- a/docs/code_reviews.md
+++ b/docs/code_reviews.md
@@ -15,7 +15,7 @@
for each directory you are touching. If you have doubts, look at the git blame
for the file and the `OWNERS` files (see below).
-To indicate a positive review, the reviewer provides a "Code-Review +1" in
+To indicate a positive review, the reviewer provides a `Code-Review +1` in
Gerrit, also known as an LGTM ("Looks Good To Me"). A score of "-1" indicates
the change should not be submitted as-is.
@@ -168,15 +168,23 @@
### Owners-Override
-Setting the `Owners-Override` label will bypass OWNERS enforcement. Active
-sheriffs and Large Scale Changes (see below) reviewers have this power.
+Setting the `Owners-Override +1` label will bypass OWNERS enforcement. Active
+sheriffs, Large Scale Changes and Global Approvers (see below) reviewers have
+this capability.
## Mechanical changes
+### Large Scale Changes
You can use the [Large Scale Changes](process/lsc/large_scale_changes.md)
process to get approval to bypass OWNERS enforcement for large changes like
refactoring, architectural changes, or other repetitive code changes across the
-whole codebase.
+whole codebase. This is used for work that span many dozen CLs.
+
+### Global Approvals
+For one-off CLs API owners of base, blink, build, content and url can
+Owners-Override +1 a change to their APIs to avoid waiting for rubberstamp +1s
+from affected directories' owners. This should only be used for mechanical
+updates to the affected directories.
## Documentation updates
