Add presubmit check for Google support URL format.
See bug for details. tl;dr: we should not use direct links like
support.google.com/chrome/answer/123456
For now this is an ignoreable upload-only prompt.
BUG=679462
Review-Url: https://codereview.chromium.org/2627023003
Cr-Commit-Position: refs/heads/master@{#443255}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 36afa36..5fca8c1 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -975,6 +975,21 @@
'Version control conflict markers found, please resolve.', errors))
return results
+def _CheckGoogleSupportAnswerUrl(input_api, output_api):
+ pattern = input_api.re.compile('support\.google\.com\/chrome.*/answer')
+ errors = []
+ for f in input_api.AffectedFiles():
+ for line_num, line in f.ChangedContents():
+ if pattern.search(line):
+ errors.append(' %s:%d %s' % (f.LocalPath(), line_num, line))
+
+ results = []
+ if errors:
+ results.append(output_api.PresubmitPromptWarning(
+ 'Found Google support URL addressed by answer number. Please replace with '
+ 'a p= identifier instead. See crbug.com/679462\n', errors))
+ return results
+
def _CheckHardcodedGoogleHostsInLowerLayers(input_api, output_api):
def FilterFile(affected_file):
@@ -2298,6 +2313,7 @@
results.extend(_CheckUmaHistogramChanges(input_api, output_api))
results.extend(_AndroidSpecificOnUploadChecks(input_api, output_api))
results.extend(_CheckSyslogUseWarning(input_api, output_api))
+ results.extend(_CheckGoogleSupportAnswerUrl(input_api, output_api))
return results
