commit | ed00ca7e74361d3fbdaaa2a4903e20642de33e5e | [log] [tgz] |
---|---|---|
author | Matt Reynolds <[email protected]> | Thu Aug 18 20:56:20 2022 |
committer | Chromium LUCI CQ <[email protected]> | Thu Aug 18 20:56:20 2022 |
tree | c6b188febb4ffa2cddb41a290ba7ce1b5d829890 | |
parent | 61aba5cfcb1a46369c1a0bfdc72bbf337f941bf4 [diff] |
usb: Move WebUsbServiceImpl to //content This CL moves the implementation of the blink::mojom::WebUsbService mojo interface from the embedder layer to the content layer. Ownership of the UsbDelegate is moved from WebUsbServiceImpl to the ContentBrowserClient which now has a GetUsbDelegate method. Previously, the lifetime of WebUsbServiceImpl was managed by FrameUsbServices. Now it is a self-owned DocumentUserData with the same lifetime. Previously, UsbTabHelper managed the connected USB device state. Now WebContentsImpl manages this state and clients observe WebContents directly. Browser tests (//chrome/browser/usb/usb_browsertest.cc) and unit tests (//chrome/browser/usb/web_usb_service_impl_unittest.cc) are moved to //content but the embedder-specific versions of the tests are retained as chrome_usb_browsertest.cc and chrome_usb_delegate_unittest.cc. Bug: 991759, 1220314 Change-Id: I2ed528acc6dbc5667ae22b9219a1320226792a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3671829 Commit-Queue: Matt Reynolds <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Reviewed-by: Dana Fried <[email protected]> Reviewed-by: Francois Pierre Doray <[email protected]> Reviewed-by: Brandon Jones <[email protected]> Cr-Commit-Position: refs/heads/main@{#1036771}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.