commit | 219220040daa4c655c33d3086634a2bd6b7198a5 | [log] [tgz] |
---|---|---|
author | Ryan Landay <[email protected]> | Mon May 14 23:46:50 2018 |
committer | Commit Bot <[email protected]> | Mon May 14 23:46:50 2018 |
tree | c4de1311bb415ca00d14852f2cabc8a3182064d3 | |
parent | 6c883a588e08eedb1cef6099d28bd13f5dc09677 [diff] |
Refactor IncognitoToggleButtonTablet IncognitoToggleButtonTablet implements a button we have in the Android tablet toolbar that lets a user switch between normal and incognito modes. The button only shows if there's at least one incognito tab currently open. I want to add a similar button to the toolbar on Android phones as part of the horizontal tab switcher experiment. The button won't need as much functionality on phones (we want to always show it, not only when an incognito tab is open, and the click handler will get passed from StackLayout through ToolbarPhone to the incognito button, so we can have StackLayout disable it during animations). This CL refactors the basic functionality into a new base class IncognitoToggleButton, which we can use on phones. IncognitoToggleButtonTablet will now extend this class so as to maintain the current functionality. Bug: 828224 Change-Id: I453be95f42d7baef0d5e237c61bc14f7af7faba2 Reviewed-on: https://chromium-review.googlesource.com/1058433 Reviewed-by: Theresa <[email protected]> Commit-Queue: Ryan Landay <[email protected]> Cr-Commit-Position: refs/heads/master@{#558533}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .