Update the lower bound for UMA_HISTOGRAM_CUSTOM_COUNTS
The lower bound for UMA_HISTOGRAM_CUSTOM_COUNTS should be one or more.
https://cs.chromium.org/chromium/src/base/metrics/histogram.cc?rcl=0&l=376
Values of 0 or less is adjusted to 1 and a warning is written to the log.
BUG=
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2269553002
Cr-Commit-Position: refs/heads/master@{#413678}
diff --git a/components/metrics/system_memory_stats_recorder_win.cc b/components/metrics/system_memory_stats_recorder_win.cc
index 539d80ff..7d01182 100644
--- a/components/metrics/system_memory_stats_recorder_win.cc
+++ b/components/metrics/system_memory_stats_recorder_win.cc
@@ -23,7 +23,7 @@
switch (type) {
case RECORD_MEMORY_STATS_TAB_DISCARDED: {
UMA_HISTOGRAM_CUSTOM_COUNTS("Memory.Stats.Win.MemoryLoad",
- mem_status.dwMemoryLoad, 0, 100, 101);
+ mem_status.dwMemoryLoad, 1, 100, 101);
UMA_HISTOGRAM_LARGE_MEMORY_MB("Memory.Stats.Win.TotalPhys2",
mem_status.ullTotalPhys / kMBytes);
UMA_HISTOGRAM_LARGE_MEMORY_MB("Memory.Stats.Win.AvailPhys2",
diff --git a/components/user_manager/user_manager_base.cc b/components/user_manager/user_manager_base.cc
index 58d405f..444bb348 100644
--- a/components/user_manager/user_manager_base.cc
+++ b/components/user_manager/user_manager_base.cc
@@ -1042,7 +1042,7 @@
account_id != AccountId::FromUserEmail(last_email) &&
time_to_login.InSeconds() <= kLogoutToLoginDelayMaxSec) {
UMA_HISTOGRAM_CUSTOM_COUNTS("UserManager.LogoutToLoginDelay",
- time_to_login.InSeconds(), 0,
+ time_to_login.InSeconds(), 1,
kLogoutToLoginDelayMaxSec, 50);
}
}
diff --git a/components/variations/service/variations_service.cc b/components/variations/service/variations_service.cc
index b5836686..cc3dde3 100644
--- a/components/variations/service/variations_service.cc
+++ b/components/variations/service/variations_service.cc
@@ -560,7 +560,7 @@
if (!last_request_started_time_.is_null())
time_since_last_fetch = now - last_request_started_time_;
UMA_HISTOGRAM_CUSTOM_COUNTS("Variations.TimeSinceLastFetchAttempt",
- time_since_last_fetch.InMinutes(), 0,
+ time_since_last_fetch.InMinutes(), 1,
base::TimeDelta::FromDays(7).InMinutes(), 50);
UMA_HISTOGRAM_COUNTS_100("Variations.RequestCount", request_count_);
++request_count_;
diff --git a/components/variations/variations_http_header_provider.cc b/components/variations/variations_http_header_provider.cc
index 6337dc04..5af7151 100644
--- a/components/variations/variations_http_header_provider.cc
+++ b/components/variations/variations_http_header_provider.cc
@@ -186,7 +186,7 @@
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Variations.HeaderConstructionTime",
- (base::TimeTicks::Now() - before_time).InMicroseconds(), 0,
+ (base::TimeTicks::Now() - before_time).InMicroseconds(), 1,
base::TimeDelta::FromSeconds(1).InMicroseconds(), 50);
variation_ids_cache_initialized_ = true;
