Revert of Standardize usage of virtual/override/final in ipc/ (patchset #1 id:1 of https://codereview.chromium.org/645623006/)
Reason for revert:
Addressing reviewer comments in a followup patch.
Original issue's description:
> Standardize usage of virtual/override/final in ipc/
>
> This patch was automatically generated by applying clang fixit hints
> generated by the plugin to the source tree.
>
> BUG=417463
> [email protected]
>
> Committed: https://crrev.com/39be52ebbd6681c7d79ad63e2a0ab028075af0c2
> Cr-Commit-Position: refs/heads/master@{#300481}
[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=417463
Review URL: https://codereview.chromium.org/669953003
Cr-Commit-Position: refs/heads/master@{#300521}
diff --git a/ipc/ipc_send_fds_test.cc b/ipc/ipc_send_fds_test.cc
index 332a6310..3961fa1 100644
--- a/ipc/ipc_send_fds_test.cc
+++ b/ipc/ipc_send_fds_test.cc
@@ -33,7 +33,7 @@
class MyChannelDescriptorListenerBase : public IPC::Listener {
public:
- bool OnMessageReceived(const IPC::Message& message) override {
+ virtual bool OnMessageReceived(const IPC::Message& message) override {
PickleIterator iter(message);
base::FileDescriptor descriptor;
@@ -60,10 +60,12 @@
return num_fds_received_ == kNumFDsToSend;
}
- void OnChannelError() override { base::MessageLoop::current()->Quit(); }
+ virtual void OnChannelError() override {
+ base::MessageLoop::current()->Quit();
+ }
protected:
- void HandleFD(int fd) override {
+ virtual void HandleFD(int fd) override {
// Check that we can read from the FD.
char buf;
ssize_t amt_read = read(fd, &buf, 1);
@@ -200,7 +202,9 @@
}
protected:
- void HandleFD(int fd) override { cb_.Run(fd); }
+ virtual void HandleFD(int fd) override {
+ cb_.Run(fd);
+ }
private:
base::Callback<void(int)> cb_;
};
