| commit | f355f1ded742b239d41a858bd81696db672193c9 | [log] [tgz] |
|---|---|---|
| author | Devlin Cronin <[email protected]> | Mon May 14 15:27:24 2018 |
| committer | Commit Bot <[email protected]> | Mon May 14 15:27:24 2018 |
| tree | 62644deccb41363ad9b04ee2dffb3b4378ed3128 | |
| parent | 309422c15124cc31869b982e88b0af5b29b2a24b [diff] [blame] |
[Reland][Extensions Click-to-Script] Change default to allowing host permissions Change the default behavior of the kRuntimeHostPermissions feature to allow extensions to have origin access, rather than defaulting to withholding permission. In the first stage of click-to-script, we don't want to change any defaults. Reland notes: the original patch caused ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy to fail because it relies on the permissions being withheld, but the patch didn't update it with a call to withhold permissions. [email protected] Bug: 841099 Change-Id: If913aee7e14b7ea89c751528b8402d07a514b047 Reviewed-on: https://chromium-review.googlesource.com/1057433 Reviewed-by: Devlin <[email protected]> Commit-Queue: Devlin <[email protected]> Cr-Commit-Position: refs/heads/master@{#558317}
diff --git a/chrome/browser/extensions/extension_action_runner_unittest.cc b/chrome/browser/extensions/extension_action_runner_unittest.cc index 0edd6e0..18435a26 100644 --- a/chrome/browser/extensions/extension_action_runner_unittest.cc +++ b/chrome/browser/extensions/extension_action_runner_unittest.cc
@@ -116,6 +116,9 @@ ExtensionRegistry::Get(profile())->AddEnabled(extension_); PermissionsUpdater(profile()).InitializePermissions(extension_.get()); + + ScriptingPermissionsModifier(profile(), extension_.get()) + .SetAllowedOnAllUrls(false); return extension_.get(); }