Google Git
Sign in
chromium / chromium / src / f42f9f333a4e0f8c69f9d8c1e2bd52f08897b2bc
commitf42f9f333a4e0f8c69f9d8c1e2bd52f08897b2bc[log] [tgz]
authorMichael Thiessen <[email protected]>Thu Feb 03 22:23:06 2022
committerChromium LUCI CQ <[email protected]>Thu Feb 03 22:23:06 2022
treeb554fb63a5144dfb5e06f3e99dfd8dc0fadcb998
parenta2fc9627253b738a1f6246e75ed7cef4e7ad37c3 [diff]
Check Broadcast permissions in SmsUserConsentReceiver

In order to avoid any app sending us an
SmsRetriever.SMS_RETRIEVED_ACTION broadcast, we need to check that the
sender has the SmsRetriever.SEND_PERMISSION permission. This permission
ensures that only Google Play Services can send the broadcast.

The unit tests were also failing when run locally due to
LifetimeAssertions in Java because the WindowAndroid wasn't being
destroyed correctly, so I fixed it in all of the unit tests that create
WindowAndroids from c++.

Bug: 1142269
Change-Id: I3278919c566e1fc344ed0f4adce74fbf93a85c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434025
Reviewed-by: Yi Gu <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Auto-Submit: Michael Thiessen <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Commit-Queue: Bo Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#966953}
10 files changed
tree: b554fb63a5144dfb5e06f3e99dfd8dc0fadcb998
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.