| commit | f4e514de66bc88423b42ccbde1b7f25a5d46b2d9 | [log] [tgz] |
|---|---|---|
| author | treib <[email protected]> | Fri Mar 06 15:25:31 2015 |
| committer | Commit bot <[email protected]> | Fri Mar 06 15:26:25 2015 |
| tree | c5ad223374c983c9f3ddb8909166f256e1fdb495 | |
| parent | 23833a3b27be4c218135a111b8427047509eca5f [diff] |
Revert of Add support for escaped target names in isolate driver. (patchset #6 id:100001 of https://codereview.chromium.org/970203003/) Reason for revert: Likely broke Mac 10.9 dbg: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/3709 Original issue's description: > Add support for escaped target names in isolate driver. > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. > > BUG=462248 > > Committed: https://crrev.com/8fb598c1b7b9a6b944e2ec15e989e80cdf7522c0 > Cr-Commit-Position: refs/heads/master@{#319356} [email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Review URL: https://codereview.chromium.org/985753002 Cr-Commit-Position: refs/heads/master@{#319448}