Clean up Automation and Chrome Frame IPC code.-only use routed messages when needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile.
Review URL: http://codereview.chromium.org/5998006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome_frame/chrome_frame_delegate.cc b/chrome_frame/chrome_frame_delegate.cc
index 6d3186a..cd54c5f 100644
--- a/chrome_frame/chrome_frame_delegate.cc
+++ b/chrome_frame/chrome_frame_delegate.cc
@@ -4,8 +4,7 @@
#include "chrome_frame/chrome_frame_delegate.h"
-bool ChromeFrameDelegateImpl::IsTabMessage(const IPC::Message& message,
- int* tab_handle) {
+bool ChromeFrameDelegateImpl::IsTabMessage(const IPC::Message& message) {
bool is_tab_message = true;
IPC_BEGIN_MESSAGE_MAP(ChromeFrameDelegateImpl, message)
IPC_MESSAGE_HANDLER_GENERIC(AutomationMsg_NavigationStateChanged, )
@@ -31,12 +30,6 @@
IPC_MESSAGE_UNHANDLED(is_tab_message = false);
IPC_END_MESSAGE_MAP()
- if (is_tab_message) {
- // Read tab handle from the message.
- void* iter = NULL;
- is_tab_message = message.ReadInt(&iter, tab_handle);
- }
-
return is_tab_message;
}
