Split ExtensionTestObserver and move to //extensions.
This CL splits ExtensionsTestObserver into two parts. The base class
exists in //extensions and has no dependencies on //chrome. The code that
needs to depend on //chrome is now in a subclass. This will allow us to
use the observer in tests that are out of //chrome.
This class is split but more code needs to be moved from
ExtensionChromeTestObserver to ExtensionTestObserver. There are certain
parts that we've left in the Chrome version simply because they are too
much work to move in this CL itself.
This CL is one of many that will be required to move tests for apps and
extensions API that are in //extensions to be tested without Chrome.
Unfortunately as a side effect of this CL, a lot of tests that did not
follow IWYU, started breaking on compile - since they were depending on
the include in extension_test_observer.h. I've added sky@ as a top level
reviewer for owners approval for the changes made to fix all of these
tests.
Reviews,
rdevlin.cronin@ - everything
sky@ - includes added to fix broken tests.
michaelpg@ - FYI
[email protected], [email protected]
BUG=505926
Review-Url: https://chromiumcodereview.appspot.com/2393343002
Cr-Commit-Position: refs/heads/master@{#426304}
diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
index 2ea243a7..227951c0 100644
--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/navigation_controller.h"
+#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
