| commit | faddda8c2b9ee9349ba6e27ba4253d9e81eb9949 | [log] [tgz] |
|---|---|---|
| author | Eric Seckler <[email protected]> | Thu Aug 11 18:05:49 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Aug 11 18:05:49 2022 |
| tree | 60ba371535dbfe733a6fd3cc0b43217edacaba24 | |
| parent | f5a1741ceb15c41217d18e46e62d2c1281719fd5 [diff] [blame] |
Revert "[blink/renderer] Fix image download logic in renderer to filter instead" This reverts commit 45351855e193fbb7caee43ab2da8178a490a41d6. Reason for revert: likely causes crashes on perf bots (crbug/1352191) Original change's description: > [blink/renderer] Fix image download logic in renderer to filter instead > of resize > > This CL introduces logic in blink/renderer to filter out images instead > of resizing the smallest image in case no images are found about a > specific max size. This also moves the filter logic into the callsites > instead of renderer, so that this is handler on a use-case basis. > > Doc: go/blink_image > > Bug: 1176678, 1348264 > Change-Id: If1cae73c5f5bfb2146156a6872dac5d4b41aa577 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781583 > Commit-Queue: Dibyajyoti Pal <[email protected]> > Reviewed-by: Daniel Cheng <[email protected]> > Reviewed-by: Dominick Ng <[email protected]> > Reviewed-by: Avi Drissman <[email protected]> > Reviewed-by: Nate Fischer <[email protected]> > Reviewed-by: Scott Violet <[email protected]> > Reviewed-by: Yaron Friedman <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1033659} Bug: 1176678, 1348264 Bug: 1352191 Change-Id: I50dc02aa3411f9e921dda59bad5f7da3daa55406 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825876 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Dibyajyoti Pal <[email protected]> Auto-Submit: Eric Seckler <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Owners-Override: Avi Drissman <[email protected]> Commit-Queue: Avi Drissman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1034081}
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h index 2ee2f2a..c12e9514 100644 --- a/content/public/browser/web_contents.h +++ b/content/public/browser/web_contents.h
@@ -1096,8 +1096,8 @@ // be called with the bitmaps received from the renderer. // If |is_favicon| is true, the cookies are not sent and not accepted during // download. - // Bitmaps with pixel sizes larger than |max_bitmap_size| are filtered out - // from the bitmap results. + // If there are no bitmap results <= |max_bitmap_size|, the smallest bitmap + // is resized to |max_bitmap_size| and is the only result. // A |max_bitmap_size| of 0 means unlimited. // For vector images, |preferred_size| will serve as a viewport into which // the image will be rendered. This would usually be the dimensions of the