[Mac] First part of Omnibox decoration refactor. Enable ev bubble.
The views implementation of the little things floating around in the
Omnibox uses nested views which are manually laid out by the
location-bar code. The Mac code has a variety of different
implementations for these items, with the layout distributed across
many files. This change creates something called a "decoration" which
is similar (different name because Mac has a strong sense of what a
"view" is). Decorations are kind of like a C++ NSCell, which the
AutocompleteTextFieldCell handles generically and the
LocationBarViewMac::Layout() code will lay out. The overall goal is
to loosely parallel the views code for decorations and Layout(), so
that future coders can do the right thing more easily.
This CL converts the left-hand items, namely:
- the location icon
- the search-keyword bubble
- the ev security bubble (new)
The Layout() function does not yet deal with trimming things to fit
when space is tight.
location_bar_view_mac_unittest.mm was always a sham, so I'm going to
stop pretending.
BUG=41998
TEST=EV bubble for secure sites.
TEST=location icon can be clicked (page info panel) and dragged.
TEST=EV bubble can be clicked (page info panel) and dragged.
TEST=keyword-search mode shows appropriately.
Review URL: http://codereview.chromium.org/2805070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52223 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 5da0819..6dc36825 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -843,8 +843,18 @@
'browser/cocoa/location_bar/autocomplete_text_field_cell.mm',
'browser/cocoa/location_bar/autocomplete_text_field_editor.h',
'browser/cocoa/location_bar/autocomplete_text_field_editor.mm',
+ 'browser/cocoa/location_bar/bubble_decoration.h',
+ 'browser/cocoa/location_bar/bubble_decoration.mm',
+ 'browser/cocoa/location_bar/ev_bubble_decoration.h',
+ 'browser/cocoa/location_bar/ev_bubble_decoration.mm',
+ 'browser/cocoa/location_bar/location_bar_decoration.h',
+ 'browser/cocoa/location_bar/location_bar_decoration.mm',
'browser/cocoa/location_bar/location_bar_view_mac.h',
'browser/cocoa/location_bar/location_bar_view_mac.mm',
+ 'browser/cocoa/location_bar/location_icon_decoration.h',
+ 'browser/cocoa/location_bar/location_icon_decoration.mm',
+ 'browser/cocoa/location_bar/selected_keyword_decoration.h',
+ 'browser/cocoa/location_bar/selected_keyword_decoration.mm',
'browser/cocoa/menu_button.h',
'browser/cocoa/menu_button.mm',
'browser/cocoa/menu_controller.h',
