Remove MessageLoop::current()->RunUntilIdle() in chrome.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in chrome.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2053103002
Cr-Commit-Position: refs/heads/master@{#399221}
diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
index 5e808289..12145f3 100644
--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
@@ -4,6 +4,7 @@
#include <stddef.h>
+#include "base/run_loop.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/extension_browsertest.h"
@@ -86,7 +87,7 @@
GetBackgroundHostForExtension(extension_id));
// Wait for extension crash balloon to appear.
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
}
void CheckExtensionConsistency(const std::string& extension_id) {
@@ -485,7 +486,7 @@
ASSERT_EQ(1U, CountBalloons());
UninstallExtension(first_extension_id_);
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
SCOPED_TRACE("after uninstalling");
ASSERT_EQ(count_before + 1, GetEnabledExtensionCount());
