| commit | 0be4f4c13eb633b5771857e26d0bf5c6e8832093 | [log] [tgz] |
|---|---|---|
| author | Fergus Dall <[email protected]> | Tue May 21 00:01:29 2019 |
| committer | Fergus Dall <[email protected]> | Tue May 21 00:01:29 2019 |
| tree | 5c7cf344103e27ec6c978385850dcc7cf39e6756 | |
| parent | 6c68f6dcd8f859cedb3960e8cf2d2419d5f04cfe [diff] [blame] |
Reland "[DevTools] Add Notifications & Push Messaging views." This reverts commit 7bfecf258f220ea375ffd376608d6ec71ca9d8ce. Reason for revert: Revert my revert for breaking compilation Original change's description: > Revert "[DevTools] Add Notifications & Push Messaging views." > > This reverts commit 793bf4990a4d8a6bffb0007e5f47f26e15791632. > > Reason for revert: Guessing this is responsible for build failures on WebKit Mac10.13 (retina). See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/14445 for first failure. > > Original change's description: > > [DevTools] Add Notifications & Push Messaging views. > > > > Add basic UI for Notifications & Push Messaging in Application > > > Background Services. > > One UI flag per feature is created. > > > > [email protected] > > > > Screenshot: crbug.com/942174#c28 > > Bug: 942174 > > Change-Id: Ifcdca9d3d78593968b0bd93d02d9dfea9419b822 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611612 > > Commit-Queue: Rayan Kanso <[email protected]> > > Reviewed-by: Alexei Filippov <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#661384} > > [email protected],[email protected],[email protected],[email protected] > > Change-Id: I3ce9bf8bf06d4df371b8c2af2130b9d9dfce79d7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 942174 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621408 > Reviewed-by: Fergus Dall <[email protected]> > Commit-Queue: Fergus Dall <[email protected]> > Cr-Commit-Position: refs/heads/master@{#661533} [email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: I443ed2402908d9b43e68f5467281d7fdf2a89233 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621468 Reviewed-by: Fergus Dall <[email protected]> Commit-Queue: Fergus Dall <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#661544} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 4347761af471013bcb4e68b2cbf3f41cffa55814
diff --git a/front_end/resources/BackgroundServiceView.js b/front_end/resources/BackgroundServiceView.js index a92d8b1..7a65f4b 100644 --- a/front_end/resources/BackgroundServiceView.js +++ b/front_end/resources/BackgroundServiceView.js
@@ -13,6 +13,10 @@ return ls`Background Fetch`; case Protocol.BackgroundService.ServiceName.BackgroundSync: return ls`Background Sync`; + case Protocol.BackgroundService.ServiceName.PushMessaging: + return ls`Push Messaging`; + case Protocol.BackgroundService.ServiceName.Notifications: + return ls`Notifications`; default: return ''; }