Reland "Migrate elements/ to ESM"
This reverts commit 9fd15ddbd03f3f5d6fb97ff65d44c4f7ae9be6cb.
Reason for revert: Fixed browser tests loading behavior
Original change's description:
> Revert "Migrate elements/ to ESM"
>
> This reverts commit 8fefb2ca13559d41eeaa21786ff47445b8a10a55.
>
> Reason for revert: broke browsertest https://ci.chromium.org/p/chromium/builders/try/linux-rel/250464 and blocking roll.
>
> Original change's description:
> > Migrate elements/ to ESM
> >
> > Bug: 1006759
> > Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
> > Reviewed-by: Paul Lewis <[email protected]>
> > Commit-Queue: Paul Lewis <[email protected]>
> > Commit-Queue: Tim van der Lippe <[email protected]>
>
> [email protected],[email protected]
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1006759
> Change-Id: I16a1fd9851391a6080c5376ca35866402b0bc445
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937027
> Reviewed-by: Yang Guo <[email protected]>
> Commit-Queue: Yang Guo <[email protected]>
Change-Id: Iba84f5230f20a86b2de75b84115fcb10aeea534e
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937029
Reviewed-by: Mathias Bynens <[email protected]>
Commit-Queue: Mathias Bynens <[email protected]>
Auto-Submit: Tim van der Lippe <[email protected]>
diff --git a/front_end/elements/MetricsSidebarPane.js b/front_end/elements/MetricsSidebarPane.js
index e6a08e0..0d2d18f 100644
--- a/front_end/elements/MetricsSidebarPane.js
+++ b/front_end/elements/MetricsSidebarPane.js
@@ -29,7 +29,7 @@
/**
* @unrestricted
*/
-Elements.MetricsSidebarPane = class extends Elements.ElementsSidebarPane {
+export default class MetricsSidebarPane extends Elements.ElementsSidebarPane {
constructor() {
super();
this.registerRequiredCSS('elements/metricsSidebarPane.css');
@@ -60,7 +60,7 @@
/**
* @param {?Map.<string, string>} style
- * @this {Elements.MetricsSidebarPane}
+ * @this {MetricsSidebarPane}
*/
function callback(style) {
if (!style || this.node() !== node) {
@@ -70,7 +70,7 @@
}
/**
* @param {?SDK.CSSModel.InlineStyleResult} inlineStyleResult
- * @this {Elements.MetricsSidebarPane}
+ * @this {MetricsSidebarPane}
*/
function inlineStyleCallback(inlineStyleResult) {
if (inlineStyleResult && this.node() === node) {
@@ -156,7 +156,7 @@
* @param {string} name
* @param {string} side
* @param {string} suffix
- * @this {Elements.MetricsSidebarPane}
+ * @this {MetricsSidebarPane}
*/
function createBoxPartElement(style, name, side, suffix) {
const propertyName = (name !== 'position' ? name + '-' : '') + side + suffix;
@@ -343,7 +343,7 @@
/**
* @param {string} originalValue
* @param {string} replacementString
- * @this {Elements.MetricsSidebarPane}
+ * @this {MetricsSidebarPane}
*/
function finishHandler(originalValue, replacementString) {
this._applyUserInput(element, replacementString, originalValue, context, false);
@@ -454,7 +454,7 @@
/**
* @param {boolean} success
- * @this {Elements.MetricsSidebarPane}
+ * @this {MetricsSidebarPane}
*/
function callback(success) {
if (!success) {
@@ -478,4 +478,13 @@
this.editingEnded(element, context);
this._applyUserInput(element, userInput, previousContent, context, true);
}
-};
+}
+
+/* Legacy exported object */
+self.Elements = self.Elements || {};
+
+/* Legacy exported object */
+Elements = Elements || {};
+
+/** @constructor */
+Elements.MetricsSidebarPane = MetricsSidebarPane;
