Replace usages of NetworkPanel.selectAndShowRequest with revealer
This CL uses Common.Revealer.reveal instead of reaching directly
into the Network panel module, thereby loosing coupling and making
a step forward towards removing the dependency on the network panel
from the application and issues panels.
Bug: chromium:1196676
Change-Id: Id4b02b43c7cefd7e4802ead878e50177eab62482
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2953267
Commit-Queue: Sigurd Schneider <[email protected]>
Reviewed-by: Tim van der Lippe <[email protected]>
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts
index 08bedb8..8458ea5 100644
--- a/front_end/panels/network/NetworkLogView.ts
+++ b/front_end/panels/network/NetworkLogView.ts
@@ -45,6 +45,7 @@
import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
import * as Logs from '../../models/logs/logs.js';
import * as TextUtils from '../../models/text_utils/text_utils.js';
+import type * as NetworkForward from '../../panels/network/forward/forward.js';
import * as DataGrid from '../../ui/legacy/components/data_grid/data_grid.js';
import * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
import * as Components from '../../ui/legacy/components/utils/utils.js';
@@ -55,7 +56,6 @@
import {Events, NetworkGroupNode, NetworkRequestNode} from './NetworkDataGridNode.js'; // eslint-disable-line no-unused-vars
import {NetworkFrameGrouper} from './NetworkFrameGrouper.js';
import {NetworkLogViewColumns} from './NetworkLogViewColumns.js';
-import type {FilterOptions} from './NetworkPanel.js'; // eslint-disable-line no-unused-vars
import type {NetworkTimeCalculator} from './NetworkTimeCalculator.js';
import {NetworkTimeBoundary, NetworkTransferDurationCalculator, NetworkTransferTimeCalculator} from './NetworkTimeCalculator.js'; // eslint-disable-line no-unused-vars
import type {NetworkRequestId} from './NetworkRequestId.js';
@@ -1813,7 +1813,8 @@
}
}
- selectRequest(request: SDK.NetworkRequest.NetworkRequest, options?: FilterOptions): void {
+ selectRequest(request: SDK.NetworkRequest.NetworkRequest, options?: NetworkForward.UIRequestLocation.FilterOptions):
+ void {
const defaultOptions = {clearFilter: true};
const {clearFilter} = options || defaultOptions;
if (clearFilter) {
