Always add braces to single-line if-statements
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.
This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.
Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Reviewed-by: Jeff Fisher <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
diff --git a/front_end/audits/AuditsStartView.js b/front_end/audits/AuditsStartView.js
index 736a836..027130c 100644
--- a/front_end/audits/AuditsStartView.js
+++ b/front_end/audits/AuditsStartView.js
@@ -23,8 +23,9 @@
*/
_populateRuntimeSettingAsRadio(settingName, label, parentElement) {
const runtimeSetting = Audits.RuntimeSettings.find(item => item.setting.name === settingName);
- if (!runtimeSetting || !runtimeSetting.options)
+ if (!runtimeSetting || !runtimeSetting.options) {
throw new Error(`${settingName} is not a setting with options`);
+ }
const control = new Audits.RadioSetting(runtimeSetting.options, runtimeSetting.setting, runtimeSetting.description);
parentElement.appendChild(control.element);
@@ -37,8 +38,9 @@
*/
_populateRuntimeSettingAsCheckbox(settingName, parentElement) {
const runtimeSetting = Audits.RuntimeSettings.find(item => item.setting.name === settingName);
- if (!runtimeSetting || !runtimeSetting.title)
+ if (!runtimeSetting || !runtimeSetting.title) {
throw new Error(`${settingName} is not a setting with a title`);
+ }
runtimeSetting.setting.setTitle(runtimeSetting.title);
const control = new UI.ToolbarSettingCheckbox(runtimeSetting.setting, runtimeSetting.description);
@@ -148,18 +150,21 @@
* @param {boolean} isEnabled
*/
setStartButtonEnabled(isEnabled) {
- if (this._helpText)
+ if (this._helpText) {
this._helpText.classList.toggle('hidden', isEnabled);
+ }
- if (this._startButton)
+ if (this._startButton) {
this._startButton.disabled = !isEnabled;
+ }
}
/**
* @param {?string} text
*/
setUnauditableExplanation(text) {
- if (this._helpText)
+ if (this._helpText) {
this._helpText.textContent = text;
+ }
}
};
