commit 1d6e57a0e314d709029cac52b98898b828f45a12
author Tim van der Lippe <tvanderlippe@chromium.org> Mon Sep 30 11:55:34 2019
committer Commit Bot <commit-bot@chromium.org> Mon Sep 30 11:55:34 2019
tree 597a15659e3845a97779af856addeeb3fbb9f68e
parent 9278806591e64473315401707afdba6a774a109d

Always add braces to single-line if-statements

The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9

front_end/settings/FrameworkBlackboxSettingsTab.js

diff --git a/front_end/settings/FrameworkBlackboxSettingsTab.js b/front_end/settings/FrameworkBlackboxSettingsTab.js
index c2a998e..fc3f1c2 100644
--- a/front_end/settings/FrameworkBlackboxSettingsTab.js
+++ b/front_end/settings/FrameworkBlackboxSettingsTab.js
@@ -55,8 +55,9 @@
   _settingUpdated() {
     this._list.clear();
     const patterns = this._setting.getAsArray();
-    for (let i = 0; i < patterns.length; ++i)
+    for (let i = 0; i < patterns.length; ++i) {
       this._list.appendItem(patterns[i], true);
+    }
   }
 
   _addButtonClicked() {
@@ -77,8 +78,9 @@
     element.createChild('div', 'blackbox-separator');
     element.createChild('div', 'blackbox-behavior').textContent =
         item.disabled ? this._disabledLabel : this._blackboxLabel;
-    if (item.disabled)
+    if (item.disabled) {
       element.classList.add('blackbox-disabled');
+    }
     return element;
   }
 
@@ -104,8 +106,9 @@
     item.disabled = editor.control('behavior').value === this._disabledLabel;
 
     const list = this._setting.getAsArray();
-    if (isNew)
+    if (isNew) {
       list.push(item);
+    }
     this._setting.setAsArray(list);
   }
 
@@ -125,8 +128,9 @@
    * @return {!UI.ListWidget.Editor}
    */
   _createEditor() {
-    if (this._editor)
+    if (this._editor) {
       return this._editor;
+    }
 
     const editor = new UI.ListWidget.Editor();
     this._editor = editor;
@@ -159,12 +163,14 @@
       const pattern = input.value.trim();
       const patterns = this._setting.getAsArray();
 
-      if (!pattern.length)
+      if (!pattern.length) {
         return {valid: false, errorMessage: ls`Pattern cannot be empty`};
+      }
 
       for (let i = 0; i < patterns.length; ++i) {
-        if (i !== index && patterns[i].pattern === pattern)
+        if (i !== index && patterns[i].pattern === pattern) {
           return {valid: false, errorMessage: ls`Pattern already exists`};
+        }
       }
 
       let regex;
@@ -172,10 +178,11 @@
         regex = new RegExp(pattern);
       } catch (e) {
       }
-      if (!regex)
+      if (!regex) {
         return {valid: false, errorMessage: ls`Pattern must be a valid regular expression`};
-      else
+      } else {
         return {valid: true};
+      }
     }
 
     /**