Google Git
Sign in
chromium / devtools / devtools-frontend / 4be405ef353c9263c1c5e95500f23fae4ede4daa
commit4be405ef353c9263c1c5e95500f23fae4ede4daa[log] [tgz]
authorMichal Pitr <[email protected]>Tue Jul 26 11:09:22 2022
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jul 26 12:02:59 2022
treebae5a15fa86da32756bc6c3f5da3241dedc56277
parentb56cdf4658defeae6d8e3d81a5055771b51ae1be [diff]
[LMI] Move highlightInfo storage from View to Controller

This CL changes where highlightInfo is stored and
how it gets passed from the Controller to the UI components.
Previously, highlightInfo was cached inside of
the LinearMemoryInspectorView instances. This required
a clunky data-flow between the Controller and the
InspectorView. Instead, this CL moves the storage
of highlightInfo to the Controller and exposes a getter
function for the UI components to use.

We store highlightInfos in a Map
with bufferIds as keys. This will be easy to extend to
support storing multiple highlights. To make access
possible from the InspectorView, we pass it its bufferId.

Bug: 1336568
Change-Id: Ib6387a174701e9a720b5602100f0e7d5454f1ac5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3784598
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Michal Pitr <[email protected]>
Reviewed-by: Kim-Anh Tran <[email protected]>
3 files changed
tree: bae5a15fa86da32756bc6c3f5da3241dedc56277
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. ARCHITECTURE.md
  27. AUTHORS
  28. BUILD.gn
  29. codereview.settings
  30. DEPS
  31. LICENSE
  32. OWNERS
  33. package-lock.json
  34. package.json
  35. PRESUBMIT.py
  36. README.md
  37. tsconfig.json
  38. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch