[ve] Annotate Network panel menus
Bug: chromium:1467464
Change-Id: I9c042a3c9182df5daf674feb0801db79c596fa75
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5319492
Reviewed-by: Wolfgang Beyer <[email protected]>
Commit-Queue: Wolfgang Beyer <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts
index 39a3c83..3417167 100644
--- a/front_end/panels/network/NetworkLogView.ts
+++ b/front_end/panels/network/NetworkLogView.ts
@@ -1675,26 +1675,31 @@
handleContextMenuForRequest(contextMenu: UI.ContextMenu.ContextMenu, request: SDK.NetworkRequest.NetworkRequest):
void {
contextMenu.appendApplicableItems(request);
- const copyMenu = contextMenu.clipboardSection().appendSubMenuItem(i18nString(UIStrings.copy));
+ const copyMenu = contextMenu.clipboardSection().appendSubMenuItem(i18nString(UIStrings.copy), false, 'copy');
if (request) {
copyMenu.defaultSection().appendItem(
i18nString(UIStrings.copyURL),
Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText.bind(
- Host.InspectorFrontendHost.InspectorFrontendHostInstance, request.contentURL()));
- copyMenu.footerSection().appendItem(i18nString(UIStrings.copyAllURLs), this.copyAllURLs.bind(this));
+ Host.InspectorFrontendHost.InspectorFrontendHostInstance, request.contentURL()),
+ {jslogContext: 'copy-url'});
+ copyMenu.footerSection().appendItem(
+ i18nString(UIStrings.copyAllURLs), this.copyAllURLs.bind(this), {jslogContext: 'copy-all-urls'});
if (request.requestHeadersText()) {
copyMenu.saveSection().appendItem(
- i18nString(UIStrings.copyRequestHeaders), NetworkLogView.copyRequestHeaders.bind(null, request));
+ i18nString(UIStrings.copyRequestHeaders), NetworkLogView.copyRequestHeaders.bind(null, request),
+ {jslogContext: 'copy-request-headers'});
}
if (request.responseHeadersText) {
copyMenu.saveSection().appendItem(
- i18nString(UIStrings.copyResponseHeaders), NetworkLogView.copyResponseHeaders.bind(null, request));
+ i18nString(UIStrings.copyResponseHeaders), NetworkLogView.copyResponseHeaders.bind(null, request),
+ {jslogContext: 'copy-response-headers'});
}
if (request.finished) {
copyMenu.saveSection().appendItem(
- i18nString(UIStrings.copyResponse), NetworkLogView.copyResponse.bind(null, request));
+ i18nString(UIStrings.copyResponse), NetworkLogView.copyResponse.bind(null, request),
+ {jslogContext: 'copy-response'});
}
const initiator = request.initiator();
@@ -1709,7 +1714,7 @@
if (stackTraceText !== '') {
copyMenu.saveSection().appendItem(i18nString(UIStrings.copyStacktrace), () => {
Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText(stackTraceText);
- });
+ }, {jslogContext: 'copy-stacktrace'});
}
}
}
@@ -1718,50 +1723,63 @@
if (Host.Platform.isWin()) {
copyMenu.defaultSection().appendItem(
i18nString(UIStrings.copyAsCurlCmd), this.copyCurlCommand.bind(this, request, 'win'),
- {disabled: disableIfBlob});
+ {disabled: disableIfBlob, jslogContext: 'copy-as-curl-cmd'});
copyMenu.defaultSection().appendItem(
i18nString(UIStrings.copyAsCurlBash), this.copyCurlCommand.bind(this, request, 'unix'),
- {disabled: disableIfBlob});
+ {disabled: disableIfBlob, jslogContext: 'copy-as-curl-bash'});
} else {
copyMenu.defaultSection().appendItem(
i18nString(UIStrings.copyAsCurl), this.copyCurlCommand.bind(this, request, 'unix'),
- {disabled: disableIfBlob});
+ {disabled: disableIfBlob, jslogContext: 'copy-as-curl'});
}
copyMenu.defaultSection().appendItem(
i18nString(UIStrings.copyAsPowershell), this.copyPowerShellCommand.bind(this, request),
- {disabled: disableIfBlob});
+ {disabled: disableIfBlob, jslogContext: 'copy-as-powershell'});
copyMenu.defaultSection().appendItem(
i18nString(UIStrings.copyAsFetch), this.copyFetchCall.bind(this, request, FetchStyle.Browser),
- {disabled: disableIfBlob});
+ {disabled: disableIfBlob, jslogContext: 'copy-as-fetch'});
copyMenu.defaultSection().appendItem(
i18nString(UIStrings.copyAsNodejsFetch), this.copyFetchCall.bind(this, request, FetchStyle.NodeJs),
- {disabled: disableIfBlob});
+ {disabled: disableIfBlob, jslogContext: 'copy-as-nodejs-fetch'});
if (Host.Platform.isWin()) {
copyMenu.footerSection().appendItem(
- i18nString(UIStrings.copyAllAsCurlCmd), this.copyAllCurlCommand.bind(this, 'win'));
+ i18nString(UIStrings.copyAllAsCurlCmd), this.copyAllCurlCommand.bind(this, 'win'),
+ {jslogContext: 'copy-all-as-curl-cmd'});
copyMenu.footerSection().appendItem(
- i18nString(UIStrings.copyAllAsCurlBash), this.copyAllCurlCommand.bind(this, 'unix'));
+ i18nString(UIStrings.copyAllAsCurlBash), this.copyAllCurlCommand.bind(this, 'unix'),
+ {jslogContext: 'copy-all-as-curl-bash'});
} else {
copyMenu.footerSection().appendItem(
- i18nString(UIStrings.copyAllAsCurl), this.copyAllCurlCommand.bind(this, 'unix'));
+ i18nString(UIStrings.copyAllAsCurl), this.copyAllCurlCommand.bind(this, 'unix'),
+ {jslogContext: 'copy-all-as-curl'});
}
copyMenu.footerSection().appendItem(
- i18nString(UIStrings.copyAllAsPowershell), this.copyAllPowerShellCommand.bind(this));
+ i18nString(UIStrings.copyAllAsPowershell), this.copyAllPowerShellCommand.bind(this),
+ {jslogContext: 'copy-all-as-powershell'});
copyMenu.footerSection().appendItem(
- i18nString(UIStrings.copyAllAsFetch), this.copyAllFetchCall.bind(this, FetchStyle.Browser));
+ i18nString(UIStrings.copyAllAsFetch), this.copyAllFetchCall.bind(this, FetchStyle.Browser),
+ {jslogContext: 'copy-all-as-fetch'});
copyMenu.footerSection().appendItem(
- i18nString(UIStrings.copyAllAsNodejsFetch), this.copyAllFetchCall.bind(this, FetchStyle.NodeJs));
+ i18nString(UIStrings.copyAllAsNodejsFetch), this.copyAllFetchCall.bind(this, FetchStyle.NodeJs),
+ {jslogContext: 'copy-all-as-nodejs-fetch'});
}
- copyMenu.footerSection().appendItem(i18nString(UIStrings.copyAllAsHar), this.copyAllAsHAR.bind(this));
+ copyMenu.footerSection().appendItem(
+ i18nString(UIStrings.copyAllAsHar), this.copyAllAsHAR.bind(this), {jslogContext: 'copy-all-as-har'});
- contextMenu.saveSection().appendItem(i18nString(UIStrings.saveAllAsHarWithContent), this.exportAll.bind(this));
+ contextMenu.saveSection().appendItem(
+ i18nString(UIStrings.saveAllAsHarWithContent), this.exportAll.bind(this),
+ {jslogContext: 'save-all-as-har-with-content'});
contextMenu.overrideSection().appendItem(
- i18nString(UIStrings.overrideHeaders), this.#handleCreateResponseHeaderOverrideClick.bind(this, request));
+ i18nString(UIStrings.overrideHeaders), this.#handleCreateResponseHeaderOverrideClick.bind(this, request),
+ {jslogContext: 'override-headers'});
- contextMenu.editSection().appendItem(i18nString(UIStrings.clearBrowserCache), this.clearBrowserCache.bind(this));
contextMenu.editSection().appendItem(
- i18nString(UIStrings.clearBrowserCookies), this.clearBrowserCookies.bind(this));
+ i18nString(UIStrings.clearBrowserCache), this.clearBrowserCache.bind(this),
+ {jslogContext: 'clear-browser-cache'});
+ contextMenu.editSection().appendItem(
+ i18nString(UIStrings.clearBrowserCookies), this.clearBrowserCookies.bind(this),
+ {jslogContext: 'clear-browser-cookies'});
if (request) {
const maxBlockedURLLength = 20;
@@ -1784,26 +1802,31 @@
const urlWithoutScheme = request.parsedURL.urlWithoutScheme();
if (urlWithoutScheme && !patterns.find(pattern => pattern.url === urlWithoutScheme)) {
contextMenu.debugSection().appendItem(
- i18nString(UIStrings.blockRequestUrl), addBlockedURL.bind(null, urlWithoutScheme));
+ i18nString(UIStrings.blockRequestUrl), addBlockedURL.bind(null, urlWithoutScheme),
+ {jslogContext: 'block-request-url'});
} else if (urlWithoutScheme) {
const croppedURL = Platform.StringUtilities.trimMiddle(urlWithoutScheme, maxBlockedURLLength);
contextMenu.debugSection().appendItem(
- i18nString(UIStrings.unblockS, {PH1: croppedURL}), removeBlockedURL.bind(null, urlWithoutScheme));
+ i18nString(UIStrings.unblockS, {PH1: croppedURL}), removeBlockedURL.bind(null, urlWithoutScheme),
+ {jslogContext: 'unblock'});
}
const domain = request.parsedURL.domain();
if (domain && !patterns.find(pattern => pattern.url === domain)) {
contextMenu.debugSection().appendItem(
- i18nString(UIStrings.blockRequestDomain), addBlockedURL.bind(null, domain));
+ i18nString(UIStrings.blockRequestDomain), addBlockedURL.bind(null, domain),
+ {jslogContext: 'block-request-domain'});
} else if (domain) {
const croppedDomain = Platform.StringUtilities.trimMiddle(domain, maxBlockedURLLength);
contextMenu.debugSection().appendItem(
- i18nString(UIStrings.unblockS, {PH1: croppedDomain}), removeBlockedURL.bind(null, domain));
+ i18nString(UIStrings.unblockS, {PH1: croppedDomain}), removeBlockedURL.bind(null, domain),
+ {jslogContext: 'unblock'});
}
if (SDK.NetworkManager.NetworkManager.canReplayRequest(request)) {
contextMenu.debugSection().appendItem(
- i18nString(UIStrings.replayXhr), SDK.NetworkManager.NetworkManager.replayRequest.bind(null, request));
+ i18nString(UIStrings.replayXhr), SDK.NetworkManager.NetworkManager.replayRequest.bind(null, request),
+ {jslogContext: 'replay-xhr'});
}
}
}
