| commit | 29cc4f31047a69e3c6f55388f42db2506b1adc95 | [log] [tgz] |
|---|---|---|
| author | Jack Lynch <[email protected]> | Wed Jul 22 21:52:05 2020 |
| committer | Commit Bot <[email protected]> | Thu Jul 23 00:16:57 2020 |
| tree | f6166c751d1159e3f8e40018842683e9614212c3 | |
| parent | cc02814e07b329e1a701920a9f209f39094460a8 [diff] [blame] |
Fix Network Datagrid focus bug This CL fixes a bug where clicking on an item in the Network panel would focus its headers, preventing users from arrow keying through the grid. Activating an item with the keyboard still moves focus to allow screen reader users to navigate the panel. Video: https://i.imgur.com/aFc1DJi.mp4 Bug: 1107381 Change-Id: I9230bffe32a26380715ee51138c478dcfb8f6bc2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2315077 Reviewed-by: Brandon Goddard <[email protected]> Commit-Queue: Jack Lynch <[email protected]>
diff --git a/front_end/network/NetworkLogView.js b/front_end/network/NetworkLogView.js index 56c0b03..fa73c25 100644 --- a/front_end/network/NetworkLogView.js +++ b/front_end/network/NetworkLogView.js
@@ -783,7 +783,7 @@ this._dataGrid.element.addEventListener('mouseleave', () => this._setHoveredNode(null), true); this._dataGrid.element.addEventListener('keydown', event => { if (isEnterOrSpaceKey(event)) { - this.dispatchEventToListeners(Events.RequestActivated, {showPanel: true}); + this.dispatchEventToListeners(Events.RequestActivated, {showPanel: true, takeFocus: true}); event.consume(true); } });