Google Git
Sign in
chromium / devtools / devtools-frontend / b4aa8c0c2d7c0167b52fcd5bad1aeab42ee3521e
commitb4aa8c0c2d7c0167b52fcd5bad1aeab42ee3521e[log] [tgz]
authorJack Franklin <[email protected]>Wed Oct 04 14:59:58 2023
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 04 15:34:03 2023
treeaf63fb8790e293d064add97f93a97c2b51e0df25
parentb01d647300e4bf5a6df181183451e9705d5cf513 [diff]
Fix ProfileCall nodes being excluded

The filters we apply when generating the tables were incorrectly
removing any ProfileCall events due to them not having a matching record
type. To fix this, we map their RecordType to the RecordType.JSFrame
type, as they are broadly equivalent.

Long term we need to figure out what to do with this RecordType, and how
to reconcile it with the new engine, but this is a fix that enables the
bottom up chart to be correctly populated.

Bug: 1488757
Change-Id: Ic394371e683251c6c77699210bcd70a62be16e3b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4909533
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Andres Olivares <[email protected]>
5 files changed
tree: af63fb8790e293d064add97f93a97c2b51e0df25
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch