[ts] Type-check ui/ResizerWidget.js with TypeScript
[email protected]
Bug: chromium:1011811
Change-Id: I0cc4fcc06b33c715d1a8ee642c91b54e395f8b14
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2351781
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
diff --git a/front_end/ui/ResizerWidget.js b/front_end/ui/ResizerWidget.js
index 979a4b9..525547f 100644
--- a/front_end/ui/ResizerWidget.js
+++ b/front_end/ui/ResizerWidget.js
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// @ts-nocheck
-// TODO(crbug.com/1011811): Enable TypeScript compiler checks
-
import * as Common from '../common/common.js';
import {elementDragStart} from './UIUtils.js';
@@ -16,7 +13,7 @@
super();
this._isEnabled = true;
- /** @type {!Set<!Element>} */
+ /** @type {!Set<!HTMLElement>} */
this._elements = new Set();
this._installDragOnMouseDownBound = this._installDragOnMouseDown.bind(this);
this._cursor = 'nwse-resize';
@@ -45,7 +42,7 @@
}
/**
- * @param {!Element} element
+ * @param {!HTMLElement} element
*/
addElement(element) {
if (!this._elements.has(element)) {
@@ -56,7 +53,7 @@
}
/**
- * @param {!Element} element
+ * @param {!HTMLElement} element
*/
removeElement(element) {
if (this._elements.has(element)) {
@@ -71,7 +68,7 @@
}
/**
- * @param {!Element} element
+ * @param {!HTMLElement} element
*/
_updateElementCursor(element) {
if (this._isEnabled) {
@@ -100,7 +97,7 @@
* @param {!Event} event
*/
_installDragOnMouseDown(event) {
- const element = /** @type {!Element} */ (event.target);
+ const element = /** @type {!HTMLElement} */ (event.target);
// Only handle drags of the nodes specified.
if (!this._elements.has(element)) {
return false;
@@ -108,6 +105,7 @@
elementDragStart(element, this._dragStart.bind(this), event => {
this._drag(event);
}, this._dragEnd.bind(this), this.cursor(), event);
+ return undefined;
}
/**
@@ -142,7 +140,9 @@
return true; // Cancel drag.
}
- this.sendDragMove(this._startX, event.pageX, this._startY, event.pageY, event.shiftKey);
+ this.sendDragMove(
+ /** @type {number} */ (this._startX), event.pageX, /** @type {number} */ (this._startY), event.pageY,
+ event.shiftKey);
event.preventDefault();
return false; // Continue drag.
}
