Google Git
Sign in
chromium / devtools / devtools-frontend / 377d2ac1b92dd5097cbc1bfb739c094bd738fc90
commit377d2ac1b92dd5097cbc1bfb739c094bd738fc90[log] [tgz]
authorAl Muthanna Athamina <[email protected]>Thu Feb 16 12:11:38 2023
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 16 13:34:19 2023
tree416ea1c7df238773142c502597d347f31905fd38
parentc8db49a9f2a919f35b5a5618ae430bd7136f3254 [diff]
Deflake breakpoints added to workers tests

The reason for the flakiness is at `addBreakpointForLine`; since there is no visiual indicator that the setting of the breakpoint is complete the script that is supposed to trigger the breakpoint is ran before it is created, resulting in it timing out at await `waitFor(RESUME_BUTTON);`. This was apparent because adding a wait after this line significantly reduced the flake. I tried to fire an event and listen to it in the test but I could not pinpoint where in the code the breakpoint creation is complete, We also tried retrying the operation until we hit the breakpoint, but at the end we decided to enable `instrumentationBreakpoints` which seems to solve the issue. Please find the below stress runs to confirm this:

- https://ci.chromium.org/ui/p/devtools-frontend/builders/try/e2e_stressor_linux/b8789007907630062209/overview
- https://ci.chromium.org/ui/p/devtools-frontend/builders/try/e2e_stressor_mac/b8789007907630062193/overview
- https://ci.chromium.org/ui/p/devtools-frontend/builders/try/e2e_stressor_win64/b8789007907630062177/overview

Bug: 1368493
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_mac_rel
Change-Id: I98eebdd497e4f793847e52cd1e16b54aaa4056f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4231794
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Almothana Athamneh <[email protected]>
1 file changed
tree: 416ea1c7df238773142c502597d347f31905fd38
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch