Deflake breakpoints added to workers tests
The reason for the flakiness is at `addBreakpointForLine`; since there is no visiual indicator that the setting of the breakpoint is complete the script that is supposed to trigger the breakpoint is ran before it is created, resulting in it timing out at await `waitFor(RESUME_BUTTON);`. This was apparent because adding a wait after this line significantly reduced the flake. I tried to fire an event and listen to it in the test but I could not pinpoint where in the code the breakpoint creation is complete, We also tried retrying the operation until we hit the breakpoint, but at the end we decided to enable `instrumentationBreakpoints` which seems to solve the issue. Please find the below stress runs to confirm this:
- https://ci.chromium.org/ui/p/devtools-frontend/builders/try/e2e_stressor_linux/b8789007907630062209/overview
- https://ci.chromium.org/ui/p/devtools-frontend/builders/try/e2e_stressor_mac/b8789007907630062193/overview
- https://ci.chromium.org/ui/p/devtools-frontend/builders/try/e2e_stressor_win64/b8789007907630062177/overview
Bug: 1368493
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_mac_rel
Change-Id: I98eebdd497e4f793847e52cd1e16b54aaa4056f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4231794
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Almothana Athamneh <[email protected]>
diff --git a/test/e2e/sources/script-in-multiple-workers_test.ts b/test/e2e/sources/script-in-multiple-workers_test.ts
index eaf18d5..bb27d15 100644
--- a/test/e2e/sources/script-in-multiple-workers_test.ts
+++ b/test/e2e/sources/script-in-multiple-workers_test.ts
@@ -7,6 +7,7 @@
import {
$$,
click,
+ enableExperiment,
getBrowserAndPages,
goToResource,
step,
@@ -202,6 +203,7 @@
describe(`hits breakpoints added to workers ${withOrWithout}`, () => {
beforeEach(async () => {
+ await enableExperiment('instrumentationBreakpoints');
const {frontend} = getBrowserAndPages();
await waitForSourceFiles(
SourceFileEvents.SourceFileLoaded, files => files.some(f => f.endsWith('multi-workers.js')), async () => {
@@ -240,8 +242,7 @@
await validateSourceTabs();
});
- // Flaky test.
- it.skip('[crbug.com/1368493] for newly created workers', async () => {
+ it('for newly created workers', async () => {
const {target} = getBrowserAndPages();
// Launch new worker to hit breakpoint
await target.evaluate(`new Worker('${scriptFile}').postMessage({});`);
