Reland "Fix typescript compilation with ts_library"
This reverts commit a7de1bbca072ff9d5a46d17ad5c71c01d1ed2288.
Reason for revert: Suspected issue with local machine. Chromium CQ was green.
Original change's description:
> Revert "Fix typescript compilation with ts_library"
>
> This reverts commit 85de0bc72ef7929abfa352bd7a0efa016cdf5fbb.
>
> Reason for revert: From Chase: build error after this change rolled into Chromium at https://crrev.com/c/2008257
>
> DISABLE_THIRD_PARTY_CHECK=Bypassing checks for revert
>
> Original change's description:
> > Fix typescript compilation with ts_library
> >
> > This CL prepares ts_library to work correctly by building both in Chromium
> > as well as in DevTools. A follow-up CL will add a simple ts_library
> > to verify that it keeps on working.
> >
> > Bug: 1011811
> > Change-Id: I482761bfbcbf459478dc7f51f2df6576ac872de6
> > DISABLE_THIRD_PARTY_CHECK=TypeScript build configuration changes
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960456
> > Reviewed-by: Paul Lewis <[email protected]>
> > Commit-Queue: Tim van der Lippe <[email protected]>
>
> [email protected],[email protected],[email protected]
>
>
> Bug: 1011811
> Change-Id: Id354882f8f8706241ac377e62ff68cc9eb6ff994
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013141
> Reviewed-by: Paul Lewis <[email protected]>
> Commit-Queue: Paul Lewis <[email protected]>
[email protected],[email protected],[email protected]
Change-Id: Iafc3a005d53fc040ca2a1708c6f2fef1ac53c48d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013144
Reviewed-by: Tim van der Lippe <[email protected]>
Commit-Queue: Tim van der Lippe <[email protected]>
diff --git a/BUILD.gn b/BUILD.gn
index 15d1d0a..b7ce283 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2186,20 +2186,22 @@
]
}
-devtools_frontend_resources_deps = [
- ":aria_properties",
- ":build_release_devtools",
- ":copy_devtools_modules",
- ":copy_embedder_scripts",
- ":copy_emulated_devices_images",
- ":copy_htaccess",
- ":copy_inspector_images",
- ":copy_lighthouse_locale_files",
- ":copy_wasm_deps",
- ":devtools_extension_api",
- ":frontend_protocol_sources",
- ":supported_css_properties",
-]
+devtools_typescript_deps = [ "front_end/common:common" ]
+
+devtools_frontend_resources_deps = devtools_typescript_deps + [
+ ":aria_properties",
+ ":build_release_devtools",
+ ":copy_devtools_modules",
+ ":copy_embedder_scripts",
+ ":copy_emulated_devices_images",
+ ":copy_htaccess",
+ ":copy_inspector_images",
+ ":copy_lighthouse_locale_files",
+ ":copy_wasm_deps",
+ ":devtools_extension_api",
+ ":frontend_protocol_sources",
+ ":supported_css_properties",
+ ]
if (debug_devtools) {
devtools_frontend_resources_deps += [
