| commit | 3e4e569cd25707f6afddd5b54f3e5b5eef98e716 | [log] [tgz] |
|---|---|---|
| author | Peter Marshall <[email protected]> | Mon Dec 09 16:48:04 2019 |
| committer | Commit Bot <[email protected]> | Tue Dec 10 09:00:24 2019 |
| tree | f07c90d592efbf2b66fa5337d6554207b7101b07 | |
| parent | 2f6ac2feb1dea9e51a828034dc0ad5962c72bee7 [diff] [blame] |
Remove asParsedURL on the String prototype Use a static function on the ParsedURL class instead. A lot of our tooling is happier linking through to the class method rather than the prototype thing, and setting things on prototypes is generally discouraged in JS for a bunch of reasons. Change-Id: I95cf70ed58e7cca6d4c2bf7633b69199f513d068 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1958524 Reviewed-by: Tim van der Lippe <[email protected]> Commit-Queue: Peter Marshall <[email protected]>
diff --git a/front_end/network/NetworkLogView.js b/front_end/network/NetworkLogView.js index 1be624b..475034f 100644 --- a/front_end/network/NetworkLogView.js +++ b/front_end/network/NetworkLogView.js
@@ -1409,7 +1409,7 @@ async exportAll() { const url = SDK.targetManager.mainTarget().inspectedURL(); - const parsedURL = url.asParsedURL(); + const parsedURL = Common.ParsedURL.fromString(url); const filename = parsedURL ? parsedURL.host : 'network-log'; const stream = new Bindings.FileOutputStream();