Add verify_lib_check to ts_library
Previously, we were gating the `skipLibCheck` on `is_debug=true`.
However, this introduced the problem where CQ runs would fail on
compilation, but local runs succeeding. This confused developers
and required handling a different GN output directory with the GN
flag `is_debug=false`.
But, we don't want to lose the performance benefit related to not
unnecessarily checking all `.d.ts` files all the time. So we have
to find a middleground.
The solution is to add 1 `ts_library` target in `front_end` which
essentially verifies that the `.d.ts` are all in good order. This
means we only do the check once, irrespective the number of
`ts_library` targets in the frontend.
DISABLE_THIRD_PARTY_CHECK=TypeScript fix
[email protected]
[email protected]
Bug: 1011811
Change-Id: Ide2d3a5935fdc34dc79572d65c9e5ce92d78a9a8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209090
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Tim van der Lippe <[email protected]>
diff --git a/front_end/verification.ts b/front_end/verification.ts
new file mode 100644
index 0000000..23fc77b
--- /dev/null
+++ b/front_end/verification.ts
@@ -0,0 +1,12 @@
+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import './browser_sdk/browser_sdk.js';
+import './common/common.js';
+import './host/host.js';
+import './inspector_overlay/inspector_overlay.js';
+import './protocol_client/protocol_client.js';
+import './root/root.js';
+import './sdk/sdk.js';
+import './workspace/workspace.js';
