Migrates audits/ to ESM internally
Bug: 1006759
Change-Id: I8a8d88f00c2c039dd9effe8335f3e7c1bc5bb4a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993343
Commit-Queue: Paul Lewis <[email protected]>
Reviewed-by: Tim van der Lippe <[email protected]>
diff --git a/front_end/audits/AuditsStartView.js b/front_end/audits/AuditsStartView.js
index 0f0109b..0137ba2 100644
--- a/front_end/audits/AuditsStartView.js
+++ b/front_end/audits/AuditsStartView.js
@@ -2,12 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+import {AuditController, Events, Presets, RuntimeSettings} from './AuditsController.js'; // eslint-disable-line no-unused-vars
+import {RadioSetting} from './RadioSetting.js';
+
/**
* @unrestricted
*/
-export default class StartView extends UI.Widget {
+export class StartView extends UI.Widget {
/**
- * @param {!Audits.AuditController} controller
+ * @param {!AuditController} controller
*/
constructor(controller) {
super();
@@ -30,12 +33,12 @@
* @param {!Element} parentElement
*/
_populateRuntimeSettingAsRadio(settingName, label, parentElement) {
- const runtimeSetting = Audits.RuntimeSettings.find(item => item.setting.name === settingName);
+ const runtimeSetting = RuntimeSettings.find(item => item.setting.name === settingName);
if (!runtimeSetting || !runtimeSetting.options) {
throw new Error(`${settingName} is not a setting with options`);
}
- const control = new Audits.RadioSetting(runtimeSetting.options, runtimeSetting.setting, runtimeSetting.description);
+ const control = new RadioSetting(runtimeSetting.options, runtimeSetting.setting, runtimeSetting.description);
parentElement.appendChild(control.element);
UI.ARIAUtils.setAccessibleName(control.element, label);
}
@@ -45,7 +48,7 @@
* @param {!UI.Toolbar} toolbar
*/
_populateRuntimeSettingAsToolbarCheckbox(settingName, toolbar) {
- const runtimeSetting = Audits.RuntimeSettings.find(item => item.setting.name === settingName);
+ const runtimeSetting = RuntimeSettings.find(item => item.setting.name === settingName);
if (!runtimeSetting || !runtimeSetting.title) {
throw new Error(`${settingName} is not a setting with a title`);
}
@@ -71,7 +74,7 @@
// Populate the categories
const categoryFormElements = fragment.$('categories-form-elements');
const pluginFormElements = fragment.$('plugins-form-elements');
- for (const preset of Audits.Presets) {
+ for (const preset of Presets) {
const formElements = preset.plugin ? pluginFormElements : categoryFormElements;
preset.setting.setTitle(preset.title);
const checkbox = new UI.ToolbarSettingCheckbox(preset.setting);
@@ -92,7 +95,7 @@
this._startButton = UI.createTextButton(
ls`Generate report`,
() => this._controller.dispatchEventToListeners(
- Audits.Events.RequestAuditStart,
+ Events.RequestAuditStart,
/* keyboardInitiated */ UI.elementIsFocusedByKeyboard(this._startButton)),
/* className */ '', /* primary */ true);
this.setDefaultFocusedElement(this._startButton);
@@ -180,14 +183,3 @@
}
}
}
-
-/* Legacy exported object */
-self.Audits = self.Audits || {};
-
-/* Legacy exported object */
-Audits = Audits || {};
-
-/**
- * @constructor
- */
-Audits.StartView = StartView;
