| commit | 64d1fecc4623380f3ab977bf55609e924ed79530 | [log] [tgz] |
|---|---|---|
| author | Benedikt Meurer <[email protected]> | Fri Nov 24 10:32:08 2023 |
| committer | Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 24 10:56:45 2023 |
| tree | b15a6cb6a5601ddb34bfc2cc74319f477f6b32cc | |
| parent | 1d1702dde0e9098fb58783a40bed5a84cbbf7489 [diff] [blame] |
[cleanup] Remove `ActionDelegate` singletons. The `ActionDelegate` implementation singletons don't serve any specific purpose: These instances are extremely cheap to instantiate (much cheaper than the singleton bookkeeping actually) and don't have any meaningful identities that would require the use of the singleton pattern here. But instead it just adds clutter to the code base, which we can completely avoid. Bug: chromium:1379221 Change-Id: If298cf8e3c9f27f60325cd88a476251de5bd4b14 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5057777 Auto-Submit: Benedikt Meurer <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
diff --git a/front_end/ui/legacy/ActionRegistration.ts b/front_end/ui/legacy/ActionRegistration.ts index 342611f..76d96c2 100644 --- a/front_end/ui/legacy/ActionRegistration.ts +++ b/front_end/ui/legacy/ActionRegistration.ts
@@ -457,7 +457,7 @@ * <...> * async loadActionDelegate() { * const Elements = await loadElementsModule(); - * return Elements.ElementsPanel.ElementsActionDelegate.instance(); + * return new Elements.ElementsPanel.ElementsActionDelegate(); * }, * <...> * });