Remove header overrides experiment and legacy RequestHeadersView
The experiment has been enabled by default since March, it should be
safe to remove it by now and only use the new RequestHeadersView from
now on.
Bug: chromium:1297533, b:315125001
Change-Id: I37aefcd07137de38f0e22eb7505c624fd7f2f359
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5068025
Commit-Queue: Benedikt Meurer <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
diff --git a/front_end/core/host/UserMetrics.ts b/front_end/core/host/UserMetrics.ts
index 52a7b52..d6a452b 100644
--- a/front_end/core/host/UserMetrics.ts
+++ b/front_end/core/host/UserMetrics.ts
@@ -973,7 +973,6 @@
'experimentalCookieFeatures' = 45,
'bfcacheDisplayTree' = 54,
'stylesPaneCSSChanges' = 55,
- 'headerOverrides' = 56,
'evaluateExpressionsWithSourceMaps' = 58,
'eyedropperColorPicker' = 60,
'instrumentationBreakpoints' = 61,
diff --git a/front_end/entrypoints/main/MainImpl.ts b/front_end/entrypoints/main/MainImpl.ts
index 0532778..fe8557c 100644
--- a/front_end/entrypoints/main/MainImpl.ts
+++ b/front_end/entrypoints/main/MainImpl.ts
@@ -352,10 +352,6 @@
Root.Runtime.ExperimentName.HIGHLIGHT_ERRORS_ELEMENTS_PANEL,
'Highlights a violating node or attribute in the Elements panel DOM tree');
- // Local overrides
- Root.Runtime.experiments.register(
- Root.Runtime.ExperimentName.HEADER_OVERRIDES, 'Local overrides for response headers');
-
// Enable color picking outside the browser window (using Eyedropper API)
Root.Runtime.experiments.register(
Root.Runtime.ExperimentName.EYEDROPPER_COLOR_PICKER, 'Enable color picking outside the browser window');
@@ -425,7 +421,6 @@
'setAllBreakpointsEagerly',
Root.Runtime.ExperimentName.TIMELINE_AS_CONSOLE_PROFILE_RESULT_PANEL,
Root.Runtime.ExperimentName.WASM_DWARF_DEBUGGING,
- Root.Runtime.ExperimentName.HEADER_OVERRIDES,
Root.Runtime.ExperimentName.OUTERMOST_TARGET_SELECTOR,
Root.Runtime.ExperimentName.SELF_XSS_WARNING,
Root.Runtime.ExperimentName.PRELOADING_STATUS_PANEL,
diff --git a/front_end/models/persistence/NetworkPersistenceManager.ts b/front_end/models/persistence/NetworkPersistenceManager.ts
index 958af30..4ef67bf 100644
--- a/front_end/models/persistence/NetworkPersistenceManager.ts
+++ b/front_end/models/persistence/NetworkPersistenceManager.ts
@@ -5,7 +5,6 @@
import * as Common from '../../core/common/common.js';
import * as Host from '../../core/host/host.js';
import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as Protocol from '../../generated/protocol.js';
import * as UI from '../../ui/legacy/legacy.js';
@@ -699,8 +698,7 @@
continue;
}
const pattern = this.patternForFileSystemUISourceCode(uiSourceCode);
- if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES) &&
- uiSourceCode.name() === HEADERS_FILENAME) {
+ if (uiSourceCode.name() === HEADERS_FILENAME) {
const {headerPatterns, path, overridesWithRegex} = await this.generateHeaderPatterns(uiSourceCode);
if (headerPatterns.size > 0) {
patterns = new Set([...patterns, ...headerPatterns]);
@@ -925,10 +923,7 @@
const proj = this.projectInternal as FileSystem;
const path = this.fileUrlFromNetworkUrl(interceptedRequest.request.url as Platform.DevToolsPath.UrlString);
const fileSystemUISourceCode = proj.uiSourceCodeForURL(path);
- let responseHeaders: Protocol.Fetch.HeaderEntry[] = [];
- if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
- responseHeaders = this.handleHeaderInterception(interceptedRequest);
- }
+ let responseHeaders = this.handleHeaderInterception(interceptedRequest);
if (!fileSystemUISourceCode && !responseHeaders.length) {
return;
}
diff --git a/front_end/panels/application/ServiceWorkerCacheViews.ts b/front_end/panels/application/ServiceWorkerCacheViews.ts
index ae98b8c..6657fe1 100644
--- a/front_end/panels/application/ServiceWorkerCacheViews.ts
+++ b/front_end/panels/application/ServiceWorkerCacheViews.ts
@@ -6,15 +6,16 @@
import * as i18n from '../../core/i18n/i18n.js';
import * as Platform from '../../core/platform/platform.js';
import * as SDK from '../../core/sdk/sdk.js';
+import type * as Protocol from '../../generated/protocol.js';
+import * as LegacyWrapper from '../../ui/components/legacy_wrapper/legacy_wrapper.js';
import * as DataGrid from '../../ui/legacy/components/data_grid/data_grid.js';
import * as UI from '../../ui/legacy/legacy.js';
+import * as NetworkComponents from '../network/components/components.js';
+import * as Network from '../network/network.js';
import * as ApplicationComponents from './components/components.js';
import serviceWorkerCacheViewsStyles from './serviceWorkerCacheViews.css.js';
-import type * as Protocol from '../../generated/protocol.js';
-import * as Network from '../network/network.js';
-
const UIStrings = {
/**
*@description Text in Application Panel Sidebar of the Application panel
@@ -515,7 +516,9 @@
this.resourceViewTabSetting = Common.Settings.Settings.instance().createSetting('cacheStorageViewTab', 'preview');
this.tabbedPane.appendTab(
- 'headers', i18nString(UIStrings.headers), new Network.RequestHeadersView.RequestHeadersView(request));
+ 'headers', i18nString(UIStrings.headers),
+ LegacyWrapper.LegacyWrapper.legacyWrapper(
+ UI.Widget.VBox, new NetworkComponents.RequestHeadersView.RequestHeadersView(request)));
this.tabbedPane.appendTab(
'preview', i18nString(UIStrings.preview), new Network.RequestPreviewView.RequestPreviewView(request));
this.tabbedPane.show(this.element);
diff --git a/front_end/panels/application/components/FrameDetailsView.ts b/front_end/panels/application/components/FrameDetailsView.ts
index 3978508..1104e7a 100644
--- a/front_end/panels/application/components/FrameDetailsView.ts
+++ b/front_end/panels/application/components/FrameDetailsView.ts
@@ -412,10 +412,8 @@
const request = resource.request;
return renderIconLink(
'arrow-up-down-circle', i18nString(UIStrings.clickToRevealInNetworkPanel), (): Promise<void> => {
- const headersTab = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES) ?
- NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent :
- NetworkForward.UIRequestLocation.UIRequestTabs.Headers;
- const requestLocation = NetworkForward.UIRequestLocation.UIRequestLocation.tab(request, headersTab);
+ const requestLocation = NetworkForward.UIRequestLocation.UIRequestLocation.tab(
+ request, NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent);
return Common.Revealer.reveal(requestLocation);
});
}
diff --git a/front_end/panels/issues/IssueView.ts b/front_end/panels/issues/IssueView.ts
index 2a0577a..67c68f7 100644
--- a/front_end/panels/issues/IssueView.ts
+++ b/front_end/panels/issues/IssueView.ts
@@ -6,7 +6,6 @@
import * as Host from '../../core/host/host.js';
import * as i18n from '../../core/i18n/i18n.js';
import type * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
import * as Protocol from '../../generated/protocol.js';
import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
import * as NetworkForward from '../../panels/network/forward/forward.js';
@@ -94,11 +93,8 @@
const element = document.createElement('tr');
element.classList.add('affected-resource-request');
const category = this.issue.getCategory();
- let tab = issueTypeToNetworkHeaderMap.get(category) || NetworkForward.UIRequestLocation.UIRequestTabs.Headers;
- if (tab === NetworkForward.UIRequestLocation.UIRequestTabs.Headers &&
- Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
- tab = NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent;
- }
+ const tab =
+ issueTypeToNetworkHeaderMap.get(category) || NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent;
element.appendChild(this.createRequestCell(affectedRequest, {
networkTab: tab,
additionalOnClickAction() {
@@ -141,11 +137,11 @@
],
[
IssuesManager.Issue.IssueCategory.CrossOriginEmbedderPolicy,
- NetworkForward.UIRequestLocation.UIRequestTabs.Headers,
+ NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent,
],
[
IssuesManager.Issue.IssueCategory.MixedContent,
- NetworkForward.UIRequestLocation.UIRequestTabs.Headers,
+ NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent,
],
]);
@@ -176,12 +172,8 @@
element.classList.add('affected-resource-mixed-content');
if (mixedContent.request) {
- let networkTab = issueTypeToNetworkHeaderMap.get(this.issue.getCategory()) ||
- NetworkForward.UIRequestLocation.UIRequestTabs.Headers;
- if (networkTab === NetworkForward.UIRequestLocation.UIRequestTabs.Headers &&
- Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
- networkTab = NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent;
- }
+ const networkTab = issueTypeToNetworkHeaderMap.get(this.issue.getCategory()) ||
+ NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent;
element.appendChild(this.createRequestCell(mixedContent.request, {
networkTab,
additionalOnClickAction() {
diff --git a/front_end/panels/network/BUILD.gn b/front_end/panels/network/BUILD.gn
index a4ca4c9..8a9581e 100644
--- a/front_end/panels/network/BUILD.gn
+++ b/front_end/panels/network/BUILD.gn
@@ -21,7 +21,6 @@
"requestCookiesView.css",
"requestHTMLView.css",
"requestHeadersTree.css",
- "requestHeadersView.css",
"requestInitiatorView.css",
"requestInitiatorViewTree.css",
"requestPayloadTree.css",
@@ -51,7 +50,6 @@
"NetworkWaterfallColumn.ts",
"RequestCookiesView.ts",
"RequestHTMLView.ts",
- "RequestHeadersView.ts",
"RequestInitiatorView.ts",
"RequestPayloadView.ts",
"RequestPreviewView.ts",
diff --git a/front_end/panels/network/NetworkDataGridNode.ts b/front_end/panels/network/NetworkDataGridNode.ts
index fe1e87b..d9e5e54 100644
--- a/front_end/panels/network/NetworkDataGridNode.ts
+++ b/front_end/panels/network/NetworkDataGridNode.ts
@@ -1319,12 +1319,9 @@
if (displayShowHeadersLink) {
this.setTextAndTitleAsLink(
cell, i18nString(UIStrings.blockeds, {PH1: reason}), i18nString(UIStrings.blockedTooltip), () => {
- const tab = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES) ?
- NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent :
- NetworkForward.UIRequestLocation.UIRequestTabs.Headers;
this.parentView().dispatchEventToListeners(Events.RequestActivated, {
showPanel: true,
- tab,
+ tab: NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent,
});
});
} else {
diff --git a/front_end/panels/network/NetworkItemView.ts b/front_end/panels/network/NetworkItemView.ts
index c6106c3..74d6df2 100644
--- a/front_end/panels/network/NetworkItemView.ts
+++ b/front_end/panels/network/NetworkItemView.ts
@@ -30,7 +30,6 @@
import * as Common from '../../core/common/common.js';
import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as NetworkForward from '../../panels/network/forward/forward.js';
import * as IconButton from '../../ui/components/icon_button/icon_button.js';
@@ -42,7 +41,6 @@
import {EventSourceMessagesView} from './EventSourceMessagesView.js';
import {type NetworkTimeCalculator} from './NetworkTimeCalculator.js';
import {RequestCookiesView} from './RequestCookiesView.js';
-import {RequestHeadersView} from './RequestHeadersView.js';
import {RequestInitiatorView} from './RequestInitiatorView.js';
import {RequestPayloadView} from './RequestPayloadView.js';
import {RequestPreviewView} from './RequestPreviewView.js';
@@ -141,7 +139,6 @@
export class NetworkItemView extends UI.TabbedPane.TabbedPane {
private requestInternal: SDK.NetworkRequest.NetworkRequest;
private readonly resourceViewTabSetting: Common.Settings.Setting<NetworkForward.UIRequestLocation.UIRequestTabs>;
- private readonly headersView: RequestHeadersView;
private readonly headersViewComponent: NetworkComponents.RequestHeadersView.RequestHeadersView;
private payloadView: RequestPayloadView|null;
private readonly responseView: RequestResponseView|undefined;
@@ -155,28 +152,22 @@
this.requestInternal = request;
this.element.classList.add('network-item-view');
- const headersTab = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES) ?
- NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent :
- NetworkForward.UIRequestLocation.UIRequestTabs.Headers;
- this.resourceViewTabSetting = Common.Settings.Settings.instance().createSetting('resourceViewTab', headersTab);
+ const headersTab = NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent;
+ this.resourceViewTabSetting = Common.Settings.Settings.instance().createSetting(
+ 'resourceViewTab', NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent);
- this.headersView = new RequestHeadersView(request);
this.headersViewComponent = new NetworkComponents.RequestHeadersView.RequestHeadersView(request);
- if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
- this.appendTab(
- headersTab, i18nString(UIStrings.headers),
- LegacyWrapper.LegacyWrapper.legacyWrapper(UI.Widget.VBox, this.headersViewComponent),
- i18nString(UIStrings.headers));
+ this.appendTab(
+ headersTab, i18nString(UIStrings.headers),
+ LegacyWrapper.LegacyWrapper.legacyWrapper(UI.Widget.VBox, this.headersViewComponent),
+ i18nString(UIStrings.headers));
- if (this.requestInternal.hasOverriddenHeaders()) {
- const icon = new IconButton.Icon.Icon();
- icon.data =
- {iconName: 'small-status-dot', color: 'var(--sys-color-purple-bright)', width: '16px', height: '16px'};
- icon.title = i18nString(UIStrings.containsOverriddenHeaders);
- this.setTabIcon(NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent, icon);
- }
- } else {
- this.appendTab(headersTab, i18nString(UIStrings.headers), this.headersView, i18nString(UIStrings.headers));
+ if (this.requestInternal.hasOverriddenHeaders()) {
+ const icon = new IconButton.Icon.Icon();
+ icon.data =
+ {iconName: 'small-status-dot', color: 'var(--sys-color-purple-bright)', width: '16px', height: '16px'};
+ icon.title = i18nString(UIStrings.containsOverriddenHeaders);
+ this.setTabIcon(NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent, icon);
}
this.payloadView = null;
@@ -340,17 +331,8 @@
}
revealHeader(section: NetworkForward.UIRequestLocation.UIHeaderSection, header: string|undefined): void {
- if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
- this.selectTabInternal(NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent);
- this.headersViewComponent.revealHeader(section, header);
- } else {
- this.selectTabInternal(NetworkForward.UIRequestLocation.UIRequestTabs.Headers);
- this.headersView.revealHeader(section, header);
- }
- }
-
- getHeadersView(): RequestHeadersView {
- return this.headersView;
+ this.selectTabInternal(NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent);
+ this.headersViewComponent.revealHeader(section, header);
}
getHeadersViewComponent(): NetworkComponents.RequestHeadersView.RequestHeadersView {
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts
index 4125e6d..9e34c42 100644
--- a/front_end/panels/network/NetworkLogView.ts
+++ b/front_end/panels/network/NetworkLogView.ts
@@ -1750,10 +1750,8 @@
footerSection.appendItem(i18nString(UIStrings.copyAllAsHar), this.copyAll.bind(this));
contextMenu.saveSection().appendItem(i18nString(UIStrings.saveAllAsHarWithContent), this.exportAll.bind(this));
- if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
- contextMenu.overrideSection().appendItem(
- i18nString(UIStrings.overrideHeaders), this.#handleCreateResponseHeaderOverrideClick.bind(this, request));
- }
+ contextMenu.overrideSection().appendItem(
+ i18nString(UIStrings.overrideHeaders), this.#handleCreateResponseHeaderOverrideClick.bind(this, request));
contextMenu.editSection().appendItem(i18nString(UIStrings.clearBrowserCache), this.clearBrowserCache.bind(this));
contextMenu.editSection().appendItem(
diff --git a/front_end/panels/network/RequestHeadersView.ts b/front_end/panels/network/RequestHeadersView.ts
deleted file mode 100644
index 5b07aef..0000000
--- a/front_end/panels/network/RequestHeadersView.ts
+++ /dev/null
@@ -1,926 +0,0 @@
-// Copyright 2021 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/*
- * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
- * Copyright (C) IBM Corp. 2009 All rights reserved.
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
- * its contributors may be used to endorse or promote products derived
- * from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-import * as Common from '../../core/common/common.js';
-import * as Host from '../../core/host/host.js';
-import * as i18n from '../../core/i18n/i18n.js';
-import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
-import * as SDK from '../../core/sdk/sdk.js';
-import * as Protocol from '../../generated/protocol.js';
-import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
-import * as Persistence from '../../models/persistence/persistence.js';
-import * as Workspace from '../../models/workspace/workspace.js';
-import * as NetworkForward from '../../panels/network/forward/forward.js';
-import * as ClientVariations from '../../third_party/chromium/client-variations/client-variations.js';
-import * as IconButton from '../../ui/components/icon_button/icon_button.js';
-// eslint-disable-next-line rulesdir/es_modules_import
-import objectPropertiesSectionStyles from '../../ui/legacy/components/object_ui/objectPropertiesSection.css.js';
-// eslint-disable-next-line rulesdir/es_modules_import
-import objectValueStyles from '../../ui/legacy/components/object_ui/objectValue.css.js';
-import * as UI from '../../ui/legacy/legacy.js';
-import * as Sources from '../sources/sources.js';
-
-import requestHeadersTreeStyles from './requestHeadersTree.css.js';
-import requestHeadersViewStyles from './requestHeadersView.css.js';
-
-const UIStrings = {
- /**
- *@description Text in Request Headers View of the Network panel
- */
- general: 'General',
- /**
- *@description A context menu item in the Watch Expressions Sidebar Pane of the Sources panel and Network pane request.
- */
- copyValue: 'Copy value',
- /**
- *@description Text for a link to the issues panel
- */
- learnMoreInTheIssuesTab: 'Learn more in the issues tab',
- /**
- *@description Text that is usually a hyperlink to more documentation
- */
- learnMore: 'Learn more',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- requestUrl: 'Request URL',
- /**
- *@description Text to show more content
- */
- showMore: 'Show more',
- /**
- *@description Text for toggling the view of header data (e.g. query string parameters) from source to parsed in the headers tab
- */
- viewParsed: 'View parsed',
- /**
- *@description Text for toggling the view of header data (e.g. query string parameters) from parsed to source in the headers tab
- */
- viewSource: 'View source',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- requestHeaders: 'Request Headers',
- /**
- *@description A context menu item in the Network Log View Columns of the Network panel
- */
- responseHeaders: 'Response Headers',
- /**
- *@description Status code of an event
- */
- statusCode: 'Status Code',
- /**
- *@description Text that refers to the network request method
- */
- requestMethod: 'Request Method',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- fromMemoryCache: '(from memory cache)',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- fromServiceWorker: '(from `service worker`)',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- fromSignedexchange: '(from signed-exchange)',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- fromPrefetchCache: '(from prefetch cache)',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- fromDiskCache: '(from disk cache)',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- fromWebBundle: '(from Web Bundle)',
- /**
- *@description Message to explain lack of raw headers for a particular network request
- */
- provisionalHeadersAreShownS: 'Provisional headers are shown. Disable cache to see full headers.',
- /**
- *@description Tooltip to explain lack of raw headers for a particular network request
- */
- onlyProvisionalHeadersAre:
- 'Only provisional headers are available because this request was not sent over the network and instead was served from a local cache, which doesn’t store the original request headers. Disable cache to see full request headers.',
- /**
- *@description Message to explain lack of raw headers for a particular network request
- */
- provisionalHeadersAreShown: 'Provisional headers are shown',
- /**
- *@description Comment used in decoded X-Client-Data HTTP header output in Headers View of the Network panel
- */
- activeClientExperimentVariation: 'Active `client experiment variation IDs`.',
- /**
- *@description Comment used in decoded X-Client-Data HTTP header output in Headers View of the Network panel
- */
- activeClientExperimentVariationIds: 'Active `client experiment variation IDs` that trigger server-side behavior.',
- /**
- *@description Text in Headers View of the Network panel for X-Client-Data HTTP headers
- */
- decoded: 'Decoded:',
- /**
- *@description Text in Network Log View Columns of the Network panel
- */
- remoteAddress: 'Remote Address',
- /**
- *@description Text in Request Headers View of the Network panel
- */
- referrerPolicy: 'Referrer Policy',
- /**
- *@description Text in Headers View of the Network panel
- */
- toEmbedThisFrameInYourDocument:
- 'To embed this frame in your document, the response needs to enable the cross-origin embedder policy by specifying the following response header:',
- /**
- *@description Text in Headers View of the Network panel
- */
- toUseThisResourceFromADifferent:
- 'To use this resource from a different origin, the server needs to specify a cross-origin resource policy in the response headers:',
- /**
- *@description Text in Headers View of the Network panel
- */
- chooseThisOptionIfTheResourceAnd:
- 'Choose this option if the resource and the document are served from the same site.',
- /**
- *@description Text in Headers View of the Network panel
- */
- onlyChooseThisOptionIfAn:
- 'Only choose this option if an arbitrary website including this resource does not impose a security risk.',
- /**
- *@description Text in Headers View of the Network panel
- */
- thisDocumentWasBlockedFrom:
- 'The document was blocked from loading in a popup opened by a sandboxed iframe because this document specified a cross-origin opener policy.',
- /**
- *@description Text in Headers View of the Network panel
- */
- toUseThisResourceFromADifferentSite:
- 'To use this resource from a different site, the server may relax the cross-origin resource policy response header:',
- /**
- *@description Text in Headers View of the Network panel
- */
- toUseThisResourceFromADifferentOrigin:
- 'To use this resource from a different origin, the server may relax the cross-origin resource policy response header:',
-};
-const str_ = i18n.i18n.registerUIStrings('panels/network/RequestHeadersView.ts', UIStrings);
-const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
-export class RequestHeadersView extends UI.Widget.VBox {
- private request: SDK.NetworkRequest.NetworkRequest;
- private showRequestHeadersText: boolean;
- private showResponseHeadersText: boolean;
- private highlightedElement: UI.TreeOutline.TreeElement|null;
- private readonly root: Category;
- private urlItem: UI.TreeOutline.TreeElement;
- private readonly requestMethodItem: UI.TreeOutline.TreeElement;
- private readonly statusCodeItem: UI.TreeOutline.TreeElement;
- private readonly remoteAddressItem: UI.TreeOutline.TreeElement;
- private readonly referrerPolicyItem: UI.TreeOutline.TreeElement;
- readonly responseHeadersCategory: Category;
- private readonly requestHeadersCategory: Category;
- readonly #workspace = Workspace.Workspace.WorkspaceImpl.instance();
-
- constructor(request: SDK.NetworkRequest.NetworkRequest) {
- super();
-
- this.element.classList.add('request-headers-view');
-
- this.request = request;
- this.showRequestHeadersText = false;
- this.showResponseHeadersText = false;
-
- this.highlightedElement = null;
-
- const root = new UI.TreeOutline.TreeOutlineInShadow();
- root.registerCSSFiles([objectValueStyles, objectPropertiesSectionStyles, requestHeadersTreeStyles]);
-
- root.element.classList.add('request-headers-tree');
- root.makeDense();
- root.setUseLightSelectionColor(true);
- this.element.appendChild(root.element);
-
- const generalCategory = new Category(root, 'general', i18nString(UIStrings.general));
- generalCategory.hidden = false;
- this.root = generalCategory;
- this.setDefaultFocusedElement(this.root.listItemElement);
- this.urlItem = generalCategory.createLeaf();
- this.requestMethodItem = generalCategory.createLeaf();
- headerNames.set(this.requestMethodItem, 'Request-Method');
- this.statusCodeItem = generalCategory.createLeaf();
- headerNames.set(this.statusCodeItem, 'Status-Code');
- this.remoteAddressItem = generalCategory.createLeaf();
- this.remoteAddressItem.hidden = true;
- this.referrerPolicyItem = generalCategory.createLeaf();
- this.referrerPolicyItem.hidden = true;
-
- this.responseHeadersCategory = new Category(root, 'responseHeaders', '');
- this.requestHeadersCategory = new Category(root, 'requestHeaders', '');
- }
-
- override wasShown(): void {
- this.clearHighlight();
- this.registerCSSFiles([requestHeadersViewStyles]);
- this.request.addEventListener(SDK.NetworkRequest.Events.RemoteAddressChanged, this.refreshRemoteAddress, this);
- this.request.addEventListener(SDK.NetworkRequest.Events.RequestHeadersChanged, this.refreshRequestHeaders, this);
- this.request.addEventListener(SDK.NetworkRequest.Events.ResponseHeadersChanged, this.refreshResponseHeaders, this);
- this.request.addEventListener(SDK.NetworkRequest.Events.FinishedLoading, this.refreshHTTPInformation, this);
- this.#workspace.addEventListener(
- Workspace.Workspace.Events.UISourceCodeAdded, this.#uiSourceCodeAddedOrRemoved, this);
- this.#workspace.addEventListener(
- Workspace.Workspace.Events.UISourceCodeRemoved, this.#uiSourceCodeAddedOrRemoved, this);
-
- this.refreshURL();
- this.refreshRequestHeaders();
- this.refreshResponseHeaders();
- this.refreshHTTPInformation();
- this.refreshRemoteAddress();
- this.refreshReferrerPolicy();
- this.root.select(/* omitFocus */ true, /* selectedByUser */ false);
- }
-
- override willHide(): void {
- this.request.removeEventListener(SDK.NetworkRequest.Events.RemoteAddressChanged, this.refreshRemoteAddress, this);
- this.request.removeEventListener(SDK.NetworkRequest.Events.RequestHeadersChanged, this.refreshRequestHeaders, this);
- this.request.removeEventListener(
- SDK.NetworkRequest.Events.ResponseHeadersChanged, this.refreshResponseHeaders, this);
- this.request.removeEventListener(SDK.NetworkRequest.Events.FinishedLoading, this.refreshHTTPInformation, this);
- this.#workspace.removeEventListener(
- Workspace.Workspace.Events.UISourceCodeAdded, this.#uiSourceCodeAddedOrRemoved, this);
- this.#workspace.removeEventListener(
- Workspace.Workspace.Events.UISourceCodeRemoved, this.#uiSourceCodeAddedOrRemoved, this);
- }
-
- private addEntryContextMenuHandler(treeElement: UI.TreeOutline.TreeElement, value: string): void {
- treeElement.listItemElement.addEventListener('contextmenu', event => {
- event.consume(true);
- const contextMenu = new UI.ContextMenu.ContextMenu(event);
- const decodedValue = decodeURIComponent(value);
- const copyDecodedValueHandler = (): void => {
- Host.userMetrics.actionTaken(Host.UserMetrics.Action.NetworkPanelCopyValue);
- Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText(decodedValue);
- };
- contextMenu.clipboardSection().appendItem(i18nString(UIStrings.copyValue), copyDecodedValueHandler);
- void contextMenu.show();
- });
- }
-
- private formatHeader(name: string, value: string): DocumentFragment {
- const fragment = document.createDocumentFragment();
- fragment.createChild('div', 'header-name').textContent = name + ': ';
- fragment.createChild('span', 'header-separator');
- fragment.createChild('div', 'header-value source-code').textContent = value;
-
- return fragment;
- }
-
- private formatHeaderObject(header: BlockedReasonDetailDescriptor): DocumentFragment {
- const fragment = document.createDocumentFragment();
- if (header.headerNotSet) {
- fragment.createChild('div', 'header-badge header-badge-text').textContent = 'not-set';
- }
- const colon = header.value ? ': ' : '';
- fragment.createChild('div', 'header-name').textContent = header.name + colon;
- fragment.createChild('span', 'header-separator');
- if (header.value) {
- if (header.headerValueIncorrect) {
- fragment.createChild('div', 'header-value source-code header-warning').textContent = header.value.toString();
- } else {
- fragment.createChild('div', 'header-value source-code').textContent = header.value.toString();
- }
- }
- if (header.details) {
- const detailsNode = fragment.createChild('div', 'header-details');
- const callToAction = detailsNode.createChild('div', 'call-to-action');
- const callToActionBody = callToAction.createChild('div', 'call-to-action-body');
- callToActionBody.createChild('div', 'explanation').textContent = header.details.explanation();
- for (const example of header.details.examples) {
- const exampleNode = callToActionBody.createChild('div', 'example');
- exampleNode.createChild('code').textContent = example.codeSnippet;
- if (example.comment) {
- exampleNode.createChild('span', 'comment').textContent = example.comment();
- }
- }
-
- if (IssuesManager.RelatedIssue.hasIssueOfCategory(
- this.request, IssuesManager.Issue.IssueCategory.CrossOriginEmbedderPolicy)) {
- const link = document.createElement('div');
- link.classList.add('devtools-link');
- link.onclick = (): void => {
- Host.userMetrics.issuesPanelOpenedFrom(Host.UserMetrics.IssueOpener.LearnMoreLinkCOEP);
- void IssuesManager.RelatedIssue.reveal(
- this.request, IssuesManager.Issue.IssueCategory.CrossOriginEmbedderPolicy);
- };
- const text = document.createElement('span');
- text.classList.add('devtools-link');
- text.textContent = i18nString(UIStrings.learnMoreInTheIssuesTab);
- link.appendChild(text);
- const issueIcon = new IconButton.Icon.Icon();
- issueIcon.data = {
- iconName: 'issue-exclamation-filled',
- color: 'var(--icon-warning)',
- width: '20px',
- height: '20px',
- };
- link.prepend(issueIcon);
- callToActionBody.appendChild(link);
- } else if (header.details.link) {
- const link = UI.XLink.XLink.create(header.details.link.url, i18nString(UIStrings.learnMore), 'link');
- const icon = new IconButton.Icon.Icon();
- icon.data = {
- iconName: 'open-externally',
- color: 'var(--icon-default)',
- width: '20px',
- height: '20px',
- };
- link.prepend(icon);
- callToActionBody.appendChild(link);
- }
- }
- return fragment;
- }
-
- private refreshURL(): void {
- const requestURL = this.request.url();
- this.urlItem.title = this.formatHeader(i18nString(UIStrings.requestUrl), requestURL);
- this.addEntryContextMenuHandler(this.urlItem, requestURL);
- }
-
- private populateTreeElementWithSourceText(treeElement: UI.TreeOutline.TreeElement, sourceText: string|null): void {
- // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
- // eslint-disable-next-line @typescript-eslint/naming-convention
- const max_len = 3000;
- const text = (sourceText || '').trim();
- const trim = text.length > max_len;
-
- const sourceTextElement = document.createElement('span');
- sourceTextElement.classList.add('header-value');
- sourceTextElement.classList.add('source-code');
- sourceTextElement.textContent = trim ? text.substr(0, max_len) : text;
-
- const sourceTreeElement = new UI.TreeOutline.TreeElement(sourceTextElement);
- treeElement.removeChildren();
- treeElement.appendChild(sourceTreeElement);
- if (!trim) {
- return;
- }
-
- const showMoreButton = document.createElement('button');
- showMoreButton.classList.add('request-headers-show-more-button');
- showMoreButton.textContent = i18nString(UIStrings.showMore);
-
- function showMore(): void {
- showMoreButton.remove();
- sourceTextElement.textContent = text;
- sourceTreeElement.listItemElement.removeEventListener('contextmenu', onContextMenuShowMore);
- }
- showMoreButton.addEventListener('click', showMore);
-
- function onContextMenuShowMore(event: Event): void {
- const contextMenu = new UI.ContextMenu.ContextMenu(event);
- const section = contextMenu.newSection();
- section.appendItem(i18nString(UIStrings.showMore), showMore);
- void contextMenu.show();
- }
- sourceTreeElement.listItemElement.addEventListener('contextmenu', onContextMenuShowMore);
- sourceTextElement.appendChild(showMoreButton);
- }
-
- private refreshRequestHeaders(): void {
- const treeElement = this.requestHeadersCategory;
- const headers = this.request.requestHeaders().slice();
- headers.sort(function(a, b) {
- return Platform.StringUtilities.compare(a.name.toLowerCase(), b.name.toLowerCase());
- });
- const headersText = this.request.requestHeadersText();
-
- if (this.showRequestHeadersText && headersText) {
- this.refreshHeadersText(i18nString(UIStrings.requestHeaders), headers.length, headersText, treeElement);
- } else {
- this.refreshHeaders(
- i18nString(UIStrings.requestHeaders), headers, treeElement, /* overrideable */ false,
- headersText === undefined);
- }
-
- if (headersText) {
- const toggleButton = this.createHeadersToggleButton(this.showRequestHeadersText);
- toggleButton.addEventListener('click', this.toggleRequestHeadersText.bind(this), false);
- treeElement.listItemElement.querySelector('.headers-title-left')?.appendChild(toggleButton);
- }
- }
-
- private refreshResponseHeaders(): void {
- const treeElement = this.responseHeadersCategory;
- const headers = this.request.sortedResponseHeaders.slice();
- const headersText = this.request.responseHeadersText;
-
- if (this.showResponseHeadersText) {
- this.refreshHeadersText(i18nString(UIStrings.responseHeaders), headers.length, headersText, treeElement);
- } else {
- const headersWithIssues = [];
- if (this.request.wasBlocked()) {
- const headerWithIssues =
- BlockedReasonDetails.get((this.request.blockedReason() as Protocol.Network.BlockedReason));
- if (headerWithIssues) {
- headersWithIssues.push(headerWithIssues);
- }
- }
- const overrideable = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES);
- this.refreshHeaders(
- i18nString(UIStrings.responseHeaders), mergeHeadersWithIssues(headers, headersWithIssues), treeElement,
- overrideable,
- /* provisional */ false, this.request.blockedResponseCookies());
- }
-
- if (headersText) {
- const toggleButton = this.createHeadersToggleButton(this.showResponseHeadersText);
- toggleButton.addEventListener('click', this.toggleResponseHeadersText.bind(this), false);
- treeElement.listItemElement.querySelector('.headers-title-left')?.appendChild(toggleButton);
- }
-
- // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
- // eslint-disable-next-line @typescript-eslint/no-explicit-any
- function mergeHeadersWithIssues(headers: any[], headersWithIssues: any[]): any[] {
- let i = 0, j = 0;
- const result = [];
- while (i < headers.length || j < headersWithIssues.length) {
- if (i < headers.length && (j >= headersWithIssues.length || headers[i].name < headersWithIssues[j].name)) {
- result.push({...headers[i++], headerNotSet: false});
- } else if (
- j < headersWithIssues.length && (i >= headers.length || headers[i].name > headersWithIssues[j].name)) {
- result.push({...headersWithIssues[j++], headerNotSet: true});
- } else if (
- i < headers.length && j < headersWithIssues.length && headers[i].name === headersWithIssues[j].name) {
- result.push({...headersWithIssues[j++], ...headers[i++], headerNotSet: false});
- }
- }
- return result;
- }
- }
-
- private refreshHTTPInformation(): void {
- const requestMethodElement = this.requestMethodItem;
- requestMethodElement.hidden = !this.request.statusCode;
- const statusCodeElement = this.statusCodeItem;
- statusCodeElement.hidden = !this.request.statusCode;
-
- if (this.request.statusCode) {
- const statusCodeFragment = document.createDocumentFragment();
- statusCodeFragment.createChild('div', 'header-name').textContent = i18nString(UIStrings.statusCode) + ': ';
- statusCodeFragment.createChild('span', 'header-separator');
-
- const statusCodeImage =
- (statusCodeFragment.createChild('span', 'resource-status-image', 'dt-icon-label') as
- UI.UIUtils.DevToolsIconLabel);
- UI.Tooltip.Tooltip.install(statusCodeImage, this.request.statusCode + ' ' + this.request.getInferredStatusText());
-
- if (this.request.statusCode < 300 || this.request.statusCode === 304) {
- statusCodeImage
- .data = {iconName: 'checkmark', color: 'var(--icon-checkmark-green)', width: '14px', height: '14px'};
- } else if (this.request.statusCode < 400) {
- statusCodeImage
- .data = {iconName: 'warning-filled', color: 'var(--icon-warning)', width: '14px', height: '14px'};
- } else {
- statusCodeImage
- .data = {iconName: 'cross-circle-filled', color: 'var(--icon-error)', width: '14px', height: '14px'};
- }
-
- requestMethodElement.title = this.formatHeader(i18nString(UIStrings.requestMethod), this.request.requestMethod);
-
- const statusTextElement = statusCodeFragment.createChild('div', 'header-value source-code');
- let statusText = this.request.statusCode + ' ' + this.request.getInferredStatusText();
- if (this.request.cachedInMemory()) {
- statusText += ' ' + i18nString(UIStrings.fromMemoryCache);
- statusTextElement.classList.add('status-from-cache');
- } else if (this.request.fetchedViaServiceWorker) {
- statusText += ' ' + i18nString(UIStrings.fromServiceWorker);
- statusTextElement.classList.add('status-from-cache');
- } else if (this.request.redirectSourceSignedExchangeInfoHasNoErrors()) {
- statusText += ' ' + i18nString(UIStrings.fromSignedexchange);
- statusTextElement.classList.add('status-from-cache');
- } else if (this.request.webBundleInnerRequestInfo()) {
- statusText += ' ' + i18nString(UIStrings.fromWebBundle);
- statusTextElement.classList.add('status-from-cache');
- } else if (this.request.fromPrefetchCache()) {
- statusText += ' ' + i18nString(UIStrings.fromPrefetchCache);
- statusTextElement.classList.add('status-from-cache');
- } else if (this.request.cached()) {
- statusText += ' ' + i18nString(UIStrings.fromDiskCache);
- statusTextElement.classList.add('status-from-cache');
- }
- statusTextElement.textContent = statusText;
-
- statusCodeElement.title = statusCodeFragment;
- }
- }
-
- private refreshHeadersTitle(
- title: string, headersTreeElement: UI.TreeOutline.TreeElement, headersLength: number,
- overrideable: boolean): void {
- headersTreeElement.listItemElement.removeChildren();
- headersTreeElement.listItemElement.createChild('div', 'selection fill');
- const container = headersTreeElement.listItemElement.createChild('div', 'headers-title');
- const leftElement = container.createChild('div', 'headers-title-left');
- UI.UIUtils.createTextChild(leftElement, title);
-
- const headerCount = `\xA0(${headersLength})`;
- leftElement.createChild('span', 'header-count').textContent = headerCount;
-
- if (overrideable && this.#workspace.uiSourceCodeForURL(this.#getHeaderOverridesFileUrl())) {
- const overridesSetting: Common.Settings.Setting<boolean> =
- Common.Settings.Settings.instance().moduleSetting('persistenceNetworkOverridesEnabled');
- const icon = new IconButton.Icon.Icon();
- icon.data = {iconName: 'document', color: 'var(--icon-default)', width: '16px', height: '16px'};
- if (overridesSetting.get()) {
- icon.classList.add('dot', 'purple');
- }
- const button = container.createChild('button', 'link devtools-link headers-link');
- button.appendChild(icon);
- button.addEventListener('click', this.#revealHeadersFile.bind(this));
- const span = document.createElement('span');
- span.textContent = Persistence.NetworkPersistenceManager.HEADERS_FILENAME;
- button.appendChild(span);
- }
- }
-
- #getHeaderOverridesFileUrl(): Platform.DevToolsPath.UrlString {
- const fileUrl = Persistence.NetworkPersistenceManager.NetworkPersistenceManager.instance().fileUrlFromNetworkUrl(
- this.request.url(), /* ignoreInactive */ true);
- return fileUrl.substring(0, fileUrl.lastIndexOf('/')) + '/' +
- Persistence.NetworkPersistenceManager.HEADERS_FILENAME as Platform.DevToolsPath.UrlString;
- }
-
- #revealHeadersFile(event: Event): void {
- event.stopPropagation();
- const uiSourceCode = this.#workspace.uiSourceCodeForURL(this.#getHeaderOverridesFileUrl());
- if (!uiSourceCode) {
- return;
- }
- Sources.SourcesPanel.SourcesPanel.instance().showUISourceCode(uiSourceCode);
- }
-
- #uiSourceCodeAddedOrRemoved(event: Common.EventTarget.EventTargetEvent<Workspace.UISourceCode.UISourceCode>): void {
- if (this.#getHeaderOverridesFileUrl() === event.data.url()) {
- this.refreshResponseHeaders();
- }
- }
-
- private refreshHeaders(
- title: string, headers: SDK.NetworkRequest.NameValue[], headersTreeElement: UI.TreeOutline.TreeElement,
- overrideable: boolean, provisionalHeaders?: boolean,
- blockedResponseCookies?: SDK.NetworkRequest.BlockedSetCookieWithReason[]): void {
- headersTreeElement.removeChildren();
-
- const length = headers.length;
- this.refreshHeadersTitle(title, headersTreeElement, length, overrideable);
-
- if (provisionalHeaders) {
- let cautionText;
- let cautionTitle = '';
- if (this.request.cachedInMemory() || this.request.cached()) {
- cautionText = i18nString(UIStrings.provisionalHeadersAreShownS);
- cautionTitle = i18nString(UIStrings.onlyProvisionalHeadersAre);
- } else {
- cautionText = i18nString(UIStrings.provisionalHeadersAreShown);
- }
- const cautionElement = document.createElement('div');
- cautionElement.classList.add('request-headers-caution');
- UI.Tooltip.Tooltip.install(cautionElement, cautionTitle);
- (cautionElement.createChild('span', '', 'dt-icon-label') as UI.UIUtils.DevToolsIconLabel)
- .data = {iconName: 'warning-filled', color: 'var(--icon-warning)', width: '14px', height: '14px'};
- cautionElement.createChild('div', 'caution').textContent = cautionText;
- const cautionTreeElement = new UI.TreeOutline.TreeElement(cautionElement);
-
- cautionElement.createChild('div', 'learn-more')
- .appendChild(UI.XLink.XLink.create(
- 'https://developer.chrome.com/docs/devtools/network/reference/#provisional-headers',
- i18nString(UIStrings.learnMore)));
-
- headersTreeElement.appendChild(cautionTreeElement);
- }
-
- const blockedCookieLineToReasons = new Map<string, Protocol.Network.SetCookieBlockedReason[]>();
- if (blockedResponseCookies) {
- blockedResponseCookies.forEach(blockedCookie => {
- blockedCookieLineToReasons.set(blockedCookie.cookieLine, blockedCookie.blockedReasons);
- });
- }
-
- headersTreeElement.hidden = !length && !provisionalHeaders;
- for (const header of headers) {
- // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
- // eslint-disable-next-line @typescript-eslint/no-explicit-any
- const headerTreeElement = new UI.TreeOutline.TreeElement(this.formatHeaderObject((header as any)));
- headerNames.set(headerTreeElement, header.name);
-
- const headerId = header.name.toLowerCase();
-
- if (headerId === 'set-cookie') {
- const matchingBlockedReasons = blockedCookieLineToReasons.get(header.value);
- if (matchingBlockedReasons) {
- const icon = new IconButton.Icon.Icon();
- icon.data = {iconName: 'warning-filled', color: 'var(--icon-warning)', width: '14px', height: '14px'};
- headerTreeElement.listItemElement.appendChild(icon);
-
- let titleText = '';
- for (const blockedReason of matchingBlockedReasons) {
- if (titleText) {
- titleText += '\n';
- }
- titleText += SDK.NetworkRequest.setCookieBlockedReasonToUiString(blockedReason);
- }
- UI.Tooltip.Tooltip.install(icon, titleText);
- }
- }
-
- this.addEntryContextMenuHandler(headerTreeElement, header.value);
- headersTreeElement.appendChild(headerTreeElement);
-
- if (headerId === 'x-client-data') {
- const data = ClientVariations.parseClientVariations(header.value);
- const output = ClientVariations.formatClientVariations(
- data, i18nString(UIStrings.activeClientExperimentVariation),
- i18nString(UIStrings.activeClientExperimentVariationIds));
- const wrapper = document.createElement('div');
- wrapper.classList.add('x-client-data-details');
- UI.UIUtils.createTextChild(wrapper, i18nString(UIStrings.decoded));
- const div = wrapper.createChild('div');
- div.classList.add('source-code');
- div.textContent = output;
- headerTreeElement.listItemElement.appendChild(wrapper);
- }
- }
- }
-
- private refreshHeadersText(
- title: string, count: number, headersText: string, headersTreeElement: UI.TreeOutline.TreeElement): void {
- this.populateTreeElementWithSourceText(headersTreeElement, headersText);
- this.refreshHeadersTitle(title, headersTreeElement, count, /* overrideable */ false);
- }
-
- private refreshRemoteAddress(): void {
- const remoteAddress = this.request.remoteAddress();
- const treeElement = this.remoteAddressItem;
- treeElement.hidden = !remoteAddress;
- if (remoteAddress) {
- treeElement.title = this.formatHeader(i18nString(UIStrings.remoteAddress), remoteAddress);
- }
- }
-
- private refreshReferrerPolicy(): void {
- const referrerPolicy = this.request.referrerPolicy();
- const treeElement = this.referrerPolicyItem;
- treeElement.hidden = !referrerPolicy;
- if (referrerPolicy) {
- treeElement.title = this.formatHeader(i18nString(UIStrings.referrerPolicy), referrerPolicy);
- }
- }
-
- private toggleRequestHeadersText(event: Event): void {
- this.showRequestHeadersText = !this.showRequestHeadersText;
- this.refreshRequestHeaders();
- event.consume();
- }
-
- private toggleResponseHeadersText(event: Event): void {
- this.showResponseHeadersText = !this.showResponseHeadersText;
- this.refreshResponseHeaders();
- event.consume();
- }
-
- private createToggleButton(title: string): Element {
- const button = document.createElement('span');
- button.classList.add('header-toggle');
- button.textContent = title;
- return button;
- }
-
- private createHeadersToggleButton(isHeadersTextShown: boolean): Element {
- const toggleTitle = isHeadersTextShown ? i18nString(UIStrings.viewParsed) : i18nString(UIStrings.viewSource);
- return this.createToggleButton(toggleTitle);
- }
-
- private clearHighlight(): void {
- if (this.highlightedElement) {
- this.highlightedElement.listItemElement.classList.remove('header-highlight');
- }
- this.highlightedElement = null;
- }
-
- private revealAndHighlight(category: UI.TreeOutline.TreeElement|null, name?: string): void {
- this.clearHighlight();
- if (!category) {
- return;
- }
- if (name) {
- for (const element of category.children()) {
- // HTTP headers are case insensitive.
- if (headerNames.get(element)?.toUpperCase() !== name.toUpperCase()) {
- continue;
- }
- this.highlightedElement = element;
- element.reveal();
- element.listItemElement.classList.add('header-highlight');
- return;
- }
- }
- // If there wasn't a match, reveal the first element of the category (without highlighting it).
- if (category.childCount() > 0) {
- category.childAt(0)?.reveal();
- }
- }
-
- private getCategoryForSection(section: NetworkForward.UIRequestLocation.UIHeaderSection): Category {
- switch (section) {
- case NetworkForward.UIRequestLocation.UIHeaderSection.General:
- return this.root;
- case NetworkForward.UIRequestLocation.UIHeaderSection.Request:
- return this.requestHeadersCategory;
- case NetworkForward.UIRequestLocation.UIHeaderSection.Response:
- return this.responseHeadersCategory;
- }
- }
-
- revealHeader(section: NetworkForward.UIRequestLocation.UIHeaderSection, header?: string): void {
- this.revealAndHighlight(this.getCategoryForSection(section), header);
- }
-}
-
-const headerNames = new WeakMap<UI.TreeOutline.TreeElement, string>();
-
-export class Category extends UI.TreeOutline.TreeElement {
- override toggleOnClick: boolean;
- private readonly expandedSetting: Common.Settings.Setting<boolean>;
- override expanded: boolean;
-
- constructor(root: UI.TreeOutline.TreeOutline, name: string, title?: string) {
- super(title || '', true);
- this.toggleOnClick = true;
- this.hidden = true;
- this.expandedSetting =
- Common.Settings.Settings.instance().createSetting('request-info-' + name + '-category-expanded', true);
- this.expanded = this.expandedSetting.get();
- root.appendChild(this);
- }
-
- createLeaf(): UI.TreeOutline.TreeElement {
- const leaf = new UI.TreeOutline.TreeElement();
- this.appendChild(leaf);
- return leaf;
- }
-
- override onexpand(): void {
- this.expandedSetting.set(true);
- }
-
- override oncollapse(): void {
- this.expandedSetting.set(false);
- }
-}
-
-interface BlockedReasonDetailDescriptor {
- name: string;
- value: Object|null;
- headerValueIncorrect: boolean|null;
- details: {
- explanation: () => string,
- examples: Array<{
- codeSnippet: string,
- comment?: (() => string),
- }>,
- link: {
- url: string,
- }|null,
- };
- headerNotSet: boolean|null;
-}
-
-const BlockedReasonDetails = new Map<Protocol.Network.BlockedReason, BlockedReasonDetailDescriptor>([
- [
- Protocol.Network.BlockedReason.CoepFrameResourceNeedsCoepHeader,
- {
- name: 'cross-origin-embedder-policy',
- value: null,
- headerValueIncorrect: null,
- details: {
- explanation: i18nLazyString(UIStrings.toEmbedThisFrameInYourDocument),
- examples: [{codeSnippet: 'Cross-Origin-Embedder-Policy: require-corp', comment: undefined}],
- link: {url: 'https://web.dev/coop-coep/'},
- },
- headerNotSet: null,
- },
- ],
- [
- Protocol.Network.BlockedReason.CorpNotSameOriginAfterDefaultedToSameOriginByCoep,
- {
- name: 'cross-origin-resource-policy',
- value: null,
- headerValueIncorrect: null,
- details: {
- explanation: i18nLazyString(UIStrings.toUseThisResourceFromADifferent),
- examples: [
- {
- codeSnippet: 'Cross-Origin-Resource-Policy: same-site',
- comment: i18nLazyString(UIStrings.chooseThisOptionIfTheResourceAnd),
- },
- {
- codeSnippet: 'Cross-Origin-Resource-Policy: cross-origin',
- comment: i18nLazyString(UIStrings.onlyChooseThisOptionIfAn),
- },
- ],
- link: {url: 'https://web.dev/coop-coep/'},
- },
- headerNotSet: null,
- },
- ],
- [
- Protocol.Network.BlockedReason.CoopSandboxedIframeCannotNavigateToCoopPage,
- {
- name: 'cross-origin-opener-policy',
- value: null,
- headerValueIncorrect: false,
- details: {
- explanation: i18nLazyString(UIStrings.thisDocumentWasBlockedFrom),
- examples: [],
- link: {url: 'https://web.dev/coop-coep/'},
- },
- headerNotSet: null,
- },
- ],
- [
- Protocol.Network.BlockedReason.CorpNotSameSite,
- {
- name: 'cross-origin-resource-policy',
- value: null,
- headerValueIncorrect: true,
- details: {
- explanation: i18nLazyString(UIStrings.toUseThisResourceFromADifferentSite),
- examples: [
- {
- codeSnippet: 'Cross-Origin-Resource-Policy: cross-origin',
- comment: i18nLazyString(UIStrings.onlyChooseThisOptionIfAn),
- },
- ],
- link: null,
- },
- headerNotSet: null,
- },
- ],
- [
- Protocol.Network.BlockedReason.CorpNotSameOrigin,
- {
- name: 'cross-origin-resource-policy',
- value: null,
- headerValueIncorrect: true,
- details: {
- explanation: i18nLazyString(UIStrings.toUseThisResourceFromADifferentOrigin),
- examples: [
- {
- codeSnippet: 'Cross-Origin-Resource-Policy: same-site',
- comment: i18nLazyString(UIStrings.chooseThisOptionIfTheResourceAnd),
- },
- {
- codeSnippet: 'Cross-Origin-Resource-Policy: cross-origin',
- comment: i18nLazyString(UIStrings.onlyChooseThisOptionIfAn),
- },
- ],
- link: null,
- },
- headerNotSet: null,
- },
- ],
-]);
diff --git a/front_end/panels/network/components/RequestHeadersView.ts b/front_end/panels/network/components/RequestHeadersView.ts
index d0b96f6..a3e3c6d 100644
--- a/front_end/panels/network/components/RequestHeadersView.ts
+++ b/front_end/panels/network/components/RequestHeadersView.ts
@@ -6,7 +6,6 @@
import * as Host from '../../../core/host/host.js';
import * as i18n from '../../../core/i18n/i18n.js';
import * as Platform from '../../../core/platform/platform.js';
-import * as Root from '../../../core/root/root.js';
import * as SDK from '../../../core/sdk/sdk.js';
import * as Persistence from '../../../models/persistence/persistence.js';
import * as Workspace from '../../../models/workspace/workspace.js';
@@ -233,8 +232,7 @@
}
#renderHeaderOverridesLink(): LitHtml.LitTemplate {
- const overrideable = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES);
- if (!overrideable || !this.#workspace.uiSourceCodeForURL(this.#getHeaderOverridesFileUrl())) {
+ if (!this.#workspace.uiSourceCodeForURL(this.#getHeaderOverridesFileUrl())) {
return LitHtml.nothing;
}
diff --git a/front_end/panels/network/components/ResponseHeaderSection.ts b/front_end/panels/network/components/ResponseHeaderSection.ts
index 2b85d06..90dd7b7 100644
--- a/front_end/panels/network/components/ResponseHeaderSection.ts
+++ b/front_end/panels/network/components/ResponseHeaderSection.ts
@@ -28,7 +28,6 @@
import * as Platform from '../../../core/platform/platform.js';
import * as Common from '../../../core/common/common.js';
import * as Buttons from '../../../ui/components/buttons/buttons.js';
-import * as Root from '../../../core/root/root.js';
import responseHeaderSectionStyles from './ResponseHeaderSection.css.js';
@@ -227,7 +226,7 @@
if (!this.#overrides.every(Persistence.NetworkPersistenceManager.isHeaderOverride)) {
throw 'Type mismatch after parsing';
}
- this.#headersAreOverrideable = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES) &&
+ this.#headersAreOverrideable =
Common.Settings.Settings.instance().moduleSetting('persistenceNetworkOverridesEnabled').get();
for (const header of this.#headerEditors) {
header.valueEditable = this.#headersAreOverrideable;
diff --git a/front_end/panels/network/forward/UIRequestLocation.ts b/front_end/panels/network/forward/UIRequestLocation.ts
index ee3997c..5831b56 100644
--- a/front_end/panels/network/forward/UIRequestLocation.ts
+++ b/front_end/panels/network/forward/UIRequestLocation.ts
@@ -23,7 +23,6 @@
export enum UIRequestTabs {
Cookies = 'cookies',
EventSource = 'eventSource',
- Headers = 'headers',
HeadersComponent = 'headersComponent',
Payload = 'payload',
Initiator = 'initiator',
diff --git a/front_end/panels/network/network.ts b/front_end/panels/network/network.ts
index dcdbc5a..ad9ab69 100644
--- a/front_end/panels/network/network.ts
+++ b/front_end/panels/network/network.ts
@@ -16,7 +16,6 @@
import './NetworkSearchScope.js';
import './NetworkWaterfallColumn.js';
import './RequestCookiesView.js';
-import './RequestHeadersView.js';
import './RequestHTMLView.js';
import './RequestInitiatorView.js';
import './RequestResponseView.js';
@@ -43,7 +42,6 @@
import * as NetworkTimeCalculator from './NetworkTimeCalculator.js';
import * as NetworkWaterfallColumn from './NetworkWaterfallColumn.js';
import * as RequestCookiesView from './RequestCookiesView.js';
-import * as RequestHeadersView from './RequestHeadersView.js';
import * as RequestHTMLView from './RequestHTMLView.js';
import * as RequestInitiatorView from './RequestInitiatorView.js';
import * as RequestPayloadView from './RequestPayloadView.js';
@@ -70,7 +68,6 @@
NetworkTimeCalculator,
NetworkWaterfallColumn,
RequestCookiesView,
- RequestHeadersView,
RequestHTMLView,
RequestInitiatorView,
RequestPayloadView,
diff --git a/front_end/panels/network/requestHeadersView.css b/front_end/panels/network/requestHeadersView.css
deleted file mode 100644
index 4e39a58..0000000
--- a/front_end/panels/network/requestHeadersView.css
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * Copyright (c) 2014 The Chromium Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-.request-headers-view {
- user-select: text;
- overflow: auto;
-}
-
-.resource-status-image {
- margin-top: -2px;
- margin-right: 3px;
-}
-
-.request-headers-tree {
- flex-grow: 1;
- overflow-y: auto;
- margin: 0;
- background-color: var(--sys-color-cdt-base-container);
-}
diff --git a/front_end/panels/sources/SourcesView.ts b/front_end/panels/sources/SourcesView.ts
index 22d3279..13e2472 100644
--- a/front_end/panels/sources/SourcesView.ts
+++ b/front_end/panels/sources/SourcesView.ts
@@ -6,7 +6,6 @@
import * as Host from '../../core/host/host.js';
import * as i18n from '../../core/i18n/i18n.js';
import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as Bindings from '../../models/bindings/bindings.js';
import * as Persistence from '../../models/persistence/persistence.js';
@@ -380,9 +379,7 @@
sourceView = new SourceFrame.ImageView.ImageView(uiSourceCode.mimeType(), uiSourceCode);
} else if (contentType === Common.ResourceType.resourceTypes.Font) {
sourceView = new SourceFrame.FontView.FontView(uiSourceCode.mimeType(), uiSourceCode);
- } else if (
- uiSourceCode.name() === HEADER_OVERRIDES_FILENAME &&
- Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
+ } else if (uiSourceCode.name() === HEADER_OVERRIDES_FILENAME) {
sourceView = new Components.HeadersView.HeadersView(uiSourceCode);
} else {
sourceFrame = new UISourceCodeFrame(uiSourceCode);
@@ -413,8 +410,7 @@
}
#sourceViewTypeForUISourceCode(uiSourceCode: Workspace.UISourceCode.UISourceCode): SourceViewType {
- if (uiSourceCode.name() === HEADER_OVERRIDES_FILENAME &&
- Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES)) {
+ if (uiSourceCode.name() === HEADER_OVERRIDES_FILENAME) {
return SourceViewType.HeadersView;
}
const contentType = uiSourceCode.contentType();
diff --git a/front_end/ui/components/request_link_icon/RequestLinkIcon.ts b/front_end/ui/components/request_link_icon/RequestLinkIcon.ts
index c099fcf..27b7779 100644
--- a/front_end/ui/components/request_link_icon/RequestLinkIcon.ts
+++ b/front_end/ui/components/request_link_icon/RequestLinkIcon.ts
@@ -5,7 +5,6 @@
import * as Common from '../../../core/common/common.js';
import * as i18n from '../../../core/i18n/i18n.js';
import type * as Platform from '../../../core/platform/platform.js';
-import * as Root from '../../../core/root/root.js';
import type * as SDK from '../../../core/sdk/sdk.js';
import type * as Protocol from '../../../generated/protocol.js';
import type * as Logs from '../../../models/logs/logs.js';
@@ -158,11 +157,8 @@
linkedRequest, this.#highlightHeader.section, this.#highlightHeader.name);
void this.#reveal(requestLocation);
} else {
- const headersTab = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.HEADER_OVERRIDES) ?
- NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent :
- NetworkForward.UIRequestLocation.UIRequestTabs.Headers;
- const requestLocation =
- NetworkForward.UIRequestLocation.UIRequestLocation.tab(linkedRequest, this.#networkTab ?? headersTab);
+ const requestLocation = NetworkForward.UIRequestLocation.UIRequestLocation.tab(
+ linkedRequest, this.#networkTab ?? NetworkForward.UIRequestLocation.UIRequestTabs.HeadersComponent);
void this.#reveal(requestLocation);
}
this.#additionalOnClickAction?.();
