[Global] Update refs to Common.settings
Bug: 1006759
Change-Id: Ie1943b50ba8ba23fae4f52f958ae6f8c7b6a7d3f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016744
Reviewed-by: Tim van der Lippe <[email protected]>
Commit-Queue: Paul Lewis <[email protected]>
diff --git a/front_end/console/ConsolePinPane.js b/front_end/console/ConsolePinPane.js
index 9599185..7170226 100644
--- a/front_end/console/ConsolePinPane.js
+++ b/front_end/console/ConsolePinPane.js
@@ -18,7 +18,7 @@
/** @type {!Set<!ConsolePin>} */
this._pins = new Set();
- this._pinsSetting = Common.settings.createLocalSetting('consolePins', []);
+ this._pinsSetting = self.Common.settings.createLocalSetting('consolePins', []);
for (const expression of this._pinsSetting.get()) {
this.addPin(expression);
}
diff --git a/front_end/console/ConsolePrompt.js b/front_end/console/ConsolePrompt.js
index 4b49a8b..0d2cb7a 100644
--- a/front_end/console/ConsolePrompt.js
+++ b/front_end/console/ConsolePrompt.js
@@ -28,7 +28,7 @@
this.element.appendChild(this._promptIcon);
this._iconThrottler = new Common.Throttler(0);
- this._eagerEvalSetting = Common.settings.moduleSetting('consoleEagerEval');
+ this._eagerEvalSetting = self.Common.settings.moduleSetting('consoleEagerEval');
this._eagerEvalSetting.addChangeListener(this._eagerSettingChanged.bind(this));
this._eagerPreviewElement.classList.toggle('hidden', !this._eagerEvalSetting.get());
diff --git a/front_end/console/ConsoleSidebar.js b/front_end/console/ConsoleSidebar.js
index 1e319ab..22e37da 100644
--- a/front_end/console/ConsoleSidebar.js
+++ b/front_end/console/ConsoleSidebar.js
@@ -18,7 +18,7 @@
this._selectedTreeElement = null;
/** @type {!Array<!FilterTreeElement>} */
this._treeElements = [];
- const selectedFilterSetting = Common.settings.createSetting('console.sidebarSelectedFilter', null);
+ const selectedFilterSetting = self.Common.settings.createSetting('console.sidebarSelectedFilter', null);
const Levels = SDK.ConsoleMessage.MessageLevel;
const consoleAPIParsedFilters =
diff --git a/front_end/console/ConsoleView.js b/front_end/console/ConsoleView.js
index 113ca4d..54d8ff1 100644
--- a/front_end/console/ConsoleView.js
+++ b/front_end/console/ConsoleView.js
@@ -95,11 +95,11 @@
this._filterStatusText = new UI.ToolbarText();
this._filterStatusText.element.classList.add('dimmed');
- this._showSettingsPaneSetting = Common.settings.createSetting('consoleShowSettingsToolbar', false);
+ this._showSettingsPaneSetting = self.Common.settings.createSetting('consoleShowSettingsToolbar', false);
this._showSettingsPaneButton = new UI.ToolbarSettingToggle(
this._showSettingsPaneSetting, 'largeicon-settings-gear', Common.UIString('Console settings'));
this._progressToolbarItem = new UI.ToolbarItem(createElement('div'));
- this._groupSimilarSetting = Common.settings.moduleSetting('consoleGroupSimilar');
+ this._groupSimilarSetting = self.Common.settings.moduleSetting('consoleGroupSimilar');
this._groupSimilarSetting.addChangeListener(() => this._updateMessageList());
const groupSimilarToggle =
new UI.ToolbarSettingCheckbox(this._groupSimilarSetting, Common.UIString('Group similar'));
@@ -154,11 +154,11 @@
settingsToolbarRight.makeVertical();
settingsToolbarRight.appendToolbarItem(new UI.ToolbarSettingCheckbox(monitoringXHREnabledSetting));
const eagerEvalCheckbox = new UI.ToolbarSettingCheckbox(
- Common.settings.moduleSetting('consoleEagerEval'), ls`Eagerly evaluate text in the prompt`);
+ self.Common.settings.moduleSetting('consoleEagerEval'), ls`Eagerly evaluate text in the prompt`);
settingsToolbarRight.appendToolbarItem(eagerEvalCheckbox);
settingsToolbarRight.appendToolbarItem(new UI.ToolbarSettingCheckbox(this._consoleHistoryAutocompleteSetting));
const userGestureCheckbox =
- new UI.ToolbarSettingCheckbox(Common.settings.moduleSetting('consoleUserActivationEval'));
+ new UI.ToolbarSettingCheckbox(self.Common.settings.moduleSetting('consoleUserActivationEval'));
settingsToolbarRight.appendToolbarItem(userGestureCheckbox);
if (!this._showSettingsPaneSetting.get()) {
settingsPane.element.classList.add('hidden');
@@ -214,7 +214,7 @@
this._consoleMessages = [];
this._viewMessageSymbol = Symbol('viewMessage');
- this._consoleHistorySetting = Common.settings.createLocalSetting('consoleHistory', []);
+ this._consoleHistorySetting = self.Common.settings.createLocalSetting('consoleHistory', []);
this._prompt = new ConsolePrompt();
this._prompt.show(this._promptElement);
@@ -1279,7 +1279,7 @@
this._textFilterUI = new UI.ToolbarInput(
Common.UIString('Filter'), '', 0.2, 1, Common.UIString('e.g. /event\\d/ -cdn url:a.com'),
this._suggestionBuilder.completions.bind(this._suggestionBuilder));
- this._textFilterSetting = Common.settings.createSetting('console.textFilter', '');
+ this._textFilterSetting = self.Common.settings.createSetting('console.textFilter', '');
if (this._textFilterSetting.get()) {
this._textFilterUI.setValue(this._textFilterSetting.get());
}
@@ -1329,7 +1329,7 @@
* @return {!Common.Setting}
*/
static levelFilterSetting() {
- return Common.settings.createSetting('messageLevelFilters', ConsoleFilter.defaultLevelsFilterValue());
+ return self.Common.settings.createSetting('messageLevelFilters', ConsoleFilter.defaultLevelsFilterValue());
}
_updateCurrentFilter() {
