[devtools] Report end position for CSS scripts to DevTools front-end
This simplifies determining whether a location is inside a CSS header
in the front-end (the front-end doesn't have to request the source
to determine the end line:column from the start line:column and the
size).
Before/After: https://imgur.com/a/OFdQBNL
Bug: chromium:1005789, chromium:1005708, chromium:1004203
Change-Id: I4c660c2a5f901cfe24d022b2636926ecf99254ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821721
Commit-Queue: Sigurd Schneider <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#704542}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96b62150b53277fdadcf13264379f4de9b47a2da
diff --git a/front_end/formatter/ScriptFormatter.js b/front_end/formatter/ScriptFormatter.js
index 7b02690..da6b77f 100644
--- a/front_end/formatter/ScriptFormatter.js
+++ b/front_end/formatter/ScriptFormatter.js
@@ -132,13 +132,11 @@
originalToFormatted(lineNumber, columnNumber) {},
/**
- * TODO(1005708): Remove the offset parameter once end positions of inline CSS is known.
* @param {number} lineNumber
* @param {number=} columnNumber
- * @param {number=} offset
* @return {!Array.<number>}
*/
- formattedToOriginal(lineNumber, columnNumber, offset) {}
+ formattedToOriginal(lineNumber, columnNumber) {}
};
/**
@@ -157,14 +155,12 @@
}
/**
- * TODO(1005708): Remove the offset parameter once end positions of inline CSS is known.
* @override
* @param {number} lineNumber
* @param {number=} columnNumber
- * @param {number=} offset
* @return {!Array.<number>}
*/
- formattedToOriginal(lineNumber, columnNumber, offset) {
+ formattedToOriginal(lineNumber, columnNumber) {
return [lineNumber, columnNumber || 0];
}
};
@@ -200,18 +196,16 @@
}
/**
- * TODO(chromium:1005708): Remove the offset parameter once end positions of inline CSS is known.
* @override
* @param {number} lineNumber
* @param {number=} columnNumber
- * @param {number=} offset
* @return {!Array.<number>}
*/
- formattedToOriginal(lineNumber, columnNumber, offset) {
+ formattedToOriginal(lineNumber, columnNumber) {
const formattedPosition =
Formatter.Formatter.locationToPosition(this._formattedLineEndings, lineNumber, columnNumber || 0);
const originalPosition = this._convertPosition(this._mapping.formatted, this._mapping.original, formattedPosition);
- return Formatter.Formatter.positionToLocation(this._originalLineEndings, (originalPosition || 0) + (offset || 0));
+ return Formatter.Formatter.positionToLocation(this._originalLineEndings, originalPosition || 0);
}
/**
