| commit | 7322deeb77b7bfbb55ff1f11bb0c446ed4afcbc0 | [log] [tgz] |
|---|---|---|
| author | Michael Liao <[email protected]> | Wed Apr 07 18:33:30 2021 |
| committer | Commit Bot <[email protected]> | Thu Apr 08 21:06:32 2021 |
| tree | 332bd63dc04f423975e407afd4a67203a04d516d | |
| parent | e08f0d3fbdc820a0a330fd58f7171590fce869bc [diff] [blame] |
[ARIAUtils]: Remove element parameter for alert() This CL removes the element parameter from ARIAUtils.alert. The element parameter is used to access the owner document. In place of that, this CL introduces ARIAUtils.setOwnerDocument which is called in MainImpl._showAppUI. This change allows ARIAUtils.alert to be called when an element is not readily accessible. Bug: 1195232 Change-Id: I646b604d281ad32bd0811514a3bfbc3254f998c4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2801093 Commit-Queue: Michael Liao <[email protected]> Reviewed-by: Jack Franklin <[email protected]> Reviewed-by: Kalon Hinds <[email protected]> Reviewed-by: Robert Paveza <[email protected]>
diff --git a/front_end/panels/elements/ClassesPaneWidget.js b/front_end/panels/elements/ClassesPaneWidget.js index 4fb919e..36a4e13 100644 --- a/front_end/panels/elements/ClassesPaneWidget.js +++ b/front_end/panels/elements/ClassesPaneWidget.js
@@ -119,7 +119,7 @@ const joinClassString = classNames.join(' '); const announcementString = classNames.length > 1 ? i18nString(UIStrings.classesSAdded, {PH1: joinClassString}) : i18nString(UIStrings.classSAdded, {PH1: joinClassString}); - UI.ARIAUtils.alert(announcementString, this.contentElement); + UI.ARIAUtils.alert(announcementString); this._installNodeClasses(node); this._update();