Change context menu label for "Copy all" when network filter applies
Bug: 348084788
Change-Id: I57f34b236a8e58356236dd34ca8330b2b6d7d69c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5712569
Commit-Queue: Sofia Emelianova <[email protected]>
Reviewed-by: Sofia Emelianova <[email protected]>
Auto-Submit: Yang Guo <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
diff --git a/front_end/panels/network/NetworkLogView.test.ts b/front_end/panels/network/NetworkLogView.test.ts
index d488f21..ec0ac31 100644
--- a/front_end/panels/network/NetworkLogView.test.ts
+++ b/front_end/panels/network/NetworkLogView.test.ts
@@ -866,7 +866,7 @@
// Use the 'Copy' sub-menu, get menu items from the footer section
const footerSection = (copyItem as UI.ContextMenu.SubMenu).footerSection();
- const copyAllURLs = findMenuItemWithLabel(footerSection, 'Copy all (filtered) URLs');
+ const copyAllURLs = findMenuItemWithLabel(footerSection, 'Copy all listed URLs');
assert.isDefined(copyAllURLs);
contextMenu.invokeHandler(copyAllURLs.id());
await expectCalled(copyText);
@@ -876,7 +876,7 @@
copyText.resetHistory();
const copyAllCurlComnmands = findMenuItemWithLabel(
- footerSection, Host.Platform.isWin() ? 'Copy all (filtered) as cURL (bash)' : 'Copy all (filtered) as cURL');
+ footerSection, Host.Platform.isWin() ? 'Copy all listed as cURL (bash)' : 'Copy all listed as cURL');
assert.isDefined(copyAllCurlComnmands);
contextMenu.invokeHandler(copyAllCurlComnmands.id());
await expectCalled(copyText);
@@ -885,7 +885,7 @@
curl 'url-header-und-content-overridden'`]);
copyText.resetHistory();
- const copyAllFetchCall = findMenuItemWithLabel(footerSection, 'Copy all (filtered) as fetch');
+ const copyAllFetchCall = findMenuItemWithLabel(footerSection, 'Copy all listed as fetch');
assert.isDefined(copyAllFetchCall);
contextMenu.invokeHandler(copyAllFetchCall.id());
await expectCalled(copyText);
@@ -904,7 +904,7 @@
});`]);
copyText.resetHistory();
- const copyAllPowerShell = findMenuItemWithLabel(footerSection, 'Copy all (filtered) as PowerShell');
+ const copyAllPowerShell = findMenuItemWithLabel(footerSection, 'Copy all listed as PowerShell');
assert.isDefined(copyAllPowerShell);
contextMenu.invokeHandler(copyAllPowerShell.id());
await expectCalled(copyText);
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts
index 21d7584..8534178 100644
--- a/front_end/panels/network/NetworkLogView.ts
+++ b/front_end/panels/network/NetworkLogView.ts
@@ -317,7 +317,7 @@
*@description A context menu command in the Network panel, for copying the URLs of all requestes
(after applying the Network filter) to the clipboard.
*/
- copyAllFilteredURLs: 'Copy all (filtered) URLs',
+ copyAllListedURLs: 'Copy all listed URLs',
/**
*@description Text in Network Log View of the Network panel. An action that copies a command to
*the clipboard. It will copy the command in the format compatible with a PowerShell script to
@@ -329,7 +329,7 @@
*the clipboard. It will copy the command in the format compatible with a PowerShell script to
*represent all network requests (after applying the Network filter).
*/
- copyAllFilteredAsPowershell: 'Copy all (filtered) as `PowerShell`',
+ copyAllListedAsPowershell: 'Copy all listed as `PowerShell`',
/**
*@description Text in Network Log View of the Network panel. An action that copies a command to
*the clipboard. It will copy the command in the format compatible with a 'fetch' command (fetch
@@ -341,7 +341,7 @@
*the clipboard. It will copy the command in the format compatible with a 'fetch' command (fetch
*should not be translated) to represent all network requests (after applying the Network filter).
*/
- copyAllFilteredAsFetch: 'Copy all (filtered) as `fetch`',
+ copyAllListedAsFetch: 'Copy all listed as `fetch`',
/**
*@description Text in Network Log View of the Network panel. An action that copies a command to
*the clipboard. It will copy the command in the format compatible with a Node.js 'fetch' command
@@ -354,7 +354,7 @@
*(fetch and Node.js should not be translated) to represent all network requests (after applying
*the Network filter).
*/
- copyAllFilteredAsNodejsFetch: 'Copy all (filtered) as `fetch` (`Node.js`)',
+ copyAllListedAsNodejsFetch: 'Copy all listed as `fetch` (`Node.js`)',
/**
*@description Text in Network Log View of the Network panel. An action that copies a command to
*the clipboard. It will copy the command in the format compatible with cURL (a program, not
@@ -366,7 +366,7 @@
*the clipboard. It will copy the command in the format compatible with cURL (a program, not
*translatable) to represent all network requests (after applying the Network filter).
*/
- copyAllFilteredAsCurlCmd: 'Copy all (filtered) as `cURL` (`cmd`)',
+ copyAllListedAsCurlCmd: 'Copy all listed as `cURL` (`cmd`)',
/**
*@description Text in Network Log View of the Network panel. An action that copies a command to
*the clipboard. It will copy the command in the format compatible with a Bash script to represent
@@ -378,7 +378,7 @@
*the clipboard. It will copy the command in the format compatible with a Bash script to represent
*all network requests (after applying the Network filter).
*/
- copyAllFilteredAsCurlBash: 'Copy all (filtered) as `cURL` (`bash`)',
+ copyAllListedAsCurlBash: 'Copy all listed as `cURL` (`bash`)',
/**
*@description Text in Network Log View of the Network panel. An action that copies a command to
*the clipboard. It will copy the command in the format compatible with cURL (a program, not
@@ -396,7 +396,7 @@
*the clipboard. It will copy the command in the format compatible with cURL (a program, not
*translatable) to represent all network requests (after applying the Network filter).
*/
- copyAllFilteredAsCurl: 'Copy all (filtered) as `cURL`',
+ copyAllListedAsCurl: 'Copy all listed as `cURL`',
/**
* @description Text in Network Log View of the Network panel. An action that copies data to the
* clipboard. It will copy the data in the HAR (not translatable) format. 'all' refers to every
@@ -408,7 +408,7 @@
* clipboard. It will copy the data in the HAR (not translatable) format. 'all' refers to every
* network request that is currently shown (after applying the Network filter).
*/
- copyAllFilteredAsHar: 'Copy all (filtered) as `HAR`',
+ copyAllListedAsHar: 'Copy all listed as `HAR`',
/**
*@description A context menu item in the Network Log View of the Network panel
*/
@@ -1747,7 +1747,7 @@
Host.InspectorFrontendHost.InspectorFrontendHostInstance, request.contentURL()),
{jslogContext: 'copy-url'});
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredURLs) : i18nString(UIStrings.copyAllURLs),
+ filtered ? i18nString(UIStrings.copyAllListedURLs) : i18nString(UIStrings.copyAllURLs),
this.copyAllURLs.bind(this), {jslogContext: 'copy-all-urls'});
if (request.requestHeadersText()) {
copyMenu.saveSection().appendItem(
@@ -1809,28 +1809,28 @@
if (Host.Platform.isWin()) {
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredAsCurlCmd) : i18nString(UIStrings.copyAllAsCurlCmd),
+ filtered ? i18nString(UIStrings.copyAllListedAsCurlCmd) : i18nString(UIStrings.copyAllAsCurlCmd),
this.copyAllCurlCommand.bind(this, 'win'), {jslogContext: 'copy-all-as-curl-cmd'});
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredAsCurlBash) : i18nString(UIStrings.copyAllAsCurlBash),
+ filtered ? i18nString(UIStrings.copyAllListedAsCurlBash) : i18nString(UIStrings.copyAllAsCurlBash),
this.copyAllCurlCommand.bind(this, 'unix'), {jslogContext: 'copy-all-as-curl-bash'});
} else {
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredAsCurl) : i18nString(UIStrings.copyAllAsCurl),
+ filtered ? i18nString(UIStrings.copyAllListedAsCurl) : i18nString(UIStrings.copyAllAsCurl),
this.copyAllCurlCommand.bind(this, 'unix'), {jslogContext: 'copy-all-as-curl'});
}
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredAsPowershell) : i18nString(UIStrings.copyAllAsPowershell),
+ filtered ? i18nString(UIStrings.copyAllListedAsPowershell) : i18nString(UIStrings.copyAllAsPowershell),
this.copyAllPowerShellCommand.bind(this), {jslogContext: 'copy-all-as-powershell'});
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredAsFetch) : i18nString(UIStrings.copyAllAsFetch),
+ filtered ? i18nString(UIStrings.copyAllListedAsFetch) : i18nString(UIStrings.copyAllAsFetch),
this.copyAllFetchCall.bind(this, FetchStyle.Browser), {jslogContext: 'copy-all-as-fetch'});
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredAsNodejsFetch) : i18nString(UIStrings.copyAllAsNodejsFetch),
+ filtered ? i18nString(UIStrings.copyAllListedAsNodejsFetch) : i18nString(UIStrings.copyAllAsNodejsFetch),
this.copyAllFetchCall.bind(this, FetchStyle.NodeJs), {jslogContext: 'copy-all-as-nodejs-fetch'});
}
copyMenu.footerSection().appendItem(
- filtered ? i18nString(UIStrings.copyAllFilteredAsHar) : i18nString(UIStrings.copyAllAsHar),
+ filtered ? i18nString(UIStrings.copyAllListedAsHar) : i18nString(UIStrings.copyAllAsHar),
this.copyAllAsHAR.bind(this), {jslogContext: 'copy-all-as-har'});
contextMenu.saveSection().appendItem(
