Remove all_devtools_files.gni
The LightHouse and locales variables are inlined in their respective
BUILD.gn file. The `all_devtools_files` variable is obsolete, as
we already set `data` on all `legacy_test_runner` BUILD.gn targets
themselves.
[email protected]
Bug: none
Change-Id: I32376984af36de801a07e51cb7eec2006cce6d79
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344907
Commit-Queue: Tim Van der Lippe <[email protected]>
Auto-Submit: Tim Van der Lippe <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
diff --git a/BUILD.gn b/BUILD.gn
index e043478..6630165 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("./config/gni/all_devtools_files.gni")
import("./config/gni/devtools_grd_files.gni")
import("./config/gni/devtools_image_files.gni")
import("./front_end/emulated_devices/optimized/optimized_images.gni")
@@ -19,8 +18,7 @@
group("devtools_all_files") {
testonly = true
- data = all_devtools_files
- data += [
+ data = [
# This enables us to test bots with whitespace changes.
"scripts/whitespaces.txt",
]
diff --git a/config/gni/all_devtools_files.gni b/config/gni/all_devtools_files.gni
deleted file mode 100644
index 51f97dd..0000000
--- a/config/gni/all_devtools_files.gni
+++ /dev/null
@@ -1,255 +0,0 @@
-# Copyright 2020 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import("../../scripts/build/ninja/vars.gni")
-
-all_devtools_files = [
- "front_end/legacy_test_runner/accessibility_test_runner/accessibility_test_runner.js",
- "front_end/legacy_test_runner/application_test_runner/application_test_runner.js",
- "front_end/legacy_test_runner/bindings_test_runner/bindings_test_runner.js",
- "front_end/legacy_test_runner/application_test_runner/CacheStorageTestRunner.js",
- "front_end/legacy_test_runner/application_test_runner/IndexedDBTestRunner.js",
- "front_end/legacy_test_runner/application_test_runner/ResourcesTestRunner.js",
- "front_end/legacy_test_runner/application_test_runner/ResourceTreeTestRunner.js",
- "front_end/legacy_test_runner/application_test_runner/ServiceWorkersTestRunner.js",
- "front_end/legacy_test_runner/application_test_runner/StorageTestRunner.js",
- "front_end/legacy_test_runner/lighthouse_test_runner/lighthouse_test_runner.js",
- "front_end/legacy_test_runner/axe_core_test_runner/axe_core_test_runner.js",
- "front_end/third_party/axe-core/axe.js",
- "front_end/legacy_test_runner/bindings_test_runner/AutomappingTestRunner.js",
- "front_end/legacy_test_runner/bindings_test_runner/BindingsTestRunner.js",
- "front_end/legacy_test_runner/bindings_test_runner/IsolatedFilesystemTestRunner.js",
- "front_end/legacy_test_runner/bindings_test_runner/OverridesTestRunner.js",
- "front_end/legacy_test_runner/bindings_test_runner/PersistenceTestRunner.js",
- "front_end/legacy_test_runner/console_test_runner/console_test_runner.js",
- "front_end/legacy_test_runner/coverage_test_runner/coverage_test_runner.js",
- "front_end/legacy_test_runner/cpu_profiler_test_runner/cpu_profiler_test_runner.js",
- "front_end/legacy_test_runner/data_grid_test_runner/data_grid_test_runner.js",
- "front_end/legacy_test_runner/device_mode_test_runner/device_mode_test_runner.js",
- "front_end/legacy_test_runner/elements_test_runner/elements_test_runner.js",
- "front_end/legacy_test_runner/elements_test_runner/EditDOMTestRunner.js",
- "front_end/legacy_test_runner/elements_test_runner/ElementsPanelShadowSelectionOnRefreshTestRunner.js",
- "front_end/legacy_test_runner/elements_test_runner/ElementsTestRunner.js",
- "front_end/legacy_test_runner/elements_test_runner/SetOuterHTMLTestRunner.js",
- "front_end/legacy_test_runner/elements_test_runner/StylesUpdateLinksTestRunner.js",
- "front_end/legacy_test_runner/extensions_test_runner/extensions_test_runner.js",
- "front_end/legacy_test_runner/extensions_test_runner/ExtensionsNetworkTestRunner.js",
- "front_end/legacy_test_runner/extensions_test_runner/ExtensionsTestRunner.js",
- "front_end/legacy_test_runner/heap_profiler_test_runner/heap_profiler_test_runner.js",
- "front_end/legacy_test_runner/layers_test_runner/layers_test_runner.js",
- "front_end/legacy_test_runner/network_test_runner/network_test_runner.js",
- "front_end/legacy_test_runner/performance_test_runner/performance_test_runner.js",
- "front_end/legacy_test_runner/performance_test_runner/TimelineDataTestRunner.js",
- "front_end/legacy_test_runner/performance_test_runner/TimelineTestRunner.js",
- "front_end/models/issues_manager/descriptions/arAttributionEventSourceTriggerDataTooLarge.md",
- "front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyFrameOrigin.md",
- "front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyOrigin.md",
- "front_end/models/issues_manager/descriptions/arAttributionTriggerDataTooLarge.md",
- "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyFrameOrigin.md",
- "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyOrigin.md",
- "front_end/models/issues_manager/descriptions/arInvalidAttributionData.md",
- "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceEventId.md",
- "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md",
- "front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md",
- "front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md",
- "front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md",
- "front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md",
- "front_end/models/issues_manager/descriptions/arMissingAttributionData.md",
- "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
- "front_end/models/issues_manager/descriptions/CoepCoopSandboxedIframeCannotNavigateToCoopPage.md",
- "front_end/models/issues_manager/descriptions/CoepCorpNotSameSite.md",
- "front_end/models/issues_manager/descriptions/CoepCorpNotSameOrigin.md",
- "front_end/models/issues_manager/descriptions/CoepCorpNotSameOriginAfterDefaultedToSameOriginByCoep.md",
- "front_end/models/issues_manager/descriptions/CoepFrameResourceNeedsCoepHeader.md",
- "front_end/models/issues_manager/descriptions/cspEvalViolation.md",
- "front_end/models/issues_manager/descriptions/cspInlineViolation.md",
- "front_end/models/issues_manager/descriptions/cspURLViolation.md",
- "front_end/models/issues_manager/descriptions/deprecationNavigatorUserAgent.md",
- "front_end/models/issues_manager/descriptions/LowTextContrast.md",
- "front_end/models/issues_manager/descriptions/cspTrustedTypesSinkViolation.md",
- "front_end/models/issues_manager/descriptions/cspTrustedTypesPolicyViolation.md",
- "front_end/models/issues_manager/descriptions/CompatibilityModeQuirks.md",
- "front_end/models/issues_manager/descriptions/heavyAd.md",
- "front_end/models/issues_manager/descriptions/corsAllowCredentialsRequired.md",
- "front_end/models/issues_manager/descriptions/corsDisallowedByMode.md",
- "front_end/models/issues_manager/descriptions/corsDisabledScheme.md",
- "front_end/models/issues_manager/descriptions/corsNoCorsRedirectModeNotFollow.md",
- "front_end/models/issues_manager/descriptions/corsHeaderDisallowedByPreflightResponse.md",
- "front_end/models/issues_manager/descriptions/corsInvalidHeaderValues.md",
- "front_end/models/issues_manager/descriptions/corsMethodDisallowedByPreflightResponse.md",
- "front_end/models/issues_manager/descriptions/corsOriginMismatch.md",
- "front_end/models/issues_manager/descriptions/corsPreflightResponseInvalid.md",
- "front_end/models/issues_manager/descriptions/corsRedirectContainsCredentials.md",
- "front_end/models/issues_manager/descriptions/corsWildcardOriginNotAllowed.md",
- "front_end/models/issues_manager/descriptions/mixedContent.md",
- "front_end/models/issues_manager/descriptions/sharedArrayBuffer.md",
- "front_end/models/issues_manager/descriptions/corsInsecurePrivateNetwork.md",
- "front_end/models/issues_manager/descriptions/corsPreflightAllowPrivateNetworkError.md",
- "front_end/models/issues_manager/descriptions/SameSiteExcludeContextDowngradeRead.md",
- "front_end/models/issues_manager/descriptions/SameSiteExcludeContextDowngradeSet.md",
- "front_end/models/issues_manager/descriptions/SameSiteExcludeNavigationContextDowngrade.md",
- "front_end/models/issues_manager/descriptions/SameSiteInvalidSameParty.md",
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureErrorRead.md",
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureErrorSet.md",
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureWarnRead.md",
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureWarnSet.md",
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedLaxAllowUnsafeRead.md",
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedLaxAllowUnsafeSet.md",
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedTreatedAsLaxRead.md",
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedTreatedAsLaxSet.md",
- "front_end/models/issues_manager/descriptions/SameSiteWarnCrossDowngradeRead.md",
- "front_end/models/issues_manager/descriptions/SameSiteWarnCrossDowngradeSet.md",
- "front_end/models/issues_manager/descriptions/SameSiteWarnStrictLaxDowngradeStrict.md",
- "front_end/models/issues_manager/descriptions/TwaDigitalAssetLinksFailed.md",
- "front_end/models/issues_manager/descriptions/TwaHttpError.md",
- "front_end/models/issues_manager/descriptions/TwaPageUnavailableOffline.md",
- "front_end/legacy_test_runner/sdk_test_runner/sdk_test_runner.js",
- "front_end/legacy_test_runner/security_test_runner/security_test_runner.js",
- "front_end/legacy_test_runner/sources_test_runner/sources_test_runner.js",
- "front_end/legacy_test_runner/sources_test_runner/AutocompleteTestRunner.js",
- "front_end/legacy_test_runner/sources_test_runner/DebuggerTestRunner.js",
- "front_end/legacy_test_runner/sources_test_runner/EditorTestRunner.js",
- "front_end/legacy_test_runner/sources_test_runner/LiveEditTestRunner.js",
- "front_end/legacy_test_runner/sources_test_runner/SearchTestRunner.js",
- "front_end/legacy_test_runner/sources_test_runner/SourcesTestRunner.js",
-]
-
-lighthouse_locale_files = [
- "locales/ar-XB.json",
- "locales/ar.json",
- "locales/bg.json",
- "locales/ca.json",
- "locales/cs.json",
- "locales/da.json",
- "locales/de.json",
- "locales/el.json",
- "locales/en-GB.json",
- "locales/en-US.json",
- "locales/en-XA.json",
- "locales/en-XL.json",
- "locales/es-419.json",
- "locales/es.json",
- "locales/fi.json",
- "locales/fil.json",
- "locales/fr.json",
- "locales/he.json",
- "locales/hi.json",
- "locales/hr.json",
- "locales/hu.json",
- "locales/id.json",
- "locales/it.json",
- "locales/ja.json",
- "locales/ko.json",
- "locales/lt.json",
- "locales/lv.json",
- "locales/nl.json",
- "locales/no.json",
- "locales/pl.json",
- "locales/pt-PT.json",
- "locales/pt.json",
- "locales/ro.json",
- "locales/ru.json",
- "locales/sk.json",
- "locales/sl.json",
- "locales/sr-Latn.json",
- "locales/sr.json",
- "locales/sv.json",
- "locales/ta.json",
- "locales/te.json",
- "locales/th.json",
- "locales/tr.json",
- "locales/uk.json",
- "locales/vi.json",
- "locales/zh-HK.json",
- "locales/zh-TW.json",
- "locales/zh.json",
-]
-
-remote_devtools_locale_files = [
- "af.json",
- "am.json",
- "ar.json",
- "as.json",
- "az.json",
- "be.json",
- "bg.json",
- "bn.json",
- "bs.json",
- "ca.json",
- "cs.json",
- "cy.json",
- "da.json",
- "de.json",
- "el.json",
- "en-GB.json",
- "es-419.json",
- "es.json",
- "et.json",
- "eu.json",
- "fa.json",
- "fi.json",
- "fil.json",
- "fr-CA.json",
- "fr.json",
- "gl.json",
- "gu.json",
- "he.json",
- "hi.json",
- "hr.json",
- "hu.json",
- "hy.json",
- "id.json",
- "is.json",
- "it.json",
- "ja.json",
- "ka.json",
- "kk.json",
- "km.json",
- "kn.json",
- "ko.json",
- "ky.json",
- "lo.json",
- "lt.json",
- "lv.json",
- "mk.json",
- "ml.json",
- "mn.json",
- "mr.json",
- "ms.json",
- "my.json",
- "ne.json",
- "nl.json",
- "no.json",
- "or.json",
- "pa.json",
- "pl.json",
- "pt-PT.json",
- "pt.json",
- "ro.json",
- "ru.json",
- "si.json",
- "sk.json",
- "sl.json",
- "sq.json",
- "sr-Latn.json",
- "sr.json",
- "sv.json",
- "sw.json",
- "ta.json",
- "te.json",
- "th.json",
- "tr.json",
- "uk.json",
- "ur.json",
- "uz.json",
- "vi.json",
- "zh-HK.json",
- "zh-TW.json",
- "zu.json",
-]
-
-bundled_devtools_locale_files = [
- "en-US.json",
- "zh.json",
-]
diff --git a/front_end/core/i18n/BUILD.gn b/front_end/core/i18n/BUILD.gn
index f8be1f9..ee7b7ae 100644
--- a/front_end/core/i18n/BUILD.gn
+++ b/front_end/core/i18n/BUILD.gn
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("../../../config/gni/all_devtools_files.gni")
import("../../../scripts/build/ninja/devtools_entrypoint.gni")
import("../../../scripts/build/ninja/devtools_module.gni")
import("../../../scripts/build/ninja/devtools_pre_built.gni")
@@ -35,6 +34,94 @@
visibility = [ "*" ]
}
+remote_devtools_locale_files = [
+ "af.json",
+ "am.json",
+ "ar.json",
+ "as.json",
+ "az.json",
+ "be.json",
+ "bg.json",
+ "bn.json",
+ "bs.json",
+ "ca.json",
+ "cs.json",
+ "cy.json",
+ "da.json",
+ "de.json",
+ "el.json",
+ "en-GB.json",
+ "es-419.json",
+ "es.json",
+ "et.json",
+ "eu.json",
+ "fa.json",
+ "fi.json",
+ "fil.json",
+ "fr-CA.json",
+ "fr.json",
+ "gl.json",
+ "gu.json",
+ "he.json",
+ "hi.json",
+ "hr.json",
+ "hu.json",
+ "hy.json",
+ "id.json",
+ "is.json",
+ "it.json",
+ "ja.json",
+ "ka.json",
+ "kk.json",
+ "km.json",
+ "kn.json",
+ "ko.json",
+ "ky.json",
+ "lo.json",
+ "lt.json",
+ "lv.json",
+ "mk.json",
+ "ml.json",
+ "mn.json",
+ "mr.json",
+ "ms.json",
+ "my.json",
+ "ne.json",
+ "nl.json",
+ "no.json",
+ "or.json",
+ "pa.json",
+ "pl.json",
+ "pt-PT.json",
+ "pt.json",
+ "ro.json",
+ "ru.json",
+ "si.json",
+ "sk.json",
+ "sl.json",
+ "sq.json",
+ "sr-Latn.json",
+ "sr.json",
+ "sv.json",
+ "sw.json",
+ "ta.json",
+ "te.json",
+ "th.json",
+ "tr.json",
+ "uk.json",
+ "ur.json",
+ "uz.json",
+ "vi.json",
+ "zh-HK.json",
+ "zh-TW.json",
+ "zu.json",
+]
+
+bundled_devtools_locale_files = [
+ "en-US.json",
+ "zh.json",
+]
+
copy_to_gen("i18n_remote_locales") {
sources = []
foreach(locale, remote_devtools_locale_files) {
diff --git a/front_end/models/issues_manager/BUILD.gn b/front_end/models/issues_manager/BUILD.gn
index d714284..9f6955c 100644
--- a/front_end/models/issues_manager/BUILD.gn
+++ b/front_end/models/issues_manager/BUILD.gn
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("../../../config/gni/all_devtools_files.gni")
import("../../../scripts/build/ninja/devtools_entrypoint.gni")
import("../../../scripts/build/ninja/devtools_module.gni")
import("../../../scripts/build/ninja/devtools_pre_built.gni")
diff --git a/front_end/third_party/lighthouse/BUILD.gn b/front_end/third_party/lighthouse/BUILD.gn
index 83a9924..b0322c3 100644
--- a/front_end/third_party/lighthouse/BUILD.gn
+++ b/front_end/third_party/lighthouse/BUILD.gn
@@ -2,16 +2,63 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("../../../config/gni/all_devtools_files.gni")
import("../../../scripts/build/ninja/copy.gni")
import("../../../scripts/build/ninja/devtools_entrypoint.gni")
import("../../../scripts/build/ninja/devtools_pre_built.gni")
import("../visibility.gni")
-_lighthouse_sources = lighthouse_locale_files + [
- "lighthouse-tsconfig.json",
- "lighthouse-dt-bundle.d.ts",
- ]
+_lighthouse_sources = [
+ "lighthouse-dt-bundle.d.ts",
+ "lighthouse-tsconfig.json",
+ "locales/ar-XB.json",
+ "locales/ar.json",
+ "locales/bg.json",
+ "locales/ca.json",
+ "locales/cs.json",
+ "locales/da.json",
+ "locales/de.json",
+ "locales/el.json",
+ "locales/en-GB.json",
+ "locales/en-US.json",
+ "locales/en-XA.json",
+ "locales/en-XL.json",
+ "locales/es-419.json",
+ "locales/es.json",
+ "locales/fi.json",
+ "locales/fil.json",
+ "locales/fr.json",
+ "locales/he.json",
+ "locales/hi.json",
+ "locales/hr.json",
+ "locales/hu.json",
+ "locales/id.json",
+ "locales/it.json",
+ "locales/ja.json",
+ "locales/ko.json",
+ "locales/lt.json",
+ "locales/lv.json",
+ "locales/nl.json",
+ "locales/no.json",
+ "locales/pl.json",
+ "locales/pt-PT.json",
+ "locales/pt.json",
+ "locales/ro.json",
+ "locales/ru.json",
+ "locales/sk.json",
+ "locales/sl.json",
+ "locales/sr-Latn.json",
+ "locales/sr.json",
+ "locales/sv.json",
+ "locales/ta.json",
+ "locales/te.json",
+ "locales/th.json",
+ "locales/tr.json",
+ "locales/uk.json",
+ "locales/vi.json",
+ "locales/zh-HK.json",
+ "locales/zh-TW.json",
+ "locales/zh.json",
+]
copy_to_gen("lighthouse-locale-files") {
sources = _lighthouse_sources
diff --git a/front_end/third_party/lighthouse/report/BUILD.gn b/front_end/third_party/lighthouse/report/BUILD.gn
index 36229e0..e1794b0 100644
--- a/front_end/third_party/lighthouse/report/BUILD.gn
+++ b/front_end/third_party/lighthouse/report/BUILD.gn
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("../../../../config/gni/all_devtools_files.gni")
import("../../../../scripts/build/ninja/devtools_entrypoint.gni")
import("../../../../scripts/build/ninja/devtools_pre_built.gni")
import("../../visibility.gni")
