[network] Clicking on 'View Headers' actually opens the 'Headers' tab
This CL extends the RequestActivated event by an optional Tab for the
NetworkItemView. For the 'View Headers' link we want to show the
'Headers' tab of the NetworkItemView.
Please note that we can't use the Revelaer for NetworkRequests as
the revealer requires an already open NetworkItemView which is not
the case for this workflow (looking at requests in the log view).
[email protected]
Bug: chromium:1060136
Change-Id: I868e03dfbc6086d44a60db3d63e2199eb17a3b82
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2097982
Commit-Queue: Simon Zünd <[email protected]>
Reviewed-by: Sigurd Schneider <[email protected]>
diff --git a/front_end/network/NetworkLogView.js b/front_end/network/NetworkLogView.js
index 48804d6..27b8625 100644
--- a/front_end/network/NetworkLogView.js
+++ b/front_end/network/NetworkLogView.js
@@ -763,7 +763,7 @@
this._dataGrid.element.addEventListener('mouseleave', () => this._setHoveredNode(null), true);
this._dataGrid.element.addEventListener('keydown', event => {
if (isEnterOrSpaceKey(event)) {
- this.dispatchEventToListeners(Events.RequestActivated, /* showPanel */ true);
+ this.dispatchEventToListeners(Events.RequestActivated, {showPanel: true});
event.consume(true);
}
});
@@ -1194,7 +1194,7 @@
}
_reset() {
- this.dispatchEventToListeners(Events.RequestActivated, /* showPanel */ false);
+ this.dispatchEventToListeners(Events.RequestActivated, {showPanel: false});
this._setHoveredNode(null);
this._columns.reset();
