Remove typedefs from data_grid-legacy.js
Bug: 1006759
Change-Id: I07c3fb9cc3840ffebd07c9dcd5dd2e3ab6ea006a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2057206
Reviewed-by: Paul Lewis <[email protected]>
diff --git a/front_end/cookie_table/CookiesTable.js b/front_end/cookie_table/CookiesTable.js
index dbaaf9a..7444f23 100644
--- a/front_end/cookie_table/CookiesTable.js
+++ b/front_end/cookie_table/CookiesTable.js
@@ -60,7 +60,7 @@
const editable = !!saveCallback;
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{
id: SDK.Cookie.Attributes.Name,
title: ls`Name`,
diff --git a/front_end/data_grid/DataGrid.js b/front_end/data_grid/DataGrid.js
index 05f88aa..6d180fd 100644
--- a/front_end/data_grid/DataGrid.js
+++ b/front_end/data_grid/DataGrid.js
@@ -32,7 +32,7 @@
*/
export class DataGridImpl extends Common.ObjectWrapper.ObjectWrapper {
/**
- * @param {!DataGrid.Parameters} dataGridParameters
+ * @param {!Parameters} dataGridParameters
*/
constructor(dataGridParameters) {
super();
@@ -85,11 +85,11 @@
/** @type {boolean} */
this._inline = false;
- /** @type {!Array.<!DataGrid.ColumnDescriptor>} */
+ /** @type {!Array.<!ColumnDescriptor>} */
this._columnsArray = [];
- /** @type {!Object.<string, !DataGrid.ColumnDescriptor>} */
+ /** @type {!Object.<string, !ColumnDescriptor>} */
this._columns = {};
- /** @type {!Array.<!DataGrid.ColumnDescriptor>} */
+ /** @type {!Array.<!ColumnDescriptor>} */
this.visibleColumnsArray = columnsArray;
columnsArray.forEach(column => this._innerAddColumn(column));
@@ -275,7 +275,7 @@
}
/**
- * @param {!DataGrid.ColumnDescriptor} column
+ * @param {!ColumnDescriptor} column
* @param {number=} position
*/
_innerAddColumn(column, position) {
@@ -324,7 +324,7 @@
}
/**
- * @param {!DataGrid.ColumnDescriptor} column
+ * @param {!ColumnDescriptor} column
* @param {number=} position
*/
addColumn(column, position) {
@@ -2525,3 +2525,34 @@
this._dataGrids = [];
}
}
+
+/**
+ * @typedef {{
+ * displayName: string,
+ * columns: !Array.<!ColumnDescriptor>,
+ * editCallback: (function(!Object, string, *, *)|undefined),
+ * deleteCallback: (function(!Object)|undefined|function(string)),
+ * refreshCallback: (function()|undefined)
+ * }}
+ */
+export let Parameters;
+
+/**
+ * @typedef {{
+ * id: string,
+ * title: (string|undefined),
+ * titleDOMFragment: (?DocumentFragment|undefined),
+ * sortable: boolean,
+ * sort: (?Order|undefined),
+ * align: (?Align|undefined),
+ * fixedWidth: (boolean|undefined),
+ * editable: (boolean|undefined),
+ * nonSelectable: (boolean|undefined),
+ * longText: (boolean|undefined),
+ * disclosure: (boolean|undefined),
+ * weight: (number|undefined),
+ * allowInSortByEvenWhenHidden: (boolean|undefined),
+ * dataType: (?DataType|undefined)
+ * }}
+ */
+export let ColumnDescriptor;
diff --git a/front_end/data_grid/SortableDataGrid.js b/front_end/data_grid/SortableDataGrid.js
index c488938..4da8981 100644
--- a/front_end/data_grid/SortableDataGrid.js
+++ b/front_end/data_grid/SortableDataGrid.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-import {Events} from './DataGrid.js';
+import {ColumnDescriptor, Events, Parameters} from './DataGrid.js'; // eslint-disable-line no-unused-vars
import {ViewportDataGrid, ViewportDataGridNode} from './ViewportDataGrid.js';
/**
@@ -12,7 +12,7 @@
*/
export class SortableDataGrid extends ViewportDataGrid {
/**
- * @param {!DataGrid.Parameters} dataGridParameters
+ * @param {!Parameters} dataGridParameters
*/
constructor(dataGridParameters) {
super(dataGridParameters);
@@ -82,7 +82,7 @@
return null;
}
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([]);
+ const columns = /** @type {!Array<!ColumnDescriptor>} */ ([]);
for (let i = 0; i < columnNames.length; ++i) {
columns.push({id: String(i), title: columnNames[i], width: columnNames[i].length, sortable: true});
}
diff --git a/front_end/data_grid/ViewportDataGrid.js b/front_end/data_grid/ViewportDataGrid.js
index d7dda18..e22d2ed 100644
--- a/front_end/data_grid/ViewportDataGrid.js
+++ b/front_end/data_grid/ViewportDataGrid.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-import {DataGridImpl, DataGridNode} from './DataGrid.js';
+import {DataGridImpl, DataGridNode, Parameters} from './DataGrid.js'; // eslint-disable-line no-unused-vars
/**
* @unrestricted
@@ -11,7 +11,7 @@
*/
export class ViewportDataGrid extends DataGridImpl {
/**
- * @param {!DataGrid.Parameters} dataGridParameters
+ * @param {!Parameters} dataGridParameters
*/
constructor(dataGridParameters) {
super(dataGridParameters);
diff --git a/front_end/data_grid/data_grid-legacy.js b/front_end/data_grid/data_grid-legacy.js
index 22513bd..80f3375 100644
--- a/front_end/data_grid/data_grid-legacy.js
+++ b/front_end/data_grid/data_grid-legacy.js
@@ -47,37 +47,6 @@
DataGrid.DataGrid.ResizeMethod = DataGridModule.DataGrid.ResizeMethod;
/**
- * @typedef {{
- * displayName: string,
- * columns: !Array.<!DataGrid.ColumnDescriptor>,
- * editCallback: (function(!Object, string, *, *)|undefined),
- * deleteCallback: (function(!Object)|undefined|function(string)),
- * refreshCallback: (function()|undefined)
- * }}
- */
-DataGrid.Parameters = DataGridModule.Parameters;
-
-/**
- * @typedef {{
- * id: string,
- * title: (string|undefined),
- * titleDOMFragment: (?DocumentFragment|undefined),
- * sortable: boolean,
- * sort: (?DataGrid.DataGrid.Order|undefined),
- * align: (?DataGrid.DataGrid.Align|undefined),
- * fixedWidth: (boolean|undefined),
- * editable: (boolean|undefined),
- * nonSelectable: (boolean|undefined),
- * longText: (boolean|undefined),
- * disclosure: (boolean|undefined),
- * weight: (number|undefined),
- * allowInSortByEvenWhenHidden: (boolean|undefined),
- * dataType: (?DataGrid.DataGrid.DataType|undefined)
- * }}
- */
-DataGrid.ColumnDescriptor = DataGridModule.ColumnDescriptor;
-
-/**
* @constructor
*/
DataGrid.ShowMoreDataGridNode = DataGridModule.ShowMoreDataGridNode.ShowMoreDataGridNode;
diff --git a/front_end/data_grid/data_grid.js b/front_end/data_grid/data_grid.js
index 3bde861..018ff34 100644
--- a/front_end/data_grid/data_grid.js
+++ b/front_end/data_grid/data_grid.js
@@ -12,35 +12,4 @@
import * as SortableDataGrid from './SortableDataGrid.js';
import * as ViewportDataGrid from './ViewportDataGrid.js';
-/**
- * @typedef {{
- * displayName: string,
- * columns: !Array.<!ColumnDescriptor>,
- * editCallback: (function(!Object, string, *, *)|undefined),
- * deleteCallback: (function(!Object)|undefined|function(string)),
- * refreshCallback: (function()|undefined)
- * }}
- */
-export let Parameters;
-
-/**
- * @typedef {{
- * id: string,
- * title: (string|undefined),
- * titleDOMFragment: (?DocumentFragment|undefined),
- * sortable: boolean,
- * sort: (?DataGrid.Order|undefined),
- * align: (?DataGrid.Align|undefined),
- * fixedWidth: (boolean|undefined),
- * editable: (boolean|undefined),
- * nonSelectable: (boolean|undefined),
- * longText: (boolean|undefined),
- * disclosure: (boolean|undefined),
- * weight: (number|undefined),
- * allowInSortByEvenWhenHidden: (boolean|undefined),
- * dataType: (?DataGrid.DataType|undefined)
- * }}
- */
-export let ColumnDescriptor;
-
export {DataGrid, ShowMoreDataGridNode, SortableDataGrid, ViewportDataGrid};
diff --git a/front_end/media/EventDisplayTable.js b/front_end/media/EventDisplayTable.js
index 86f142f..598c9d8 100644
--- a/front_end/media/EventDisplayTable.js
+++ b/front_end/media/EventDisplayTable.js
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+import * as DataGrid from '../data_grid/data_grid.js';
+
/**
* @typedef {{
* id: string,
@@ -33,7 +35,7 @@
/**
* @unrestricted
*/
-Media.EventNode = class extends DataGrid.DataGridNode {
+Media.EventNode = class extends DataGrid.DataGrid.DataGridNode {
/**
* @param {!Media.Event} event
*/
@@ -79,7 +81,8 @@
id: Media.MediaEventColumnKeys.Timestamp,
title: ls`Timestamp`,
weight: 1,
- sortingFunction: DataGrid.SortableDataGrid.NumericComparator.bind(null, Media.MediaEventColumnKeys.Timestamp)
+ sortingFunction: DataGrid.SortableDataGrid.SortableDataGrid.NumericComparator.bind(
+ null, Media.MediaEventColumnKeys.Timestamp)
},
{id: Media.MediaEventColumnKeys.Event, title: ls`Event Name`, weight: 2},
{id: Media.MediaEventColumnKeys.Value, title: ls`Value`, weight: 7}
@@ -103,7 +106,7 @@
// TODO(tmathmeyer) SortableDataGrid doesn't play nice with nested JSON
// renderers, since they can change size, and this breaks the visible
// element computation in ViewportDataGrid.
- const datagrid = new DataGrid.DataGrid({displayName: ls`Event Display`, columns: gridColumnDescs});
+ const datagrid = new DataGrid.DataGrid.DataGrid({displayName: ls`Event Display`, columns: gridColumnDescs});
datagrid.asWidget().contentElement.classList.add('no-border-top-datagrid');
return datagrid;
}
@@ -159,10 +162,10 @@
/**
* @param {!Media.EventDisplayColumnConfig} columnConfig
- * @return {!DataGrid.ColumnDescriptor}
+ * @return {!DataGrid.DataGrid.ColumnDescriptor}
*/
static _convertToGridDescriptor(columnConfig) {
- return /** @type {!DataGrid.ColumnDescriptor} */ ({
+ return /** @type {!DataGrid.DataGrid.ColumnDescriptor} */ ({
id: columnConfig.id,
title: columnConfig.title,
sortable: columnConfig.sortable,
diff --git a/front_end/network/EventSourceMessagesView.js b/front_end/network/EventSourceMessagesView.js
index 23143ba..aa44aec 100644
--- a/front_end/network/EventSourceMessagesView.js
+++ b/front_end/network/EventSourceMessagesView.js
@@ -20,7 +20,7 @@
this.element.classList.add('event-source-messages-view');
this._request = request;
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'id', title: Common.UIString.UIString('Id'), sortable: true, weight: 8},
{id: 'type', title: Common.UIString.UIString('Type'), sortable: true, weight: 8},
{id: 'data', title: Common.UIString.UIString('Data'), sortable: false, weight: 88},
diff --git a/front_end/network/NetworkLogViewColumns.js b/front_end/network/NetworkLogViewColumns.js
index 80e17b0..cad0bc6 100644
--- a/front_end/network/NetworkLogViewColumns.js
+++ b/front_end/network/NetworkLogViewColumns.js
@@ -62,10 +62,10 @@
/**
* @param {!Network.NetworkLogViewColumns.Descriptor} columnConfig
- * @return {!DataGrid.ColumnDescriptor}
+ * @return {!DataGrid.DataGrid.ColumnDescriptor}
*/
static _convertToDataGridDescriptor(columnConfig) {
- return /** @type {!DataGrid.ColumnDescriptor} */ ({
+ return /** @type {!DataGrid.DataGrid.ColumnDescriptor} */ ({
id: columnConfig.id,
title: columnConfig.title,
sortable: columnConfig.sortable,
diff --git a/front_end/network/ResourceWebSocketFrameView.js b/front_end/network/ResourceWebSocketFrameView.js
index 0459a12..a8c923b 100644
--- a/front_end/network/ResourceWebSocketFrameView.js
+++ b/front_end/network/ResourceWebSocketFrameView.js
@@ -41,7 +41,7 @@
this._splitWidget = new UI.SplitWidget.SplitWidget(false, true, 'resourceWebSocketFrameSplitViewState');
this._splitWidget.show(this.element);
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'data', title: Common.UIString.UIString('Data'), sortable: false, weight: 88}, {
id: 'length',
title: Common.UIString.UIString('Length'),
diff --git a/front_end/profiler/HeapSnapshotDataGrids.js b/front_end/profiler/HeapSnapshotDataGrids.js
index bc41573..33a24b5 100644
--- a/front_end/profiler/HeapSnapshotDataGrids.js
+++ b/front_end/profiler/HeapSnapshotDataGrids.js
@@ -45,7 +45,7 @@
/**
* @param {?SDK.HeapProfilerModel.HeapProfilerModel} heapProfilerModel
* @param {!DataDisplayDelegate} dataDisplayDelegate
- * @param {!DataGrid.Parameters} dataGridParameters
+ * @param {!DataGrid.DataGrid.Parameters} dataGridParameters
*/
constructor(heapProfilerModel, dataDisplayDelegate, dataGridParameters) {
// TODO(allada) This entire class needs to be converted to use the templates in DataGridNode.
@@ -346,7 +346,7 @@
/**
* @param {?SDK.HeapProfilerModel.HeapProfilerModel} heapProfilerModel
* @param {!DataDisplayDelegate} dataDisplayDelegate
- * @param {!DataGrid.Parameters} dataGridParameters
+ * @param {!DataGrid.DataGrid.Parameters} dataGridParameters
*/
constructor(heapProfilerModel, dataDisplayDelegate, dataGridParameters) {
super(heapProfilerModel, dataDisplayDelegate, dataGridParameters);
@@ -638,10 +638,10 @@
* @param {?SDK.HeapProfilerModel.HeapProfilerModel} heapProfilerModel
* @param {!DataDisplayDelegate} dataDisplayDelegate
* @param {string} displayName
- * @param {!Array.<!DataGrid.ColumnDescriptor>=} columns
+ * @param {!Array.<!DataGrid.DataGrid.ColumnDescriptor>=} columns
*/
constructor(heapProfilerModel, dataDisplayDelegate, displayName, columns) {
- columns = columns || (/** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ columns = columns || (/** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'object', title: ls`Object`, disclosure: true, sortable: true},
{id: 'distance', title: ls`Distance`, width: '70px', sortable: true, fixedWidth: true},
{id: 'shallowSize', title: ls`Shallow Size`, width: '110px', sortable: true, fixedWidth: true}, {
@@ -693,7 +693,7 @@
* @param {!DataDisplayDelegate} dataDisplayDelegate
*/
constructor(heapProfilerModel, dataDisplayDelegate) {
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'object', title: ls`Object`, disclosure: true, sortable: true}, {
id: 'distance',
title: ls`Distance`,
@@ -755,7 +755,7 @@
* @param {!DataDisplayDelegate} dataDisplayDelegate
*/
constructor(heapProfilerModel, dataDisplayDelegate) {
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'object', title: ls`Constructor`, disclosure: true, sortable: true},
{id: 'distance', title: ls`Distance`, width: '70px', sortable: true, fixedWidth: true},
{id: 'shallowSize', title: ls`Shallow Size`, width: '110px', sortable: true, fixedWidth: true}, {
@@ -913,7 +913,7 @@
* @param {!DataDisplayDelegate} dataDisplayDelegate
*/
constructor(heapProfilerModel, dataDisplayDelegate) {
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'object', title: ls`Constructor`, disclosure: true, sortable: true},
{id: 'addedCount', title: ls`# New`, width: '75px', sortable: true, fixedWidth: true},
{id: 'removedCount', title: ls`# Deleted`, width: '75px', sortable: true, fixedWidth: true},
@@ -993,7 +993,7 @@
* @param {!DataDisplayDelegate} dataDisplayDelegate
*/
constructor(heapProfilerModel, dataDisplayDelegate) {
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'liveCount', title: ls`Live Count`, width: '75px', sortable: true, fixedWidth: true},
{id: 'count', title: ls`Count`, width: '65px', sortable: true, fixedWidth: true},
{id: 'liveSize', title: ls`Live Size`, width: '75px', sortable: true, fixedWidth: true},
diff --git a/front_end/profiler/ProfileView.js b/front_end/profiler/ProfileView.js
index b790999..0a7d761 100644
--- a/front_end/profiler/ProfileView.js
+++ b/front_end/profiler/ProfileView.js
@@ -31,7 +31,7 @@
this._searchableView.setPlaceholder(Common.UIString.UIString('Find by cost (>50ms), name or file'));
this._searchableView.show(this.element);
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([]);
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([]);
columns.push({
id: 'self',
title: this.columnHeader('self'),
diff --git a/front_end/resources/ApplicationCacheItemsView.js b/front_end/resources/ApplicationCacheItemsView.js
index 0bc2e48..052e7bc 100644
--- a/front_end/resources/ApplicationCacheItemsView.js
+++ b/front_end/resources/ApplicationCacheItemsView.js
@@ -184,7 +184,7 @@
}
_createDataGrid() {
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{
id: 'resource',
title: Common.UIString.UIString('Resource'),
diff --git a/front_end/resources/BackgroundServiceView.js b/front_end/resources/BackgroundServiceView.js
index 2d7a2f9..ad6d7fa 100644
--- a/front_end/resources/BackgroundServiceView.js
+++ b/front_end/resources/BackgroundServiceView.js
@@ -218,7 +218,7 @@
* @return {!DataGrid.DataGrid.DataGridImpl}
*/
_createDataGrid() {
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'id', title: ls`#`, weight: 1},
{id: 'timestamp', title: ls`Timestamp`, weight: 8},
{id: 'eventName', title: ls`Event`, weight: 10},
diff --git a/front_end/resources/DOMStorageItemsView.js b/front_end/resources/DOMStorageItemsView.js
index 7471870..7b1d54f 100644
--- a/front_end/resources/DOMStorageItemsView.js
+++ b/front_end/resources/DOMStorageItemsView.js
@@ -43,7 +43,7 @@
this.element.classList.add('storage-view', 'table');
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'key', title: Common.UIString.UIString('Key'), sortable: false, editable: true, longText: true, weight: 50},
{
id: 'value',
diff --git a/front_end/resources/IndexedDBViews.js b/front_end/resources/IndexedDBViews.js
index a084535..0cc2ee2 100644
--- a/front_end/resources/IndexedDBViews.js
+++ b/front_end/resources/IndexedDBViews.js
@@ -159,7 +159,7 @@
_createDataGrid() {
const keyPath = this._isIndex ? this._index.keyPath : this._objectStore.keyPath;
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([]);
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([]);
columns.push({id: 'number', title: Common.UIString.UIString('#'), sortable: false, width: '50px'});
columns.push({
id: 'key',
diff --git a/front_end/resources/ServiceWorkerCacheViews.js b/front_end/resources/ServiceWorkerCacheViews.js
index 9b2e8b9..f6a86d3 100644
--- a/front_end/resources/ServiceWorkerCacheViews.js
+++ b/front_end/resources/ServiceWorkerCacheViews.js
@@ -115,7 +115,7 @@
* @return {!DataGrid.DataGrid.DataGridImpl}
*/
_createDataGrid() {
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'number', title: '#', sortable: false, width: '3px'},
{id: 'name', title: Common.UIString.UIString('Name'), weight: 4, sortable: true},
{id: 'responseType', title: ls`Response-Type`, weight: 1, align: DataGrid.DataGrid.Align.Right, sortable: true},
diff --git a/front_end/timeline/EventsTimelineTreeView.js b/front_end/timeline/EventsTimelineTreeView.js
index a77e76f..db758ff 100644
--- a/front_end/timeline/EventsTimelineTreeView.js
+++ b/front_end/timeline/EventsTimelineTreeView.js
@@ -115,7 +115,7 @@
/**
* @override
- * @param {!Array<!DataGrid.ColumnDescriptor>} columns
+ * @param {!Array<!DataGrid.DataGrid.ColumnDescriptor>} columns
*/
populateColumns(columns) {
columns.push({
diff --git a/front_end/timeline/TimelineTreeView.js b/front_end/timeline/TimelineTreeView.js
index 7d6ad99..23466470 100644
--- a/front_end/timeline/TimelineTreeView.js
+++ b/front_end/timeline/TimelineTreeView.js
@@ -87,7 +87,7 @@
this._currentThreadSetting = self.Common.settings.createSetting('timelineTreeCurrentThread', 0);
this._currentThreadSetting.addChangeListener(this.refreshTree, this);
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([]);
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([]);
this.populateColumns(columns);
this._splitWidget = new UI.SplitWidget.SplitWidget(true, true, 'timelineTreeViewDetailsSplitWidget');
@@ -304,7 +304,7 @@
/**
* @protected
- * @param {!Array<!DataGrid.ColumnDescriptor>} columns
+ * @param {!Array<!DataGrid.DataGrid.ColumnDescriptor>} columns
*/
populateColumns(columns) {
columns.push(
@@ -1037,7 +1037,7 @@
const header = this.element.createChild('div', 'timeline-stack-view-header');
header.textContent = Common.UIString.UIString('Heaviest stack');
this._treeView = treeView;
- const columns = /** @type {!Array<!DataGrid.ColumnDescriptor>} */ ([
+ const columns = /** @type {!Array<!DataGrid.DataGrid.ColumnDescriptor>} */ ([
{id: 'total', title: Common.UIString.UIString('Total Time'), fixedWidth: true, width: '110px'},
{id: 'activity', title: Common.UIString.UIString('Activity')}
]);
