[ts] Type-check object_ui/ObjectPopoverHelper.js with TypeScript
[email protected]
Bug: chromium:1011811
Change-Id: Ief1558430203f7bd9fa39e01efd89982af867c6b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485077
Reviewed-by: Tim van der Lippe <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
diff --git a/front_end/object_ui/ObjectPopoverHelper.js b/front_end/object_ui/ObjectPopoverHelper.js
index 9fa58d3..814398a 100644
--- a/front_end/object_ui/ObjectPopoverHelper.js
+++ b/front_end/object_ui/ObjectPopoverHelper.js
@@ -28,9 +28,6 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// @ts-nocheck
-// TODO(crbug.com/1011811): Enable TypeScript compiler checks
-
import * as Components from '../components/components.js';
import * as SDK from '../sdk/sdk.js';
import * as UI from '../ui/ui.js';
@@ -63,7 +60,7 @@
* @return {!Promise<?ObjectPopoverHelper>}
*/
static async buildObjectPopover(result, popover) {
- const description = result.description.trimEndWithMaxLength(MaxPopoverTextLength);
+ const description = (result.description || '').trimEndWithMaxLength(MaxPopoverTextLength);
let popoverContentElement = null;
if (result.type === 'object') {
let linkifier = null;
@@ -97,7 +94,7 @@
return new ObjectPopoverHelper(linkifier, resultHighlightedAsDOM);
}
- popoverContentElement = createElement('span');
+ popoverContentElement = document.createElement('span');
popoverContentElement.dataset.stableNameForTest = 'object-popover-content';
UI.Utils.appendStyle(popoverContentElement, 'object_ui/objectValue.css');
UI.Utils.appendStyle(popoverContentElement, 'object_ui/objectPopover.css');
@@ -129,7 +126,8 @@
const rawLocation = response.location;
const linkContainer = title.createChild('div', 'function-title-link-container');
- const sourceURL = rawLocation && rawLocation.script() && rawLocation.script().sourceURL;
+ const script = rawLocation && rawLocation.script();
+ const sourceURL = script && script.sourceURL;
let linkifier = null;
if (sourceURL) {
linkifier = new Components.Linkifier.Linkifier(undefined, undefined, popover.positionContent.bind(popover));
