Clean up code around row heights in NetworkLogView
Formerly there was some code to calculate the row height to use,
but since the calculation has been removed, we can also remove
the code surrounding it and simplify to only use one row height.
Bug: none
Change-Id: I56616a27a291b2e6b21f47be84a40c528b79784e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6651612
Reviewed-by: Wolfgang Beyer <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts
index a0f47c9..446b853 100644
--- a/front_end/panels/network/NetworkLogView.ts
+++ b/front_end/panels/network/NetworkLogView.ts
@@ -484,7 +484,6 @@
private readonly networkOnlyThirdPartySetting: Common.Settings.Setting<boolean>;
private readonly networkResourceTypeFiltersSetting: Common.Settings.Setting<Record<string, boolean>>;
private readonly networkShowOptionsToGenerateHarWithSensitiveData: Common.Settings.Setting<boolean>;
- private rawRowHeight: number;
private readonly progressBarContainer: Element;
private readonly networkLogLargeRowsSetting: Common.Settings.Setting<boolean>;
private rowHeightInternal: number;
@@ -542,16 +541,13 @@
this.networkShowOptionsToGenerateHarWithSensitiveData = Common.Settings.Settings.instance().createSetting(
'network.show-options-to-generate-har-with-sensitive-data', false);
- this.rawRowHeight = 0;
this.progressBarContainer = progressBarContainer;
this.networkLogLargeRowsSetting = networkLogLargeRowsSetting;
this.networkLogLargeRowsSetting.addChangeListener(updateRowHeight.bind(this), this);
function updateRowHeight(this: NetworkLogView): void {
- this.rawRowHeight = Boolean(this.networkLogLargeRowsSetting.get()) ? 41 : 21;
- this.rowHeightInternal = this.computeRowHeight();
+ this.rowHeightInternal = Boolean(this.networkLogLargeRowsSetting.get()) ? 41 : 21;
}
- this.rawRowHeight = 0;
this.rowHeightInternal = 0;
updateRowHeight.call(this);
@@ -928,10 +924,6 @@
this.invalidateAllItems();
}
- private computeRowHeight(): number {
- return this.rawRowHeight;
- }
-
nodeForRequest(request: SDK.NetworkRequest.NetworkRequest): NetworkRequestNode|null {
return networkRequestToNode.get(request) || null;
}
@@ -1381,10 +1373,6 @@
this.columnsInternal.willHide();
}
- override onResize(): void {
- this.rowHeightInternal = this.computeRowHeight();
- }
-
flatNodesList(): NetworkNode[] {
const rootNode =
(this.dataGrid.rootNode() as
