| commit | b3042fbc924bd7821bc08ba465248dd8dbb63bbb | [log] [tgz] |
|---|---|---|
| author | Simon Zünd <[email protected]> | Wed Dec 11 06:43:06 2024 |
| committer | Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 11 07:53:56 2024 |
| tree | dd5731441527520bccb72f032df65d74d1b86fd4 | |
| parent | fcc22ff0f7195f1dfdb7f8605b6b07c3a79cd02e [diff] [blame] |
Fix network category filters when using locales other than en-US The CL https://crrev.com/c/5938364 changed resource categories to use an un-localized name as a key, as this was messsing with VE logging. This broke the filter UI for non-english locales, as the NetworkLogView would retrieve the "title" instead of the "name" from each NetworkRequest to check if a filter applies. This CL fixes this and adds a regression test. [email protected] Fixed: 382596366 Change-Id: I039614285a99b948ea21b224255be557ad5a5fb4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6085916 Reviewed-by: Danil Somsikov <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts index 99ee05d..416fad8 100644 --- a/front_end/panels/network/NetworkLogView.ts +++ b/front_end/panels/network/NetworkLogView.ts
@@ -1999,7 +1999,7 @@ if (this.timeFilter && !this.timeFilter(request)) { return false; } - const categoryName = request.resourceType().category().title(); + const categoryName = request.resourceType().category().name; if (!this.resourceCategoryFilterUI.accept(categoryName)) { return false; }