Remove customKeyboardShortcuts experiment
This CL removes the customKeyboardShortcuts experiment, which was
enabled by default in Chromium 86.
Design doc: https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit#
Bug: 174309
Change-Id: I5e93e94bbf3bc7376f7d02ec8f5985ee594e58c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2464000
Commit-Queue: Jack Lynch <[email protected]>
Reviewed-by: Paul Lewis <[email protected]>
Reviewed-by: Tim van der Lippe <[email protected]>
diff --git a/front_end/settings/SettingsScreen.js b/front_end/settings/SettingsScreen.js
index decc5b0..5b5075f 100644
--- a/front_end/settings/SettingsScreen.js
+++ b/front_end/settings/SettingsScreen.js
@@ -70,15 +70,9 @@
tabbedPane.setShrinkableTabs(false);
tabbedPane.makeVerticalTabLayout();
- if (!Root.Runtime.experiments.isEnabled('customKeyboardShortcuts')) {
- const shortcutsView = new UI.View.SimpleView(ls`Shortcuts`);
- UI.ShortcutsScreen.ShortcutsScreen.instance().createShortcutsTabView().show(shortcutsView.element);
- this._tabbedLocation.appendView(shortcutsView);
- } else {
- UI.ViewManager.ViewManager.instance().view('keybinds').widget().then(widget => {
- this._keybindsTab = widget;
- });
- }
+ UI.ViewManager.ViewManager.instance().view('keybinds').widget().then(widget => {
+ this._keybindsTab = widget;
+ });
tabbedPane.show(this.contentElement);
tabbedPane.selectTab('preferences');
tabbedPane.addEventListener(UI.TabbedPane.Events.TabInvoked, this._tabInvoked, this);
@@ -414,7 +408,6 @@
* @return {boolean}
*/
handleAction(context, actionId) {
- let screen;
switch (actionId) {
case 'settings.show':
SettingsScreen._showSettingsScreen({focusTabHeader: true});
@@ -424,11 +417,7 @@
UI.UIUtils.addReferrerToURL('https://developers.google.com/web/tools/chrome-devtools/'));
return true;
case 'settings.shortcuts':
- screen = {name: ls`Shortcuts`, focusTabHeader: true};
- if (Root.Runtime.experiments.isEnabled('customKeyboardShortcuts')) {
- screen = {name: 'keybinds', focusTabHeader: true};
- }
- SettingsScreen._showSettingsScreen(screen);
+ SettingsScreen._showSettingsScreen({name: 'keybinds', focusTabHeader: true});
return true;
}
return false;
